From: Nicolin Chen <nicoleotsuka@gmail.com>
To: Caleb Crome <caleb@crome.org>
Cc: Timur Tabi <timur@tabi.org>, Xiubo Li <Xiubo.Lee@gmail.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>
Subject: Re: [PATCH RFC 1/1] ASoC: fsl_ssi: Make fifo watermark and maxburst settings device tree options
Date: Fri, 15 Jan 2016 10:12:49 -0800 [thread overview]
Message-ID: <20160115181248.GA31703@Asurada-Nvidia> (raw)
In-Reply-To: <CAG5mAdyH1FOYCxYM14fknnRmaSBERMLx_k_D+RCUMiSjWMRvBA@mail.gmail.com>
On Thu, Jan 14, 2016 at 08:56:31PM -0800, Caleb Crome wrote:
> On Thu, Jan 14, 2016 at 6:45 PM, Nicolin Chen <nicoleotsuka@gmail.com> wrote:
> > On Thu, Jan 14, 2016 at 01:26:24PM -0800, Caleb Crome wrote:
> >
> >> As for optimal settings, I finally came to a setting of 4 for depth &
> >> maxburst, which will result in more DMA requests, but it's the only
> >> way that works at 48kHz for me. The default settings is 13 (15 - 2)
> >> for the ones of the 15 item fifo, which is a pretty dramatic
> >> difference. I just don't know if other chips will behave badly in
> >> that case.
> >
> > What's your final configuration for TFWM0 bits, 4?
>
> Yes, a value of 4 for my use case: i.MX6 @ 768000 words/second (48khz
> * 16 channels).
4 means there are >= 4 empty slots in the FIFO, so there are no more
than 11 remaining data. This makes sense.
IIRC, the Freescale official BSP release for i.MX is used to set 6 to
TFWM0/1 in the old day, not sure about recent ones though. So I think
setting 4 to TFWM0/1 should work for most of cases. We may also let
others test it before merging it.
Actually a setting of 13 is much more risky in my opinion. It means
only two empty slots in the FIFO, so it might be easily to get under/
overflow if a DMA transaction gets delay somehow. The only benefit is
that DMA requests and interrupt (FIQ) can be reduced.
next prev parent reply other threads:[~2016-01-15 18:12 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-14 16:29 [PATCH RFC 1/1] ASoC: fsl_ssi: Make fifo watermark and maxburst settings device tree options Caleb Crome
[not found] ` <1452788982-11583-1-git-send-email-caleb-EebDDntmC0DYtjvyW6yDsg@public.gmane.org>
2016-01-14 20:18 ` Nicolin Chen
2016-01-14 20:18 ` Nicolin Chen
2016-01-14 21:26 ` Caleb Crome
2016-01-14 21:26 ` Caleb Crome
2016-01-15 2:45 ` Nicolin Chen
2016-01-15 4:56 ` Caleb Crome
2016-01-15 4:56 ` Caleb Crome
2016-01-15 18:12 ` Nicolin Chen [this message]
2016-01-15 1:31 ` Timur Tabi
2016-01-15 2:33 ` Nicolin Chen
2016-01-15 3:25 ` Rob Herring
2016-01-15 3:25 ` Rob Herring
[not found] ` <56984BE7.2050303-N01EOCouUvQ@public.gmane.org>
2016-01-15 13:13 ` Mark Brown
2016-01-15 13:13 ` Mark Brown
[not found] ` <20160115131325.GW6588-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2016-01-15 13:46 ` Timur Tabi
2016-01-15 13:46 ` Timur Tabi
2016-01-15 17:03 ` Caleb Crome
2016-01-15 17:03 ` Caleb Crome
2016-01-15 18:38 ` Nicolin Chen
2016-01-15 18:49 ` Caleb Crome
2016-01-15 18:57 ` Nicolin Chen
2016-01-15 19:10 ` Caleb Crome
2016-01-15 19:23 ` Nicolin Chen
2016-01-15 19:23 ` Nicolin Chen
2016-01-15 19:49 ` Timur Tabi
[not found] ` <CAG5mAdyUfSuCqA4_342MS2AyshvuyeiYsjQyRqifmqVhn4T2xA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-01-16 14:15 ` Timur Tabi
2016-01-16 14:15 ` Timur Tabi
2016-01-17 23:34 ` Caleb Crome
2016-01-15 19:51 ` Timur Tabi
2016-01-15 19:51 ` Timur Tabi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160115181248.GA31703@Asurada-Nvidia \
--to=nicoleotsuka@gmail.com \
--cc=Xiubo.Lee@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=caleb@crome.org \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=timur@tabi.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.