From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Grygorii Strashko <grygorii.strashko@ti.com>
Cc: Russell King <rmk+kernel@arm.linux.org.uk>,
linux-rt-users@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Sekhar Nori <nsekhar@ti.com>
Subject: Re: [4.4-rt2 PATCH] ARM: highmem: take into account FIX_KMAP_BEGIN in switch_kmaps()
Date: Fri, 15 Jan 2016 17:56:26 +0100 [thread overview]
Message-ID: <20160115165626.GE3781@linutronix.de> (raw)
In-Reply-To: <1452867647-1410-1-git-send-email-grygorii.strashko@ti.com>
* Grygorii Strashko | 2016-01-15 16:20:47 [+0200]:
>Now the random crashes are observed on ARM TI am437x-idk-evm used with
>-RT Kernel v4.4-rt2 and with Highmem enabled.
>
>The reason of issue is that, newly introduced switch_kmaps() does not
>take into account FIX_KMAP_BEGIN, which was re-added by
>commit a5f4c561b3b1 ("ARM: 8415/1: early fixmap support for earlycon")
>(K4.3) for ARM and since that the value of FIX_KMAP_BEGIN
>is not 0 any more.
>
>Hence update switch_kmaps() so it will take into FIX_KMAP_BEGIN while
>calculating fixmap idx. This patch also introduces fixmap_idx() to
>make code simpler and remove duplicated code.
Thank you debugging and fixing this. I will fold this into the initial
patch since it is a v4.1..v4.4 fallout. Regarding your "nobody else be
me" question in the other mail: once I managed something ARM+highmem I
I see this:
|Welcome to Debian GNU/Linux stretch/sid!
|
|[ 11.738637] systemd[1]: Set hostname to <vexpress>.
|[ 11.909949] ------------[ cut here ]------------
|[ 11.909958] kernel BUG at arch/arm/mm/highmem.c:90!
So I did not get as far as a shell to start anything.
>Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
>Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
Sebastian
WARNING: multiple messages have this Message-ID (diff)
From: bigeasy@linutronix.de (Sebastian Andrzej Siewior)
To: linux-arm-kernel@lists.infradead.org
Subject: [4.4-rt2 PATCH] ARM: highmem: take into account FIX_KMAP_BEGIN in switch_kmaps()
Date: Fri, 15 Jan 2016 17:56:26 +0100 [thread overview]
Message-ID: <20160115165626.GE3781@linutronix.de> (raw)
In-Reply-To: <1452867647-1410-1-git-send-email-grygorii.strashko@ti.com>
* Grygorii Strashko | 2016-01-15 16:20:47 [+0200]:
>Now the random crashes are observed on ARM TI am437x-idk-evm used with
>-RT Kernel v4.4-rt2 and with Highmem enabled.
>
>The reason of issue is that, newly introduced switch_kmaps() does not
>take into account FIX_KMAP_BEGIN, which was re-added by
>commit a5f4c561b3b1 ("ARM: 8415/1: early fixmap support for earlycon")
>(K4.3) for ARM and since that the value of FIX_KMAP_BEGIN
>is not 0 any more.
>
>Hence update switch_kmaps() so it will take into FIX_KMAP_BEGIN while
>calculating fixmap idx. This patch also introduces fixmap_idx() to
>make code simpler and remove duplicated code.
Thank you debugging and fixing this. I will fold this into the initial
patch since it is a v4.1..v4.4 fallout. Regarding your "nobody else be
me" question in the other mail: once I managed something ARM+highmem I
I see this:
|Welcome to Debian GNU/Linux stretch/sid!
|
|[ 11.738637] systemd[1]: Set hostname to <vexpress>.
|[ 11.909949] ------------[ cut here ]------------
|[ 11.909958] kernel BUG at arch/arm/mm/highmem.c:90!
So I did not get as far as a shell to start anything.
>Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
>Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
Sebastian
next prev parent reply other threads:[~2016-01-15 16:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-15 14:20 [4.4-rt2 PATCH] ARM: highmem: take into account FIX_KMAP_BEGIN in switch_kmaps() Grygorii Strashko
2016-01-15 14:20 ` Grygorii Strashko
2016-01-15 16:56 ` Sebastian Andrzej Siewior [this message]
2016-01-15 16:56 ` Sebastian Andrzej Siewior
2016-01-20 20:21 ` Sebastian Andrzej Siewior
2016-01-20 20:21 ` Sebastian Andrzej Siewior
2016-01-20 20:23 ` Russell King - ARM Linux
2016-01-20 20:23 ` Russell King - ARM Linux
2016-01-20 20:35 ` Grygorii Strashko
2016-01-20 20:35 ` Grygorii Strashko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160115165626.GE3781@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=grygorii.strashko@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=rmk+kernel@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.