All of lore.kernel.org
 help / color / mirror / Atom feed
From: Grygorii Strashko <grygorii.strashko@ti.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: <linux-rt-users@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	Sekhar Nori <nsekhar@ti.com>
Subject: Re: [4.4-rt2 PATCH] ARM: highmem: take into account FIX_KMAP_BEGIN in switch_kmaps()
Date: Wed, 20 Jan 2016 22:35:21 +0200	[thread overview]
Message-ID: <569FEF89.1020806@ti.com> (raw)
In-Reply-To: <20160120202317.GV19062@n2100.arm.linux.org.uk>

On 01/20/2016 10:23 PM, Russell King - ARM Linux wrote:
> On Wed, Jan 20, 2016 at 09:21:39PM +0100, Sebastian Andrzej Siewior wrote:
>> * Grygorii Strashko | 2016-01-15 16:20:47 [+0200]:
>>
>>> --- a/arch/arm/mm/highmem.c
>>> +++ b/arch/arm/mm/highmem.c
>>> @@ -175,7 +180,7 @@ void switch_kmaps(struct task_struct *prev_p, struct task_struct *next_p)
>>> 	 * Restore @next_p's kmap_atomic mappings
>>> 	 */
>>> 	for (i = 0; i < next_p->kmap_idx; i++) {
>>> -		int idx = i + KM_TYPE_NR * smp_processor_id();
>>> +		int idx = fixmap_idx(i);
>>>
>>> 		if (!pte_none(next_p->kmap_pte[i]))
>>> 			set_fixmap_pte(idx, next_p->kmap_pte[i]);
>>
>> Grygorii, if you remove this chunk then it should apply upstream. Could
>> you forward it upstream then please? So the -RT piece would shrink a
>> little:)
>
> Or I could commit my own patch which forms a proportion of this change.
>

np from my side.

-- 
regards,
-grygorii

WARNING: multiple messages have this Message-ID (diff)
From: grygorii.strashko@ti.com (Grygorii Strashko)
To: linux-arm-kernel@lists.infradead.org
Subject: [4.4-rt2 PATCH] ARM: highmem: take into account FIX_KMAP_BEGIN in switch_kmaps()
Date: Wed, 20 Jan 2016 22:35:21 +0200	[thread overview]
Message-ID: <569FEF89.1020806@ti.com> (raw)
In-Reply-To: <20160120202317.GV19062@n2100.arm.linux.org.uk>

On 01/20/2016 10:23 PM, Russell King - ARM Linux wrote:
> On Wed, Jan 20, 2016 at 09:21:39PM +0100, Sebastian Andrzej Siewior wrote:
>> * Grygorii Strashko | 2016-01-15 16:20:47 [+0200]:
>>
>>> --- a/arch/arm/mm/highmem.c
>>> +++ b/arch/arm/mm/highmem.c
>>> @@ -175,7 +180,7 @@ void switch_kmaps(struct task_struct *prev_p, struct task_struct *next_p)
>>> 	 * Restore @next_p's kmap_atomic mappings
>>> 	 */
>>> 	for (i = 0; i < next_p->kmap_idx; i++) {
>>> -		int idx = i + KM_TYPE_NR * smp_processor_id();
>>> +		int idx = fixmap_idx(i);
>>>
>>> 		if (!pte_none(next_p->kmap_pte[i]))
>>> 			set_fixmap_pte(idx, next_p->kmap_pte[i]);
>>
>> Grygorii, if you remove this chunk then it should apply upstream. Could
>> you forward it upstream then please? So the -RT piece would shrink a
>> little:)
>
> Or I could commit my own patch which forms a proportion of this change.
>

np from my side.

-- 
regards,
-grygorii

  reply	other threads:[~2016-01-20 20:35 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-15 14:20 [4.4-rt2 PATCH] ARM: highmem: take into account FIX_KMAP_BEGIN in switch_kmaps() Grygorii Strashko
2016-01-15 14:20 ` Grygorii Strashko
2016-01-15 16:56 ` Sebastian Andrzej Siewior
2016-01-15 16:56   ` Sebastian Andrzej Siewior
2016-01-20 20:21 ` Sebastian Andrzej Siewior
2016-01-20 20:21   ` Sebastian Andrzej Siewior
2016-01-20 20:23   ` Russell King - ARM Linux
2016-01-20 20:23     ` Russell King - ARM Linux
2016-01-20 20:35     ` Grygorii Strashko [this message]
2016-01-20 20:35       ` Grygorii Strashko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=569FEF89.1020806@ti.com \
    --to=grygorii.strashko@ti.com \
    --cc=bigeasy@linutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rt-users@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=nsekhar@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.