From: Brian Norris <computersforpeace@gmail.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: David Woodhouse <dwmw2@infradead.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Bayi Cheng <bayi.cheng@mediatek.com>,
linux-mtd@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mtd: mtk-nor: Drop bogus __init from mtk_nor_init()
Date: Fri, 15 Jan 2016 10:01:49 -0800 [thread overview]
Message-ID: <20160115180149.GT109450@google.com> (raw)
In-Reply-To: <1452865589-555-1-git-send-email-geert@linux-m68k.org>
On Fri, Jan 15, 2016 at 02:46:29PM +0100, Geert Uytterhoeven wrote:
> WARNING: drivers/mtd/spi-nor/mtk-quadspi.o(.text+0x77e): Section mismatch in reference from the function mtk_nor_drv_probe() to the function .init.text:mtk_nor_init()
> The function mtk_nor_drv_probe() references
> the function __init mtk_nor_init().
> This is often because mtk_nor_drv_probe lacks a __init
> annotation or the annotation of mtk_nor_init is wrong.
>
> Drop the bogus __init from mtk_nor_init() to kill this warning.
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
> Presumably this went unnoticed because some versions of gcc inline
> mtk_nor_init()?
Pushed to l2-mtd.git. Thanks!
WARNING: multiple messages have this Message-ID (diff)
From: computersforpeace@gmail.com (Brian Norris)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] mtd: mtk-nor: Drop bogus __init from mtk_nor_init()
Date: Fri, 15 Jan 2016 10:01:49 -0800 [thread overview]
Message-ID: <20160115180149.GT109450@google.com> (raw)
In-Reply-To: <1452865589-555-1-git-send-email-geert@linux-m68k.org>
On Fri, Jan 15, 2016 at 02:46:29PM +0100, Geert Uytterhoeven wrote:
> WARNING: drivers/mtd/spi-nor/mtk-quadspi.o(.text+0x77e): Section mismatch in reference from the function mtk_nor_drv_probe() to the function .init.text:mtk_nor_init()
> The function mtk_nor_drv_probe() references
> the function __init mtk_nor_init().
> This is often because mtk_nor_drv_probe lacks a __init
> annotation or the annotation of mtk_nor_init is wrong.
>
> Drop the bogus __init from mtk_nor_init() to kill this warning.
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
> Presumably this went unnoticed because some versions of gcc inline
> mtk_nor_init()?
Pushed to l2-mtd.git. Thanks!
next prev parent reply other threads:[~2016-01-15 18:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-15 13:46 [PATCH] mtd: mtk-nor: Drop bogus __init from mtk_nor_init() Geert Uytterhoeven
2016-01-15 18:01 ` Brian Norris [this message]
2016-01-15 18:01 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160115180149.GT109450@google.com \
--to=computersforpeace@gmail.com \
--cc=bayi.cheng@mediatek.com \
--cc=dwmw2@infradead.org \
--cc=geert@linux-m68k.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.