* [PATCH] mtd: mtk-nor: Drop bogus __init from mtk_nor_init()
@ 2016-01-15 13:46 Geert Uytterhoeven
2016-01-15 18:01 ` Brian Norris
0 siblings, 1 reply; 3+ messages in thread
From: Geert Uytterhoeven @ 2016-01-15 13:46 UTC (permalink / raw)
To: David Woodhouse, Brian Norris, Matthias Brugger, Bayi Cheng
Cc: linux-mtd, linux-arm-kernel, linux-mediatek, linux-kernel,
Geert Uytterhoeven
WARNING: drivers/mtd/spi-nor/mtk-quadspi.o(.text+0x77e): Section mismatch in reference from the function mtk_nor_drv_probe() to the function .init.text:mtk_nor_init()
The function mtk_nor_drv_probe() references
the function __init mtk_nor_init().
This is often because mtk_nor_drv_probe lacks a __init
annotation or the annotation of mtk_nor_init is wrong.
Drop the bogus __init from mtk_nor_init() to kill this warning.
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
Presumably this went unnoticed because some versions of gcc inline
mtk_nor_init()?
---
drivers/mtd/spi-nor/mtk-quadspi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mtd/spi-nor/mtk-quadspi.c b/drivers/mtd/spi-nor/mtk-quadspi.c
index d5f850d035bb93fb..8bed1a4cb79ce585 100644
--- a/drivers/mtd/spi-nor/mtk-quadspi.c
+++ b/drivers/mtd/spi-nor/mtk-quadspi.c
@@ -371,8 +371,8 @@ static int mt8173_nor_write_reg(struct spi_nor *nor, u8 opcode, u8 *buf,
return ret;
}
-static int __init mtk_nor_init(struct mt8173_nor *mt8173_nor,
- struct device_node *flash_node)
+static int mtk_nor_init(struct mt8173_nor *mt8173_nor,
+ struct device_node *flash_node)
{
int ret;
struct spi_nor *nor;
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mtd: mtk-nor: Drop bogus __init from mtk_nor_init()
2016-01-15 13:46 [PATCH] mtd: mtk-nor: Drop bogus __init from mtk_nor_init() Geert Uytterhoeven
@ 2016-01-15 18:01 ` Brian Norris
0 siblings, 0 replies; 3+ messages in thread
From: Brian Norris @ 2016-01-15 18:01 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: David Woodhouse, Matthias Brugger, Bayi Cheng, linux-mtd,
linux-arm-kernel, linux-mediatek, linux-kernel
On Fri, Jan 15, 2016 at 02:46:29PM +0100, Geert Uytterhoeven wrote:
> WARNING: drivers/mtd/spi-nor/mtk-quadspi.o(.text+0x77e): Section mismatch in reference from the function mtk_nor_drv_probe() to the function .init.text:mtk_nor_init()
> The function mtk_nor_drv_probe() references
> the function __init mtk_nor_init().
> This is often because mtk_nor_drv_probe lacks a __init
> annotation or the annotation of mtk_nor_init is wrong.
>
> Drop the bogus __init from mtk_nor_init() to kill this warning.
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
> Presumably this went unnoticed because some versions of gcc inline
> mtk_nor_init()?
Pushed to l2-mtd.git. Thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] mtd: mtk-nor: Drop bogus __init from mtk_nor_init()
@ 2016-01-15 18:01 ` Brian Norris
0 siblings, 0 replies; 3+ messages in thread
From: Brian Norris @ 2016-01-15 18:01 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Jan 15, 2016 at 02:46:29PM +0100, Geert Uytterhoeven wrote:
> WARNING: drivers/mtd/spi-nor/mtk-quadspi.o(.text+0x77e): Section mismatch in reference from the function mtk_nor_drv_probe() to the function .init.text:mtk_nor_init()
> The function mtk_nor_drv_probe() references
> the function __init mtk_nor_init().
> This is often because mtk_nor_drv_probe lacks a __init
> annotation or the annotation of mtk_nor_init is wrong.
>
> Drop the bogus __init from mtk_nor_init() to kill this warning.
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
> Presumably this went unnoticed because some versions of gcc inline
> mtk_nor_init()?
Pushed to l2-mtd.git. Thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-01-15 18:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-15 13:46 [PATCH] mtd: mtk-nor: Drop bogus __init from mtk_nor_init() Geert Uytterhoeven
2016-01-15 18:01 ` Brian Norris
2016-01-15 18:01 ` Brian Norris
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.