From: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Anders Roxell <anders.roxell@linaro.org>,
linux-media@vger.kernel.org, linux-sh@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-rt-users@vger.kernel.org
Subject: Re: [PATCH] drivers/media: vsp1_video: fix compile error
Date: Mon, 25 Jan 2016 11:14:23 +0000 [thread overview]
Message-ID: <20160125091423.386ae714@recife.lan> (raw)
In-Reply-To: <1991984.ioj231CKOU@avalon>
Em Mon, 25 Jan 2016 00:15:28 +0200
Laurent Pinchart <laurent.pinchart@ideasonboard.com> escreveu:
> Hi Anders,
>
> Thank you for the patch.
>
> On Friday 15 January 2016 01:09:43 Anders Roxell wrote:
> > This was found with the -RT patch enabled, but the fix should apply to
> > non-RT also.
> >
> > Compilation error without this fix:
> > ../drivers/media/platform/vsp1/vsp1_video.c: In function
> > 'vsp1_pipeline_stopped':
> > ../drivers/media/platform/vsp1/vsp1_video.c:524:2: error: expected
> > expression before 'do'
> > spin_unlock_irqrestore(&pipe->irqlock, flags);
> > ^
> >
> > Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> and applied to my tree.
Better to apply this to the fixes branch and send it together with
the next set of patches upstream.
>
> > ---
> > drivers/media/platform/vsp1/vsp1_video.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/media/platform/vsp1/vsp1_video.c
> > b/drivers/media/platform/vsp1/vsp1_video.c index 637d0d6..b4dca57 100644
> > --- a/drivers/media/platform/vsp1/vsp1_video.c
> > +++ b/drivers/media/platform/vsp1/vsp1_video.c
> > @@ -515,7 +515,7 @@ static bool vsp1_pipeline_stopped(struct vsp1_pipeline
> > *pipe) bool stopped;
> >
> > spin_lock_irqsave(&pipe->irqlock, flags);
> > - stopped = pipe->state = VSP1_PIPELINE_STOPPED,
> > + stopped = pipe->state = VSP1_PIPELINE_STOPPED;
> > spin_unlock_irqrestore(&pipe->irqlock, flags);
> >
> > return stopped;
>
WARNING: multiple messages have this Message-ID (diff)
From: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Anders Roxell <anders.roxell@linaro.org>,
linux-media@vger.kernel.org, linux-sh@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-rt-users@vger.kernel.org
Subject: Re: [PATCH] drivers/media: vsp1_video: fix compile error
Date: Mon, 25 Jan 2016 09:14:23 -0200 [thread overview]
Message-ID: <20160125091423.386ae714@recife.lan> (raw)
In-Reply-To: <1991984.ioj231CKOU@avalon>
Em Mon, 25 Jan 2016 00:15:28 +0200
Laurent Pinchart <laurent.pinchart@ideasonboard.com> escreveu:
> Hi Anders,
>
> Thank you for the patch.
>
> On Friday 15 January 2016 01:09:43 Anders Roxell wrote:
> > This was found with the -RT patch enabled, but the fix should apply to
> > non-RT also.
> >
> > Compilation error without this fix:
> > ../drivers/media/platform/vsp1/vsp1_video.c: In function
> > 'vsp1_pipeline_stopped':
> > ../drivers/media/platform/vsp1/vsp1_video.c:524:2: error: expected
> > expression before 'do'
> > spin_unlock_irqrestore(&pipe->irqlock, flags);
> > ^
> >
> > Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> and applied to my tree.
Better to apply this to the fixes branch and send it together with
the next set of patches upstream.
>
> > ---
> > drivers/media/platform/vsp1/vsp1_video.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/media/platform/vsp1/vsp1_video.c
> > b/drivers/media/platform/vsp1/vsp1_video.c index 637d0d6..b4dca57 100644
> > --- a/drivers/media/platform/vsp1/vsp1_video.c
> > +++ b/drivers/media/platform/vsp1/vsp1_video.c
> > @@ -515,7 +515,7 @@ static bool vsp1_pipeline_stopped(struct vsp1_pipeline
> > *pipe) bool stopped;
> >
> > spin_lock_irqsave(&pipe->irqlock, flags);
> > - stopped = pipe->state == VSP1_PIPELINE_STOPPED,
> > + stopped = pipe->state == VSP1_PIPELINE_STOPPED;
> > spin_unlock_irqrestore(&pipe->irqlock, flags);
> >
> > return stopped;
>
next prev parent reply other threads:[~2016-01-25 11:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-15 0:09 [PATCH] drivers/media: vsp1_video: fix compile error Anders Roxell
2016-01-15 0:09 ` Anders Roxell
2016-01-24 22:15 ` Laurent Pinchart
2016-01-24 22:15 ` Laurent Pinchart
2016-01-25 11:14 ` Mauro Carvalho Chehab [this message]
2016-01-25 11:14 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160125091423.386ae714@recife.lan \
--to=mchehab@osg.samsung.com \
--cc=anders.roxell@linaro.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.