From: Mark Rutland <mark.rutland@arm.com>
To: Kees Cook <keescook@chromium.org>
Cc: David Brown <david.brown@linaro.org>,
"kernel-hardening@lists.openwall.com"
<kernel-hardening@lists.openwall.com>,
Ingo Molnar <mingo@redhat.com>,
Andy Lutomirski <luto@amacapital.net>,
"H. Peter Anvin" <hpa@zytor.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Mathias Krause <minipli@googlemail.com>,
Thomas Gleixner <tglx@linutronix.de>,
"x86@kernel.org" <x86@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
PaX Team <pageexec@freemail.hu>, Emese Revfy <re.emese@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
linux-arch <linux-arch@vger.kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
Marc Zyngier <marc.zyngier@arm.com>,
yalin wang <yalin.wang2010@gmail.com>,
Zi Shen Lim <zlim.lnx@gmail.com>, Yang Shi <yang.shi@linaro.org>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Laura Abbott <lauraa@codeaurora.org>,
"Suzuki K. Poulose" <suzuki.poulose@arm.com>,
Steve Capper <steve.capper@linaro.org>,
Jeremy Linton <jeremy.linton@arm.com>,
Mark Salter <msalter@redhat.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: [kernel-hardening] Re: [PATCH] arm64: make CONFIG_DEBUG_RODATA non-optional
Date: Thu, 28 Jan 2016 14:59:01 +0000 [thread overview]
Message-ID: <20160128145900.GN17123@leverpostej> (raw)
In-Reply-To: <CAGXu5jLy3cpLzU1MSQhS6q=5rMu2Mdp9pXncoFapPqUyQ1fO0A@mail.gmail.com>
On Thu, Jan 28, 2016 at 06:06:53AM -0800, Kees Cook wrote:
> On Thu, Jan 28, 2016 at 3:06 AM, Mark Rutland <mark.rutland@arm.com> wrote:
> > One thing I would like to do is to avoid the need for fixup_executable
> > entirely, by mapping the kernel text RO from the outset. However, that
> > requires rework of the alternatives patching (to use a temporary RW
> > alias), and I haven't had the time to look into that yet.
>
> This makes perfect sense for the rodata section, but the (future)
> postinit_rodata section we'll still want to mark RO after init
> finishes. x86 and ARM cheat by marking both RO after init, and they
> don't have to pad sections. parisc will need to solve this too.
Depending on how many postinit_rodata variables there are, we might be
able to drop those in .rodata, have them RO always, and initialise them
via a temporary RW alias (e.g. something in the vmalloc area).
The only requirement for that is that we use a helper to initialise any
__postinit_ro variables via a temporary RW alias, e.g.
#define SET_POST_INIT_RO(ptr, v) ({ \\
typeof(ptr) __ptr_rw = (ptr) \\
BUG_ON(initcalls_done); \\
__ptr_rw = create_rw_alias(__ptr); \\
__ptr_rw = v; \\
destroy_rw_alias(__ptr_rw); \\
})
...
__postinit_ro void *thing;
void __init some_init_func(void) {
void *__thing = some_ranodomized_allocator();
SET_POSTINIT_RO(thing, thing);
}
Mark.
WARNING: multiple messages have this Message-ID (diff)
From: Mark Rutland <mark.rutland@arm.com>
To: Kees Cook <keescook@chromium.org>
Cc: David Brown <david.brown@linaro.org>,
"kernel-hardening@lists.openwall.com"
<kernel-hardening@lists.openwall.com>,
Ingo Molnar <mingo@redhat.com>,
Andy Lutomirski <luto@amacapital.net>,
"H. Peter Anvin" <hpa@zytor.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Mathias Krause <minipli@googlemail.com>,
Thomas Gleixner <tglx@linutronix.de>,
"x86@kernel.org" <x86@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
PaX Team <pageexec@freemail.hu>, Emese Revfy <re.emese@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
linux-arch <linux-arch@vger.kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
Marc Zyngier <marc.zyngier@arm.com>,
yalin wang <yalin.wang2010@gmail.com>,
Zi Shen Lim <zlim.lnx@gmail.com>, Yang Shi <yang.shi@linaro.org>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Laura Abbott <lauraa@codeaurora.org>, "Suzuki K. Poulose" <suzuk>
Subject: Re: [PATCH] arm64: make CONFIG_DEBUG_RODATA non-optional
Date: Thu, 28 Jan 2016 14:59:01 +0000 [thread overview]
Message-ID: <20160128145900.GN17123@leverpostej> (raw)
In-Reply-To: <CAGXu5jLy3cpLzU1MSQhS6q=5rMu2Mdp9pXncoFapPqUyQ1fO0A@mail.gmail.com>
On Thu, Jan 28, 2016 at 06:06:53AM -0800, Kees Cook wrote:
> On Thu, Jan 28, 2016 at 3:06 AM, Mark Rutland <mark.rutland@arm.com> wrote:
> > One thing I would like to do is to avoid the need for fixup_executable
> > entirely, by mapping the kernel text RO from the outset. However, that
> > requires rework of the alternatives patching (to use a temporary RW
> > alias), and I haven't had the time to look into that yet.
>
> This makes perfect sense for the rodata section, but the (future)
> postinit_rodata section we'll still want to mark RO after init
> finishes. x86 and ARM cheat by marking both RO after init, and they
> don't have to pad sections. parisc will need to solve this too.
Depending on how many postinit_rodata variables there are, we might be
able to drop those in .rodata, have them RO always, and initialise them
via a temporary RW alias (e.g. something in the vmalloc area).
The only requirement for that is that we use a helper to initialise any
__postinit_ro variables via a temporary RW alias, e.g.
#define SET_POST_INIT_RO(ptr, v) ({ \\
typeof(ptr) __ptr_rw = (ptr) \\
BUG_ON(initcalls_done); \\
__ptr_rw = create_rw_alias(__ptr); \\
__ptr_rw = v; \\
destroy_rw_alias(__ptr_rw); \\
})
...
__postinit_ro void *thing;
void __init some_init_func(void) {
void *__thing = some_ranodomized_allocator();
SET_POSTINIT_RO(thing, thing);
}
Mark.
WARNING: multiple messages have this Message-ID (diff)
From: Mark Rutland <mark.rutland@arm.com>
To: Kees Cook <keescook@chromium.org>
Cc: David Brown <david.brown@linaro.org>,
"kernel-hardening@lists.openwall.com"
<kernel-hardening@lists.openwall.com>,
Ingo Molnar <mingo@redhat.com>,
Andy Lutomirski <luto@amacapital.net>,
"H. Peter Anvin" <hpa@zytor.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Mathias Krause <minipli@googlemail.com>,
Thomas Gleixner <tglx@linutronix.de>,
"x86@kernel.org" <x86@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
PaX Team <pageexec@freemail.hu>, Emese Revfy <re.emese@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
linux-arch <linux-arch@vger.kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
Marc Zyngier <marc.zyngier@arm.com>,
yalin wang <yalin.wang2010@gmail.com>,
Zi Shen Lim <zlim.lnx@gmail.com>, Yang Shi <yang.shi@linaro.org>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Laura Abbott <lauraa@codeaurora.org>,
"Suzuki K. Poulose" <suzuki.poulose@arm.com>,
Steve Capper <steve.capper@linaro.org>,
Jeremy Linton <jeremy.linton@arm.com>,
Mark Salter <msalter@redhat.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] arm64: make CONFIG_DEBUG_RODATA non-optional
Date: Thu, 28 Jan 2016 14:59:01 +0000 [thread overview]
Message-ID: <20160128145900.GN17123@leverpostej> (raw)
Message-ID: <20160128145901.voDgfyAEgcavVY4ufH3cugGevB-3F4bW723edSfWwuw@z> (raw)
In-Reply-To: <CAGXu5jLy3cpLzU1MSQhS6q=5rMu2Mdp9pXncoFapPqUyQ1fO0A@mail.gmail.com>
On Thu, Jan 28, 2016 at 06:06:53AM -0800, Kees Cook wrote:
> On Thu, Jan 28, 2016 at 3:06 AM, Mark Rutland <mark.rutland@arm.com> wrote:
> > One thing I would like to do is to avoid the need for fixup_executable
> > entirely, by mapping the kernel text RO from the outset. However, that
> > requires rework of the alternatives patching (to use a temporary RW
> > alias), and I haven't had the time to look into that yet.
>
> This makes perfect sense for the rodata section, but the (future)
> postinit_rodata section we'll still want to mark RO after init
> finishes. x86 and ARM cheat by marking both RO after init, and they
> don't have to pad sections. parisc will need to solve this too.
Depending on how many postinit_rodata variables there are, we might be
able to drop those in .rodata, have them RO always, and initialise them
via a temporary RW alias (e.g. something in the vmalloc area).
The only requirement for that is that we use a helper to initialise any
__postinit_ro variables via a temporary RW alias, e.g.
#define SET_POST_INIT_RO(ptr, v) ({ \\
typeof(ptr) __ptr_rw = (ptr) \\
BUG_ON(initcalls_done); \\
__ptr_rw = create_rw_alias(__ptr); \\
__ptr_rw = v; \\
destroy_rw_alias(__ptr_rw); \\
})
...
__postinit_ro void *thing;
void __init some_init_func(void) {
void *__thing = some_ranodomized_allocator();
SET_POSTINIT_RO(thing, thing);
}
Mark.
WARNING: multiple messages have this Message-ID (diff)
From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: make CONFIG_DEBUG_RODATA non-optional
Date: Thu, 28 Jan 2016 14:59:01 +0000 [thread overview]
Message-ID: <20160128145900.GN17123@leverpostej> (raw)
In-Reply-To: <CAGXu5jLy3cpLzU1MSQhS6q=5rMu2Mdp9pXncoFapPqUyQ1fO0A@mail.gmail.com>
On Thu, Jan 28, 2016 at 06:06:53AM -0800, Kees Cook wrote:
> On Thu, Jan 28, 2016 at 3:06 AM, Mark Rutland <mark.rutland@arm.com> wrote:
> > One thing I would like to do is to avoid the need for fixup_executable
> > entirely, by mapping the kernel text RO from the outset. However, that
> > requires rework of the alternatives patching (to use a temporary RW
> > alias), and I haven't had the time to look into that yet.
>
> This makes perfect sense for the rodata section, but the (future)
> postinit_rodata section we'll still want to mark RO after init
> finishes. x86 and ARM cheat by marking both RO after init, and they
> don't have to pad sections. parisc will need to solve this too.
Depending on how many postinit_rodata variables there are, we might be
able to drop those in .rodata, have them RO always, and initialise them
via a temporary RW alias (e.g. something in the vmalloc area).
The only requirement for that is that we use a helper to initialise any
__postinit_ro variables via a temporary RW alias, e.g.
#define SET_POST_INIT_RO(ptr, v) ({ \\
typeof(ptr) __ptr_rw = (ptr) \\
BUG_ON(initcalls_done); \\
__ptr_rw = create_rw_alias(__ptr); \\
__ptr_rw = v; \\
destroy_rw_alias(__ptr_rw); \\
})
...
__postinit_ro void *thing;
void __init some_init_func(void) {
void *__thing = some_ranodomized_allocator();
SET_POSTINIT_RO(thing, thing);
}
Mark.
next prev parent reply other threads:[~2016-01-28 14:59 UTC|newest]
Thread overview: 86+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-19 18:08 [kernel-hardening] [PATCH v4 0/8] introduce post-init read-only memory Kees Cook
2016-01-19 18:08 ` Kees Cook
2016-01-19 18:08 ` [kernel-hardening] [PATCH v4 1/8] asm-generic: consolidate mark_rodata_ro() Kees Cook
2016-01-19 18:08 ` Kees Cook
2016-01-19 18:08 ` [kernel-hardening] [PATCH v4 2/8] lib: add "on" and "off" to strtobool Kees Cook
2016-01-19 18:08 ` Kees Cook
2016-01-20 2:09 ` [kernel-hardening] " Joe Perches
2016-01-20 2:09 ` Joe Perches
2016-01-22 23:29 ` [kernel-hardening] " Kees Cook
2016-01-22 23:29 ` Kees Cook
2016-01-19 18:08 ` [kernel-hardening] [PATCH v4 3/8] param: convert some "on"/"off" users " Kees Cook
2016-01-19 18:08 ` Kees Cook
2016-01-27 21:11 ` [kernel-hardening] " David Brown
2016-01-27 21:11 ` David Brown
2016-01-27 21:19 ` [kernel-hardening] " Kees Cook
2016-01-28 0:09 ` [kernel-hardening] [PATCH] arm64: make CONFIG_DEBUG_RODATA non-optional David Brown
2016-01-28 0:09 ` David Brown
2016-01-28 0:09 ` David Brown
2016-01-28 0:09 ` David Brown
2016-01-28 0:09 ` David Brown
2016-01-28 0:14 ` [kernel-hardening] " Kees Cook
2016-01-28 0:14 ` Kees Cook
2016-01-28 0:14 ` Kees Cook
2016-01-28 0:14 ` Kees Cook
2016-01-28 8:20 ` [kernel-hardening] " Ard Biesheuvel
2016-01-28 8:20 ` Ard Biesheuvel
2016-01-28 8:20 ` Ard Biesheuvel
2016-01-28 8:20 ` Ard Biesheuvel
2016-01-28 11:06 ` [kernel-hardening] " Mark Rutland
2016-01-28 11:06 ` Mark Rutland
2016-01-28 11:06 ` Mark Rutland
2016-01-28 11:06 ` Mark Rutland
2016-01-28 14:06 ` [kernel-hardening] " Kees Cook
2016-01-28 14:06 ` Kees Cook
2016-01-28 14:06 ` Kees Cook
2016-01-28 14:06 ` Kees Cook
2016-01-28 14:59 ` Mark Rutland [this message]
2016-01-28 14:59 ` Mark Rutland
2016-01-28 14:59 ` Mark Rutland
2016-01-28 14:59 ` Mark Rutland
2016-01-28 15:17 ` [kernel-hardening] " Kees Cook
2016-01-28 15:17 ` Kees Cook
2016-01-28 15:17 ` Kees Cook
2016-01-28 15:17 ` Kees Cook
2016-01-19 18:08 ` [kernel-hardening] [PATCH v4 4/8] init: create cmdline param to disable readonly Kees Cook
2016-01-19 18:08 ` Kees Cook
2016-01-19 18:08 ` [kernel-hardening] [PATCH v4 5/8] x86: make CONFIG_DEBUG_RODATA non-optional Kees Cook
2016-01-19 18:08 ` Kees Cook
2016-01-19 18:08 ` [kernel-hardening] [PATCH v4 6/8] introduce post-init read-only memory Kees Cook
2016-01-19 18:08 ` Kees Cook
2016-01-19 18:08 ` [kernel-hardening] [PATCH v4 7/8] lkdtm: verify that __ro_after_init works correctly Kees Cook
2016-01-19 18:08 ` Kees Cook
2016-01-19 18:08 ` [kernel-hardening] [PATCH v4 8/8] x86, vdso: mark vDSO read-only after init Kees Cook
2016-01-19 18:08 ` Kees Cook
2016-01-19 19:09 ` [kernel-hardening] " Andy Lutomirski
2016-01-19 19:09 ` Andy Lutomirski
2016-01-20 2:51 ` [kernel-hardening] " H. Peter Anvin
2016-01-20 2:51 ` H. Peter Anvin
2016-01-20 2:56 ` [kernel-hardening] " Andy Lutomirski
2016-01-20 2:56 ` Andy Lutomirski
2016-01-22 17:19 ` [kernel-hardening] [PATCH v4 0/8] introduce post-init read-only memory David Brown
2016-01-22 17:19 ` David Brown
2016-01-22 19:16 ` [kernel-hardening] " Laura Abbott
2016-01-22 19:57 ` Kees Cook
2016-01-23 9:49 ` Geert Uytterhoeven
2016-02-16 21:36 ` [kernel-hardening] [PATCH] ARM: vdso: Mark vDSO code as read-only David Brown
2016-02-16 21:36 ` David Brown
2016-02-16 21:36 ` David Brown
2016-02-16 21:52 ` [kernel-hardening] " Kees Cook
2016-02-16 21:52 ` Kees Cook
2016-02-16 21:52 ` Kees Cook
2016-02-17 5:20 ` [kernel-hardening] " David Brown
2016-02-17 5:20 ` David Brown
2016-02-17 5:20 ` David Brown
2016-02-17 23:00 ` [kernel-hardening] " Kees Cook
2016-02-17 23:00 ` Kees Cook
2016-02-17 23:00 ` Kees Cook
2016-02-17 23:43 ` [kernel-hardening] " David Brown
2016-02-17 23:43 ` David Brown
2016-02-17 23:43 ` David Brown
2016-02-17 23:48 ` [kernel-hardening] " Kees Cook
2016-02-17 23:48 ` Kees Cook
2016-02-17 23:48 ` Kees Cook
2016-02-18 10:46 ` [kernel-hardening] " PaX Team
2016-02-18 10:46 ` PaX Team
2016-02-18 10:46 ` PaX Team
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160128145900.GN17123@leverpostej \
--to=mark.rutland@arm.com \
--cc=ard.biesheuvel@linaro.org \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=david.brown@linaro.org \
--cc=hpa@zytor.com \
--cc=jeremy.linton@arm.com \
--cc=keescook@chromium.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=lauraa@codeaurora.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=marc.zyngier@arm.com \
--cc=mingo@redhat.com \
--cc=minipli@googlemail.com \
--cc=mpe@ellerman.id.au \
--cc=msalter@redhat.com \
--cc=pageexec@freemail.hu \
--cc=re.emese@gmail.com \
--cc=steve.capper@linaro.org \
--cc=suzuki.poulose@arm.com \
--cc=tglx@linutronix.de \
--cc=will.deacon@arm.com \
--cc=x86@kernel.org \
--cc=yalin.wang2010@gmail.com \
--cc=yang.shi@linaro.org \
--cc=zlim.lnx@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.