From: Lee Jones <lee.jones@linaro.org>
To: Peter Hung <hpeter@gmail.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
linus.walleij@linaro.org, gnurou@gmail.com,
gregkh@linuxfoundation.org, paul.gortmaker@windriver.com,
jslaby@suse.com, peter_hong@fintek.com.tw,
heikki.krogerus@linux.intel.com, peter@hurleysoftware.com,
soeren.grunewald@desy.de, udknight@gmail.com,
adam.lee@canonical.com, arnd@arndb.de, manabian@gmail.com,
scottwood@freescale.com, yamada.masahiro@socionext.com,
paul.burton@imgtec.com, mans@mansr.com, matthias.bgg@gmail.com,
ralf@linux-mips.org, linux-kernel@vger.kernel.org,
linux-gpio@vger.kernel.org, linux-serial@vger.kernel.org,
tom_tsai@fintek.com.tw,
Peter Hung <hpeter+linux_kernel@gmail.com>
Subject: Re: [PATCH V2 1/4] mfd: f81504-core: Add Fintek F81504/508/512 PCIE-to-UART/GPIO core support
Date: Fri, 29 Jan 2016 08:21:48 +0000 [thread overview]
Message-ID: <20160129082148.GR3368@x1> (raw)
In-Reply-To: <56AAFD88.2060505@gmail.com>
On Fri, 29 Jan 2016, Peter Hung wrote:
> >>+obj-$(CONFIG_MFD_FINTEK_F81504_CORE) += f81504-core.o
> >
> >I think '_' is better than '-'. What I saw and usually do is '_' for
> >regular source modules and '-' for the resulting objects when they have
> >more than one file.
>
> I used f81504_core.c originally, but I found most of files are named
> xxx-ooo.c when I try to modify makefile. Should I change it to
> f81504_core.c ??
I prefer '-' in MFD.
> >>+#define F81504_DEV_DESC "Fintek F81504/508/512 PCIE-
> >>to-UART core"
> >
> >Do you need this definition? Is it used more than once?
>
> ok, I'll direct use the string without define.
Please rid all of the {DEV_NAME,DEV_DEC} defines, they only serve to
obfuscate code.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: Peter Hung <hpeter@gmail.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
linus.walleij@linaro.org, gnurou@gmail.com,
gregkh@linuxfoundation.org, paul.gortmaker@windriver.com,
jslaby@suse.com, peter_hong@fintek.com.tw,
heikki.krogerus@linux.intel.com, peter@hurleysoftware.com,
soeren.grunewald@desy.de, udknight@gmail.com,
adam.lee@canonical.com, arnd@arndb.de, manabian@gmail.com,
scottwood@freescale.com, yamada.masahiro@socionext.com,
paul.burton@imgtec.com, mans@mansr.com, matthias.bgg@gmail.com,
ralf@linux-mips.org, linux-kernel@vger.kernel.org,
linux-gpio@vger.kernel.org, linux-serial@vger.kernel.org,
tom_tsai@fintek.com.tw,
Peter Hung <hpeter+linux_kernel@gmail.com>
Subject: Re: [PATCH V2 1/4] mfd: f81504-core: Add Fintek F81504/508/512 PCIE-to-UART/GPIO core support
Date: Fri, 29 Jan 2016 08:21:48 +0000 [thread overview]
Message-ID: <20160129082148.GR3368@x1> (raw)
In-Reply-To: <56AAFD88.2060505@gmail.com>
On Fri, 29 Jan 2016, Peter Hung wrote:
> >>+obj-$(CONFIG_MFD_FINTEK_F81504_CORE) += f81504-core.o
> >
> >I think '_' is better than '-'. What I saw and usually do is '_' for
> >regular source modules and '-' for the resulting objects when they have
> >more than one file.
>
> I used f81504_core.c originally, but I found most of files are named
> xxx-ooo.c when I try to modify makefile. Should I change it to
> f81504_core.c ??
I prefer '-' in MFD.
> >>+#define F81504_DEV_DESC "Fintek F81504/508/512 PCIE-
> >>to-UART core"
> >
> >Do you need this definition? Is it used more than once?
>
> ok, I'll direct use the string without define.
Please rid all of the {DEV_NAME,DEV_DEC} defines, they only serve to
obfuscate code.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2016-01-29 8:21 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-28 9:20 [PATCH V2 0/4] Transform Fintek PCIE driver from 8250 to MFD Peter Hung
2016-01-28 9:20 ` [PATCH V2 1/4] mfd: f81504-core: Add Fintek F81504/508/512 PCIE-to-UART/GPIO core support Peter Hung
2016-01-28 10:04 ` One Thousand Gnomes
2016-01-29 2:22 ` Peter Hung
2016-01-28 11:55 ` Andy Shevchenko
2016-01-29 5:50 ` Peter Hung
2016-01-29 8:21 ` Lee Jones [this message]
2016-01-29 8:21 ` Lee Jones
2016-01-29 12:47 ` Andy Shevchenko
2016-02-01 8:29 ` Lee Jones
2016-01-29 13:41 ` Andy Shevchenko
2016-02-01 2:51 ` Peter Hung
2016-02-01 2:51 ` Peter Hung
2016-01-28 9:20 ` [PATCH V2 2/4] gpio: gpio-f81504: Add Fintek F81504/508/512 PCIE-to-UART/GPIO GPIOLIB support Peter Hung
2016-01-28 9:54 ` kbuild test robot
2016-01-28 9:54 ` [PATCH] gpio: gpio-f81504: fix platform_no_drv_owner.cocci warnings kbuild test robot
2016-01-28 12:03 ` [PATCH V2 2/4] gpio: gpio-f81504: Add Fintek F81504/508/512 PCIE-to-UART/GPIO GPIOLIB support Andy Shevchenko
2016-01-29 8:15 ` Peter Hung
2016-01-29 8:15 ` Peter Hung
2016-02-10 9:08 ` Linus Walleij
2016-02-10 9:08 ` Linus Walleij
2016-02-16 7:03 ` Peter Hung
2016-02-16 7:03 ` Peter Hung
2016-01-28 9:20 ` [PATCH V2 3/4] 8250: 8250_f81504: Add Fintek F81504/508/512 PCIE-to-UART/GPIO UART support Peter Hung
2016-01-28 10:17 ` One Thousand Gnomes
2016-01-28 11:06 ` kbuild test robot
2016-01-28 11:06 ` [PATCH] 8250: 8250_f81504: fix platform_no_drv_owner.cocci warnings kbuild test robot
2016-01-28 9:20 ` [PATCH V2 4/4] serial: 8250_pci: Remove Fintek F81504/508/512 UART driver Peter Hung
2016-01-28 12:04 ` Andy Shevchenko
2016-01-29 8:20 ` Peter Hung
2016-01-29 8:20 ` Peter Hung
2016-01-29 12:40 ` Andy Shevchenko
2016-01-29 12:40 ` Andy Shevchenko
2016-02-01 3:33 ` Peter Hung
2016-02-01 3:33 ` Peter Hung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160129082148.GR3368@x1 \
--to=lee.jones@linaro.org \
--cc=adam.lee@canonical.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=gnurou@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=hpeter+linux_kernel@gmail.com \
--cc=hpeter@gmail.com \
--cc=jslaby@suse.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=manabian@gmail.com \
--cc=mans@mansr.com \
--cc=matthias.bgg@gmail.com \
--cc=paul.burton@imgtec.com \
--cc=paul.gortmaker@windriver.com \
--cc=peter@hurleysoftware.com \
--cc=peter_hong@fintek.com.tw \
--cc=ralf@linux-mips.org \
--cc=scottwood@freescale.com \
--cc=soeren.grunewald@desy.de \
--cc=tom_tsai@fintek.com.tw \
--cc=udknight@gmail.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.