From: Darren Hart <dvhart@infradead.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Sreedhara DS <sreedhara.ds@intel.com>,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] intel_scu_ipcutil: underflow in scu_reg_access()
Date: Sat, 30 Jan 2016 17:42:39 +0000 [thread overview]
Message-ID: <20160130174239.GC9269@malice.jf.intel.com> (raw)
In-Reply-To: <20160126092425.GA15717@mwanda>
On Tue, Jan 26, 2016 at 12:24:25PM +0300, Dan Carpenter wrote:
> "count" is controlled by the user and it can be negative. Let's prevent
> that by making it unsigned. You have to have CAP_SYS_RAWIO to call this
> function so the bug is not as serious as it could be.
>
> Fixes: 5369c02d951a ('intel_scu_ipc: Utility driver for intel scu ipc')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Queued to fixes for 4.5-rc1 as well as stable.
Thanks Dan,
--
Darren Hart
Intel Open Source Technology Center
WARNING: multiple messages have this Message-ID (diff)
From: Darren Hart <dvhart@infradead.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Sreedhara DS <sreedhara.ds@intel.com>,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] intel_scu_ipcutil: underflow in scu_reg_access()
Date: Sat, 30 Jan 2016 09:42:39 -0800 [thread overview]
Message-ID: <20160130174239.GC9269@malice.jf.intel.com> (raw)
In-Reply-To: <20160126092425.GA15717@mwanda>
On Tue, Jan 26, 2016 at 12:24:25PM +0300, Dan Carpenter wrote:
> "count" is controlled by the user and it can be negative. Let's prevent
> that by making it unsigned. You have to have CAP_SYS_RAWIO to call this
> function so the bug is not as serious as it could be.
>
> Fixes: 5369c02d951a ('intel_scu_ipc: Utility driver for intel scu ipc')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Queued to fixes for 4.5-rc1 as well as stable.
Thanks Dan,
--
Darren Hart
Intel Open Source Technology Center
next prev parent reply other threads:[~2016-01-30 17:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-26 9:24 [patch] intel_scu_ipcutil: underflow in scu_reg_access() Dan Carpenter
2016-01-26 9:24 ` Dan Carpenter
2016-01-30 17:42 ` Darren Hart [this message]
2016-01-30 17:42 ` Darren Hart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160130174239.GC9269@malice.jf.intel.com \
--to=dvhart@infradead.org \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=sreedhara.ds@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.