* [patch] intel_scu_ipcutil: underflow in scu_reg_access()
@ 2016-01-26 9:24 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2016-01-26 9:24 UTC (permalink / raw)
To: Darren Hart, Sreedhara DS
Cc: platform-driver-x86, linux-kernel, kernel-janitors
"count" is controlled by the user and it can be negative. Let's prevent
that by making it unsigned. You have to have CAP_SYS_RAWIO to call this
function so the bug is not as serious as it could be.
Fixes: 5369c02d951a ('intel_scu_ipc: Utility driver for intel scu ipc')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/platform/x86/intel_scu_ipcutil.c b/drivers/platform/x86/intel_scu_ipcutil.c
index 02bc5a6..aa45424 100644
--- a/drivers/platform/x86/intel_scu_ipcutil.c
+++ b/drivers/platform/x86/intel_scu_ipcutil.c
@@ -49,7 +49,7 @@ struct scu_ipc_data {
static int scu_reg_access(u32 cmd, struct scu_ipc_data *data)
{
- int count = data->count;
+ unsigned int count = data->count;
if (count = 0 || count = 3 || count > 4)
return -EINVAL;
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [patch] intel_scu_ipcutil: underflow in scu_reg_access()
@ 2016-01-26 9:24 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2016-01-26 9:24 UTC (permalink / raw)
To: Darren Hart, Sreedhara DS
Cc: platform-driver-x86, linux-kernel, kernel-janitors
"count" is controlled by the user and it can be negative. Let's prevent
that by making it unsigned. You have to have CAP_SYS_RAWIO to call this
function so the bug is not as serious as it could be.
Fixes: 5369c02d951a ('intel_scu_ipc: Utility driver for intel scu ipc')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/platform/x86/intel_scu_ipcutil.c b/drivers/platform/x86/intel_scu_ipcutil.c
index 02bc5a6..aa45424 100644
--- a/drivers/platform/x86/intel_scu_ipcutil.c
+++ b/drivers/platform/x86/intel_scu_ipcutil.c
@@ -49,7 +49,7 @@ struct scu_ipc_data {
static int scu_reg_access(u32 cmd, struct scu_ipc_data *data)
{
- int count = data->count;
+ unsigned int count = data->count;
if (count == 0 || count == 3 || count > 4)
return -EINVAL;
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [patch] intel_scu_ipcutil: underflow in scu_reg_access()
2016-01-26 9:24 ` Dan Carpenter
@ 2016-01-30 17:42 ` Darren Hart
-1 siblings, 0 replies; 4+ messages in thread
From: Darren Hart @ 2016-01-30 17:42 UTC (permalink / raw)
To: Dan Carpenter
Cc: Sreedhara DS, platform-driver-x86, linux-kernel, kernel-janitors
On Tue, Jan 26, 2016 at 12:24:25PM +0300, Dan Carpenter wrote:
> "count" is controlled by the user and it can be negative. Let's prevent
> that by making it unsigned. You have to have CAP_SYS_RAWIO to call this
> function so the bug is not as serious as it could be.
>
> Fixes: 5369c02d951a ('intel_scu_ipc: Utility driver for intel scu ipc')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Queued to fixes for 4.5-rc1 as well as stable.
Thanks Dan,
--
Darren Hart
Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [patch] intel_scu_ipcutil: underflow in scu_reg_access()
@ 2016-01-30 17:42 ` Darren Hart
0 siblings, 0 replies; 4+ messages in thread
From: Darren Hart @ 2016-01-30 17:42 UTC (permalink / raw)
To: Dan Carpenter
Cc: Sreedhara DS, platform-driver-x86, linux-kernel, kernel-janitors
On Tue, Jan 26, 2016 at 12:24:25PM +0300, Dan Carpenter wrote:
> "count" is controlled by the user and it can be negative. Let's prevent
> that by making it unsigned. You have to have CAP_SYS_RAWIO to call this
> function so the bug is not as serious as it could be.
>
> Fixes: 5369c02d951a ('intel_scu_ipc: Utility driver for intel scu ipc')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Queued to fixes for 4.5-rc1 as well as stable.
Thanks Dan,
--
Darren Hart
Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-01-30 17:42 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-26 9:24 [patch] intel_scu_ipcutil: underflow in scu_reg_access() Dan Carpenter
2016-01-26 9:24 ` Dan Carpenter
2016-01-30 17:42 ` Darren Hart
2016-01-30 17:42 ` Darren Hart
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.