From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Mike Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@codeaurora.org>,
Emilio Lopez <emilio@elopez.com.ar>,
heiko@sntech.de, Chen-Yu Tsai <wens@csie.org>
Cc: linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Andre Przywara <andre.przywara@arm.com>
Subject: Re: [PATCH 3/5] clk: sunxi: convert current clocks registration to CLK_OF_DECLARE
Date: Thu, 4 Feb 2016 13:13:48 +0100 [thread overview]
Message-ID: <20160204121348.GF4270@lukather> (raw)
In-Reply-To: <1454402834-6385-4-git-send-email-maxime.ripard@free-electrons.com>
[-- Attachment #1: Type: text/plain, Size: 891 bytes --]
On Tue, Feb 02, 2016 at 09:47:12AM +0100, Maxime Ripard wrote:
> The current clock registration and protection code has a few drawbacks, the
> two main ones being that we create a lot of orphans clock in the
> registration phase, which will be troublesome when we will start being less
> relaxed about them.
>
> The protection code also relies on clkdev, which we don't really use but
> for this particular case.
>
> Fix both at the same time by moving everyone to the CLK_OF_DECLARE that
> will probe our clock tree in the right and thus avoid orphans, and by
> protecting directly the clock returned by our registration function.
>
> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Fixed the issue reported by Andre, and applied.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/5] clk: sunxi: convert current clocks registration to CLK_OF_DECLARE
Date: Thu, 4 Feb 2016 13:13:48 +0100 [thread overview]
Message-ID: <20160204121348.GF4270@lukather> (raw)
In-Reply-To: <1454402834-6385-4-git-send-email-maxime.ripard@free-electrons.com>
On Tue, Feb 02, 2016 at 09:47:12AM +0100, Maxime Ripard wrote:
> The current clock registration and protection code has a few drawbacks, the
> two main ones being that we create a lot of orphans clock in the
> registration phase, which will be troublesome when we will start being less
> relaxed about them.
>
> The protection code also relies on clkdev, which we don't really use but
> for this particular case.
>
> Fix both at the same time by moving everyone to the CLK_OF_DECLARE that
> will probe our clock tree in the right and thus avoid orphans, and by
> protecting directly the clock returned by our registration function.
>
> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Fixed the issue reported by Andre, and applied.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160204/d458471c/attachment.sig>
next prev parent reply other threads:[~2016-02-04 12:13 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-02 8:47 [PATCH 0/5] clk: sunxi: Rework the clocks code to deal with orphans Maxime Ripard
2016-02-02 8:47 ` Maxime Ripard
2016-02-02 8:47 ` [PATCH 1/5] clk: sunxi: Make clocks setup functions return their clock Maxime Ripard
2016-02-02 8:47 ` Maxime Ripard
2016-02-02 10:35 ` Chen-Yu Tsai
2016-02-02 11:32 ` Andre Przywara
2016-02-02 11:32 ` Andre Przywara
2016-02-02 13:27 ` Maxime Ripard
2016-02-02 13:27 ` Maxime Ripard
2016-02-04 12:07 ` Maxime Ripard
2016-02-04 12:07 ` Maxime Ripard
2016-02-02 8:47 ` [PATCH 2/5] clk: sunxi: Make clocks setup functions take const pointer Maxime Ripard
2016-02-02 8:47 ` Maxime Ripard
2016-02-02 10:38 ` Chen-Yu Tsai
2016-02-02 12:11 ` Andre Przywara
2016-02-02 12:11 ` Andre Przywara
2016-02-04 12:08 ` Maxime Ripard
2016-02-04 12:08 ` Maxime Ripard
2016-02-02 8:47 ` [PATCH 3/5] clk: sunxi: convert current clocks registration to CLK_OF_DECLARE Maxime Ripard
2016-02-02 8:47 ` Maxime Ripard
2016-02-02 14:16 ` Andre Przywara
2016-02-02 14:16 ` Andre Przywara
2016-02-02 17:00 ` Maxime Ripard
2016-02-02 17:00 ` Maxime Ripard
2016-02-02 17:04 ` Andre Przywara
2016-02-02 17:04 ` Andre Przywara
2016-02-04 12:13 ` Maxime Ripard [this message]
2016-02-04 12:13 ` Maxime Ripard
2016-02-02 8:47 ` [PATCH 4/5] clk: sunxi: Remove old probe and protection code Maxime Ripard
2016-02-02 8:47 ` Maxime Ripard
2016-02-04 12:15 ` Maxime Ripard
2016-02-04 12:15 ` Maxime Ripard
2016-02-02 8:47 ` [PATCH 5/5] clk: sunxi: Remove clk_register_clkdev calls Maxime Ripard
2016-02-02 8:47 ` Maxime Ripard
2016-02-02 10:26 ` Jean-Francois Moine
2016-02-02 10:26 ` Jean-Francois Moine
2016-02-03 19:29 ` Maxime Ripard
2016-02-03 19:29 ` Maxime Ripard
2016-02-04 12:17 ` Maxime Ripard
2016-02-04 12:17 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160204121348.GF4270@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=andre.przywara@arm.com \
--cc=emilio@elopez.com.ar \
--cc=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@codeaurora.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.