From: Andre Przywara <andre.przywara@arm.com>
To: Maxime Ripard <maxime.ripard@free-electrons.com>,
Mike Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@codeaurora.org>,
Emilio Lopez <emilio@elopez.com.ar>,
heiko@sntech.de, Chen-Yu Tsai <wens@csie.org>
Cc: linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/5] clk: sunxi: Make clocks setup functions take const pointer
Date: Tue, 2 Feb 2016 12:11:36 +0000 [thread overview]
Message-ID: <56B09CF8.2020801@arm.com> (raw)
In-Reply-To: <1454402834-6385-3-git-send-email-maxime.ripard@free-electrons.com>
On 02/02/16 08:47, Maxime Ripard wrote:
> All the data structure that we pass to the clocks setup functions are
> declared const, while our setup functions expects a regular pointer. This
> was hidden by the fact that we cast a void * pointer back to these
> structures, which made it go unnoticed.
>
> Fix the functions prototype.
>
> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Reviewed-by: Andre Przywara <andre.przywara@arm.com>
Cheers,
Andre.
> ---
> drivers/clk/sunxi/clk-sunxi.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/clk/sunxi/clk-sunxi.c b/drivers/clk/sunxi/clk-sunxi.c
> index 67ef94948544..a3d706f5b21c 100644
> --- a/drivers/clk/sunxi/clk-sunxi.c
> +++ b/drivers/clk/sunxi/clk-sunxi.c
> @@ -616,7 +616,7 @@ static const struct mux_data sun8i_h3_ahb2_mux_data __initconst = {
> };
>
> static struct clk * __init sunxi_mux_clk_setup(struct device_node *node,
> - struct mux_data *data)
> + const struct mux_data *data)
> {
> struct clk *clk;
> const char *clk_name = node->name;
> @@ -700,7 +700,7 @@ static const struct div_data sun4i_apb0_data __initconst = {
> };
>
> static void __init sunxi_divider_clk_setup(struct device_node *node,
> - struct div_data *data)
> + const struct div_data *data)
> {
> struct clk *clk;
> const char *clk_name = node->name;
> @@ -810,7 +810,7 @@ static const struct divs_data sun6i_a31_pll6_divs_data __initconst = {
> */
>
> static struct clk ** __init sunxi_divs_clk_setup(struct device_node *node,
> - struct divs_data *data)
> + const struct divs_data *data)
> {
> struct clk_onecell_data *clk_data;
> const char *parent;
>
WARNING: multiple messages have this Message-ID (diff)
From: andre.przywara@arm.com (Andre Przywara)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/5] clk: sunxi: Make clocks setup functions take const pointer
Date: Tue, 2 Feb 2016 12:11:36 +0000 [thread overview]
Message-ID: <56B09CF8.2020801@arm.com> (raw)
In-Reply-To: <1454402834-6385-3-git-send-email-maxime.ripard@free-electrons.com>
On 02/02/16 08:47, Maxime Ripard wrote:
> All the data structure that we pass to the clocks setup functions are
> declared const, while our setup functions expects a regular pointer. This
> was hidden by the fact that we cast a void * pointer back to these
> structures, which made it go unnoticed.
>
> Fix the functions prototype.
>
> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Reviewed-by: Andre Przywara <andre.przywara@arm.com>
Cheers,
Andre.
> ---
> drivers/clk/sunxi/clk-sunxi.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/clk/sunxi/clk-sunxi.c b/drivers/clk/sunxi/clk-sunxi.c
> index 67ef94948544..a3d706f5b21c 100644
> --- a/drivers/clk/sunxi/clk-sunxi.c
> +++ b/drivers/clk/sunxi/clk-sunxi.c
> @@ -616,7 +616,7 @@ static const struct mux_data sun8i_h3_ahb2_mux_data __initconst = {
> };
>
> static struct clk * __init sunxi_mux_clk_setup(struct device_node *node,
> - struct mux_data *data)
> + const struct mux_data *data)
> {
> struct clk *clk;
> const char *clk_name = node->name;
> @@ -700,7 +700,7 @@ static const struct div_data sun4i_apb0_data __initconst = {
> };
>
> static void __init sunxi_divider_clk_setup(struct device_node *node,
> - struct div_data *data)
> + const struct div_data *data)
> {
> struct clk *clk;
> const char *clk_name = node->name;
> @@ -810,7 +810,7 @@ static const struct divs_data sun6i_a31_pll6_divs_data __initconst = {
> */
>
> static struct clk ** __init sunxi_divs_clk_setup(struct device_node *node,
> - struct divs_data *data)
> + const struct divs_data *data)
> {
> struct clk_onecell_data *clk_data;
> const char *parent;
>
next prev parent reply other threads:[~2016-02-02 12:11 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-02 8:47 [PATCH 0/5] clk: sunxi: Rework the clocks code to deal with orphans Maxime Ripard
2016-02-02 8:47 ` Maxime Ripard
2016-02-02 8:47 ` [PATCH 1/5] clk: sunxi: Make clocks setup functions return their clock Maxime Ripard
2016-02-02 8:47 ` Maxime Ripard
2016-02-02 10:35 ` Chen-Yu Tsai
2016-02-02 11:32 ` Andre Przywara
2016-02-02 11:32 ` Andre Przywara
2016-02-02 13:27 ` Maxime Ripard
2016-02-02 13:27 ` Maxime Ripard
2016-02-04 12:07 ` Maxime Ripard
2016-02-04 12:07 ` Maxime Ripard
2016-02-02 8:47 ` [PATCH 2/5] clk: sunxi: Make clocks setup functions take const pointer Maxime Ripard
2016-02-02 8:47 ` Maxime Ripard
2016-02-02 10:38 ` Chen-Yu Tsai
2016-02-02 12:11 ` Andre Przywara [this message]
2016-02-02 12:11 ` Andre Przywara
2016-02-04 12:08 ` Maxime Ripard
2016-02-04 12:08 ` Maxime Ripard
2016-02-02 8:47 ` [PATCH 3/5] clk: sunxi: convert current clocks registration to CLK_OF_DECLARE Maxime Ripard
2016-02-02 8:47 ` Maxime Ripard
2016-02-02 14:16 ` Andre Przywara
2016-02-02 14:16 ` Andre Przywara
2016-02-02 17:00 ` Maxime Ripard
2016-02-02 17:00 ` Maxime Ripard
2016-02-02 17:04 ` Andre Przywara
2016-02-02 17:04 ` Andre Przywara
2016-02-04 12:13 ` Maxime Ripard
2016-02-04 12:13 ` Maxime Ripard
2016-02-02 8:47 ` [PATCH 4/5] clk: sunxi: Remove old probe and protection code Maxime Ripard
2016-02-02 8:47 ` Maxime Ripard
2016-02-04 12:15 ` Maxime Ripard
2016-02-04 12:15 ` Maxime Ripard
2016-02-02 8:47 ` [PATCH 5/5] clk: sunxi: Remove clk_register_clkdev calls Maxime Ripard
2016-02-02 8:47 ` Maxime Ripard
2016-02-02 10:26 ` Jean-Francois Moine
2016-02-02 10:26 ` Jean-Francois Moine
2016-02-03 19:29 ` Maxime Ripard
2016-02-03 19:29 ` Maxime Ripard
2016-02-04 12:17 ` Maxime Ripard
2016-02-04 12:17 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56B09CF8.2020801@arm.com \
--to=andre.przywara@arm.com \
--cc=emilio@elopez.com.ar \
--cc=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=maxime.ripard@free-electrons.com \
--cc=mturquette@baylibre.com \
--cc=sboyd@codeaurora.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.