From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Colin Vidal <colin@cvidal.org>
Cc: "open list:STAGING SUBSYSTEM" <devel@driverdev.osuosl.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] Staging: fix coding style in rtl8188eu/core
Date: Thu, 11 Feb 2016 20:03:16 -0800 [thread overview]
Message-ID: <20160212040316.GA6947@kroah.com> (raw)
In-Reply-To: <1455138571-12956-1-git-send-email-colin@cvidal.org>
On Wed, Feb 10, 2016 at 10:09:28PM +0100, Colin Vidal wrote:
> Set constant operand on right of test, and refactor the code in a more
> compact and readable way.
Please don't do two different things in the same patch, break this up
into different patches.
thanks,
gregk -h
prev parent reply other threads:[~2016-02-12 4:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-10 21:09 [PATCH v2] Staging: fix coding style in rtl8188eu/core Colin Vidal
2016-02-12 4:03 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160212040316.GA6947@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=colin@cvidal.org \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.