* [PATCH v2] Staging: fix coding style in rtl8188eu/core
@ 2016-02-10 21:09 Colin Vidal
2016-02-12 4:03 ` Greg Kroah-Hartman
0 siblings, 1 reply; 2+ messages in thread
From: Colin Vidal @ 2016-02-10 21:09 UTC (permalink / raw)
To: Greg Kroah-Hartman, open list:STAGING SUBSYSTEM, open list; +Cc: Colin Vidal
Set constant operand on right of test, and refactor the code in a more
compact and readable way.
Signed-off-by: Colin Vidal <colin@cvidal.org>
---
drivers/staging/rtl8188eu/core/rtw_iol.c | 13 +++++--------
1 file changed, 5 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_iol.c b/drivers/staging/rtl8188eu/core/rtw_iol.c
index cdcf0ea..00e1136 100644
--- a/drivers/staging/rtl8188eu/core/rtw_iol.c
+++ b/drivers/staging/rtl8188eu/core/rtw_iol.c
@@ -18,14 +18,11 @@
*
******************************************************************************/
-#include<rtw_iol.h>
+#include <rtw_iol.h>
-bool rtw_IOL_applied(struct adapter *adapter)
+bool rtw_IOL_applied(struct adapter *adapter)
{
- if (1 == adapter->registrypriv.fw_iol)
- return true;
-
- if ((2 == adapter->registrypriv.fw_iol) && (!adapter_to_dvobj(adapter)->ishighspeed))
- return true;
- return false;
+ return adapter->registrypriv.fw_iol == 1 ||
+ (adapter->registrypriv.fw_iol == 2 &&
+ !adapter_to_dvobj(adapter)->ishighspeed);
}
--
2.5.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] Staging: fix coding style in rtl8188eu/core
2016-02-10 21:09 [PATCH v2] Staging: fix coding style in rtl8188eu/core Colin Vidal
@ 2016-02-12 4:03 ` Greg Kroah-Hartman
0 siblings, 0 replies; 2+ messages in thread
From: Greg Kroah-Hartman @ 2016-02-12 4:03 UTC (permalink / raw)
To: Colin Vidal; +Cc: open list:STAGING SUBSYSTEM, open list
On Wed, Feb 10, 2016 at 10:09:28PM +0100, Colin Vidal wrote:
> Set constant operand on right of test, and refactor the code in a more
> compact and readable way.
Please don't do two different things in the same patch, break this up
into different patches.
thanks,
gregk -h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-02-12 4:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-10 21:09 [PATCH v2] Staging: fix coding style in rtl8188eu/core Colin Vidal
2016-02-12 4:03 ` Greg Kroah-Hartman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.