[PATCH]Staging:tty:amiserial:Add space before open parenthesis and fix indent warning.

[PATCH]Staging:tty:amiserial:Add space before open parenthesis and fix indent warning.

[Sandhya]

Add space before open parenthesis of "if" statement and fix indent warning.
The checkpatch.pl script reported  error and warning.

diff --git a/drivers/tty/amiserial.c b/drivers/tty/amiserial.c
index 2caaf5a..9a5c584 100644
--- a/drivers/tty/amiserial.c
+++ b/drivers/tty/amiserial.c
@@ -262,10 +262,10 @@ static void receive_chars(struct serial_state *info)
 	custom.intreq = IF_RBF;
 	mb();
 
-	if((serdatr & 0x1ff) == 0)
-	    status |= UART_LSR_BI;
-	if(serdatr & SDR_OVRUN)
-	    status |= UART_LSR_OE;
+	if ((serdatr & 0x1ff) == 0)
+		status |= UART_LSR_BI;
+	if (serdatr & SDR_OVRUN)
+		status |= UART_LSR_OE;
 
 	ch = serdatr & 0xff;
 	icount->rx++;

Re: [Outreachy kernel] [PATCH]Staging:tty:amiserial:Add space before open parenthesis and fix indent warning.

[Greg KH]

On Fri, Feb 19, 2016 at 05:37:41PM +0530, Sandhya wrote:
> Add space before open parenthesis of "if" statement and fix indent warning.
> The checkpatch.pl script reported  error and warning.
> 
> diff --git a/drivers/tty/amiserial.c b/drivers/tty/amiserial.c
> index 2caaf5a..9a5c584 100644
> --- a/drivers/tty/amiserial.c
> +++ b/drivers/tty/amiserial.c
> @@ -262,10 +262,10 @@ static void receive_chars(struct serial_state *info)
>  	custom.intreq = IF_RBF;
>  	mb();
>  
> -	if((serdatr & 0x1ff) == 0)
> -	    status |= UART_LSR_BI;
> -	if(serdatr & SDR_OVRUN)
> -	    status |= UART_LSR_OE;
> +	if ((serdatr & 0x1ff) == 0)
> +		status |= UART_LSR_BI;
> +	if (serdatr & SDR_OVRUN)
> +		status |= UART_LSR_OE;
>  
>  	ch = serdatr & 0xff;
>  	icount->rx++;
> 

We can't accept Outreachy application patches outside of the
drivers/staging/ portion of the kernel, sorry.

Also you forgot a signed-off-by: line, please go read the tutorial again
for all of the proper steps needed to create a patch.

thanks,

greg k-h

Re: [Outreachy kernel] [PATCH]Staging:tty:amiserial:Add space before open parenthesis and fix indent warning.

[Julia Lawall]

You need a Signed-off-by line with your full name, and that should match
the From line of your patch, which here seems t contain only your first
name.

julia

On Fri, 19 Feb 2016, Sandhya wrote:

> Add space before open parenthesis of "if" statement and fix indent warning.
> The checkpatch.pl script reported  error and warning.
>
> diff --git a/drivers/tty/amiserial.c b/drivers/tty/amiserial.c
> index 2caaf5a..9a5c584 100644
> --- a/drivers/tty/amiserial.c
> +++ b/drivers/tty/amiserial.c
> @@ -262,10 +262,10 @@ static void receive_chars(struct serial_state *info)
>  	custom.intreq = IF_RBF;
>  	mb();
>
> -	if((serdatr & 0x1ff) == 0)
> -	    status |= UART_LSR_BI;
> -	if(serdatr & SDR_OVRUN)
> -	    status |= UART_LSR_OE;
> +	if ((serdatr & 0x1ff) == 0)
> +		status |= UART_LSR_BI;
> +	if (serdatr & SDR_OVRUN)
> +		status |= UART_LSR_OE;
>
>  	ch = serdatr & 0xff;
>  	icount->rx++;
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20160219120741.GA5755%40sandhya.
> For more options, visit https://groups.google.com/d/optout.
>