From: Al Viro <viro@ZenIV.linux.org.uk>
To: Tejun Heo <tj@kernel.org>
Cc: Jan Kara <jack@suse.cz>, Tahsin Erdogan <tahsin@google.com>,
Jens Axboe <axboe@kernel.dk>,
cgroups@vger.kernel.org, Theodore Ts'o <tytso@mit.edu>,
Nauman Rafique <nauman@google.com>,
linux-kernel@vger.kernel.org, Jan Kara <jack@suse.com>
Subject: Re: [PATCH block/for-4.5-fixes] writeback: keep superblock pinned during cgroup writeback association switches
Date: Fri, 19 Feb 2016 22:26:09 +0000 [thread overview]
Message-ID: <20160219222609.GC17997@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20160219221512.GO13177@mtj.duckdns.org>
On Fri, Feb 19, 2016 at 05:15:12PM -0500, Tejun Heo wrote:
> > IOW, while fs shutdown may be async, making it *always* async would be a bad
> > bug. And bumping ->s_active does just that.
> >
> > I'd go for trylock inside that work + making generic_shutdown_super()
> > kill all such works. I assume that it *can* be abandoned in situation
> > when we know that sync_filesystem() is about to be called and that
> > said sync_filesystem() won't, in turn, schedule any such works, of course...
>
> I'll make generic_shutdown_super() to kill all such work items. I
> don't think the work item itself would need further locking tho. Can
> you please elaborate why you thought adding trylock to the work would
> be necessary?
Umm... Not much, except that it would make the life cycle rules a bit
more regular.
Is that code OK with e.g. running in parallel with remounting filesystem r/o?
next prev parent reply other threads:[~2016-02-19 22:26 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-12 19:32 [BUG] cgroup writeback crash Tahsin Erdogan
[not found] ` <CAAeU0aNCq7LGODvVGRU-oU_o-6enii5ey0p1c26D1ZzYwkDc5A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-02-15 21:00 ` Tejun Heo
[not found] ` <20160215210047.GN3965-piEFEHQLUPpN0TnZuCh8vA@public.gmane.org>
2016-02-16 7:56 ` Tahsin Erdogan
[not found] ` <CAAeU0aNAd1Ra6LXmWwq8row4MD_BpVHiSXOwHx07m86UWREvHw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-02-16 18:24 ` [PATCH block/for-4.5-fixes] writeback: keep superblock pinned during cgroup writeback association switches Tejun Heo
2016-02-16 18:24 ` Tejun Heo
[not found] ` <20160216182457.GO3741-qYNAdHglDFBN0TnZuCh8vA@public.gmane.org>
2016-02-16 18:34 ` Jens Axboe
2016-02-16 18:34 ` Jens Axboe
2016-02-17 20:57 ` Jan Kara
2016-02-17 20:57 ` Jan Kara
[not found] ` <20160217205721.GE14140-+0h/O2h83AeN3ZZ/Hiejyg@public.gmane.org>
2016-02-17 21:07 ` Tejun Heo
2016-02-17 21:07 ` Tejun Heo
2016-02-17 22:30 ` Jan Kara
2016-02-17 22:41 ` Tahsin Erdogan
[not found] ` <CAAeU0aOvSwPbLPU0=20D1RExNj8VsbB38hUnyso2L8xNSQC0XA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-02-17 23:02 ` Tejun Heo
2016-02-17 23:02 ` Tejun Heo
2016-02-18 9:55 ` Jan Kara
[not found] ` <20160218095538.GA4338-+0h/O2h83AeN3ZZ/Hiejyg@public.gmane.org>
2016-02-18 13:00 ` Tejun Heo
2016-02-18 13:00 ` Tejun Heo
2016-02-18 13:20 ` Jan Kara
2016-02-19 20:18 ` Al Viro
2016-02-19 20:51 ` Tejun Heo
[not found] ` <20160219205147.GN13177-qYNAdHglDFBN0TnZuCh8vA@public.gmane.org>
2016-02-19 21:58 ` Al Viro
2016-02-19 21:58 ` Al Viro
[not found] ` <20160219215811.GA17997-3bDd1+5oDREiFSDQTTA3OLVCufUGDwFn@public.gmane.org>
2016-02-19 22:15 ` Tejun Heo
2016-02-19 22:15 ` Tejun Heo
2016-02-19 22:26 ` Al Viro [this message]
[not found] ` <20160219222609.GC17997-3bDd1+5oDREiFSDQTTA3OLVCufUGDwFn@public.gmane.org>
2016-02-28 21:53 ` Tejun Heo
2016-02-28 21:53 ` Tejun Heo
[not found] ` <20160217230231.GC6479-qYNAdHglDFBN0TnZuCh8vA@public.gmane.org>
2016-02-29 20:47 ` [PATCH block/for-linus] writeback: flush inode cgroup wb switches instead of pinning super_block Tejun Heo
2016-02-29 20:47 ` Tejun Heo
[not found] ` <20160229204724.GV3965-piEFEHQLUPpN0TnZuCh8vA@public.gmane.org>
2016-02-29 20:54 ` Al Viro
2016-02-29 20:54 ` Al Viro
[not found] ` <20160229205428.GB17997-3bDd1+5oDREiFSDQTTA3OLVCufUGDwFn@public.gmane.org>
2016-02-29 20:58 ` Tejun Heo
2016-02-29 20:58 ` Tejun Heo
[not found] ` <20160229205837.GX3965-piEFEHQLUPpN0TnZuCh8vA@public.gmane.org>
2016-02-29 21:06 ` Al Viro
2016-02-29 21:06 ` Al Viro
[not found] ` <20160229210614.GC17997-3bDd1+5oDREiFSDQTTA3OLVCufUGDwFn@public.gmane.org>
2016-02-29 21:08 ` Tejun Heo
2016-02-29 21:08 ` Tejun Heo
[not found] ` <20160229210800.GY3965-piEFEHQLUPpN0TnZuCh8vA@public.gmane.org>
2016-02-29 21:21 ` Jan Kara
2016-02-29 21:21 ` Jan Kara
2016-02-29 23:28 ` [PATCH v2 " Tejun Heo
2016-02-29 23:28 ` Tejun Heo
2016-03-01 9:20 ` Jan Kara
2016-03-01 17:46 ` Jens Axboe
[not found] ` <56D5D592.2020800-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org>
2016-03-01 17:50 ` Tejun Heo
2016-03-01 17:50 ` Tejun Heo
[not found] ` <CAOS58YO5vTBnM561np7gpXKGQELrT169bYqmcfvAvsquBJK5yw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-03-02 10:29 ` Jan Kara
2016-03-02 10:29 ` Jan Kara
2016-03-01 13:39 ` [PATCH " Tahsin Erdogan
2016-02-18 10:12 ` [PATCH block/for-4.5-fixes] writeback: keep superblock pinned during cgroup writeback association switches Nikolay Borisov
2016-02-18 10:12 ` Nikolay Borisov
2016-02-18 12:57 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160219222609.GC17997@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=jack@suse.com \
--cc=jack@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=nauman@google.com \
--cc=tahsin@google.com \
--cc=tj@kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.