All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
Cc: Peter Huewe <peterhuewe@gmx.de>,
	tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [tpmdd-devel] [PATCH] tpm_crb: fix bad name pointer usage with struct resource
Date: Sat, 20 Feb 2016 10:04:22 +0200	[thread overview]
Message-ID: <20160220080422.GA6833@intel.com> (raw)
In-Reply-To: <20160219174434.GA15013@obsidianresearch.com>

On Fri, Feb 19, 2016 at 10:44:34AM -0700, Jason Gunthorpe wrote:
> On Fri, Feb 19, 2016 at 05:06:06PM +0200, Jarkko Sakkinen wrote:
> 
> > Can you quickly check the two top-most patches:
> > 
> > https://github.com/jsakkine/linux-tpmdd/commits/master
> 
> Drop the change to crb_map_res, the memset is not needed.

Left-over from when I tried to catch the issue. Removed.

> The shutdown change is probably OK for a rc fix, but it is still wrong.
> The shutdown has to be done inside the code after the core has removed
> all access to the tpm but before it has torn down so much that the
> driver doesn't work anymore.

I made the modifications you asked and run my smoke tests. Can I apply
your Reviewed-by's?

> Jason

/Jarkko

      reply	other threads:[~2016-02-20  8:04 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-17  0:27 [PATCH] tpm_crb: fix bad name pointer usage with struct resource Jarkko Sakkinen
2016-02-17  0:27 ` Jarkko Sakkinen
     [not found] ` <1455668874-13261-1-git-send-email-jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2016-02-17  4:52   ` Jason Gunthorpe
2016-02-17  4:52     ` [tpmdd-devel] " Jason Gunthorpe
     [not found]     ` <20160217045219.GA26086-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-02-17  9:36       ` Jarkko Sakkinen
2016-02-17  9:36         ` [tpmdd-devel] " Jarkko Sakkinen
     [not found]         ` <20160217093623.GA9831-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-02-17 14:20           ` Jarkko Sakkinen
2016-02-17 14:20             ` [tpmdd-devel] " Jarkko Sakkinen
     [not found]             ` <20160217142016.GA6951-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-02-18 17:31               ` Jason Gunthorpe
2016-02-18 17:31                 ` [tpmdd-devel] " Jason Gunthorpe
2016-02-19 15:06                 ` Jarkko Sakkinen
     [not found]                   ` <20160219150606.GB7474-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-02-19 17:44                     ` Jason Gunthorpe
2016-02-19 17:44                       ` [tpmdd-devel] " Jason Gunthorpe
2016-02-20  8:04                       ` Jarkko Sakkinen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160220080422.GA6833@intel.com \
    --to=jarkko.sakkinen@linux.intel.com \
    --cc=jgunthorpe@obsidianresearch.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterhuewe@gmx.de \
    --cc=tpmdd-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.