From: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
To: Jarkko Sakkinen
<jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
Cc: tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] tpm_crb: fix bad name pointer usage with struct resource
Date: Thu, 18 Feb 2016 10:31:40 -0700 [thread overview]
Message-ID: <20160218173140.GA5899@obsidianresearch.com> (raw)
In-Reply-To: <20160217142016.GA6951-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
On Wed, Feb 17, 2016 at 04:20:16PM +0200, Jarkko Sakkinen wrote:
> Maybe for the release the safest bet would be anyway explicitly not
> use the name field? That's the safest bet given the release time
> frame.
nulling it in the acpi paths of tis and crb, if you know those are broken
seems good for a rc.
I haven't looked at what other options there are, I suspect it needs
strdup due to how the drivers are working with acpi..
Jason
------------------------------------------------------------------------------
Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
Monitor end-to-end web transactions and take corrective actions now
Troubleshoot faster and improve end-user experience. Signup Now!
http://pubads.g.doubleclick.net/gampad/clk?id=272487151&iu=/4140
WARNING: multiple messages have this Message-ID (diff)
From: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
To: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Cc: Peter Huewe <peterhuewe@gmx.de>,
tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [tpmdd-devel] [PATCH] tpm_crb: fix bad name pointer usage with struct resource
Date: Thu, 18 Feb 2016 10:31:40 -0700 [thread overview]
Message-ID: <20160218173140.GA5899@obsidianresearch.com> (raw)
In-Reply-To: <20160217142016.GA6951@intel.com>
On Wed, Feb 17, 2016 at 04:20:16PM +0200, Jarkko Sakkinen wrote:
> Maybe for the release the safest bet would be anyway explicitly not
> use the name field? That's the safest bet given the release time
> frame.
nulling it in the acpi paths of tis and crb, if you know those are broken
seems good for a rc.
I haven't looked at what other options there are, I suspect it needs
strdup due to how the drivers are working with acpi..
Jason
next prev parent reply other threads:[~2016-02-18 17:31 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-17 0:27 [PATCH] tpm_crb: fix bad name pointer usage with struct resource Jarkko Sakkinen
2016-02-17 0:27 ` Jarkko Sakkinen
[not found] ` <1455668874-13261-1-git-send-email-jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2016-02-17 4:52 ` Jason Gunthorpe
2016-02-17 4:52 ` [tpmdd-devel] " Jason Gunthorpe
[not found] ` <20160217045219.GA26086-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-02-17 9:36 ` Jarkko Sakkinen
2016-02-17 9:36 ` [tpmdd-devel] " Jarkko Sakkinen
[not found] ` <20160217093623.GA9831-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-02-17 14:20 ` Jarkko Sakkinen
2016-02-17 14:20 ` [tpmdd-devel] " Jarkko Sakkinen
[not found] ` <20160217142016.GA6951-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-02-18 17:31 ` Jason Gunthorpe [this message]
2016-02-18 17:31 ` Jason Gunthorpe
2016-02-19 15:06 ` Jarkko Sakkinen
[not found] ` <20160219150606.GB7474-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-02-19 17:44 ` Jason Gunthorpe
2016-02-19 17:44 ` [tpmdd-devel] " Jason Gunthorpe
2016-02-20 8:04 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160218173140.GA5899@obsidianresearch.com \
--to=jgunthorpe-epgobjl8dl3ta4ec/59zmfatqe2ktcn/@public.gmane.org \
--cc=jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.