[PATCH v3] Staging: wlan-ng: Convert explicit comparison to NULL to !x.

[PATCH v3] Staging: wlan-ng: Convert explicit comparison to NULL to !x.

[Sandhya Bankar]

Convert explicit comparison to NULL to !x.

Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
---
Changes in v3:
*In v2,missed to add comment below --- so adding comment  
*Adding Full name in signed-off-by line.

 drivers/staging/wlan-ng/p80211conv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/wlan-ng/p80211conv.c b/drivers/staging/wlan-ng/p80211conv.c
index 1b02cdf..86fd23f 100644
--- a/drivers/staging/wlan-ng/p80211conv.c
+++ b/drivers/staging/wlan-ng/p80211conv.c
@@ -613,7 +613,7 @@ int p80211skb_rxmeta_attach(struct wlandevice *wlandev, struct sk_buff *skb)
 	/* Allocate the rxmeta */
 	rxmeta = kzalloc(sizeof(struct p80211_rxmeta), GFP_ATOMIC);
 
-	if (rxmeta == NULL) {
+	if (!rxmeta) {
 		netdev_err(wlandev->netdev,
 			   "%s: Failed to allocate rxmeta.\n", wlandev->name);
 		result = 1;
-- 
1.8.3.4

[PATCH v3] Staging: wlan-ng: Convert explicit comparison to NULL to !x.

[Sandhya Bankar]

Convert explicit comparison to NULL to !x.

Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
---
Changes in v3:
*In v2,missed to add comment below --- so adding comment  
*Adding Full name in signed-off-by line.

 drivers/staging/wlan-ng/cfg80211.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/wlan-ng/cfg80211.c b/drivers/staging/wlan-ng/cfg80211.c
index 8c1e3f0..c59dd33 100644
--- a/drivers/staging/wlan-ng/cfg80211.c
+++ b/drivers/staging/wlan-ng/cfg80211.c
@@ -303,7 +303,7 @@ static int prism2_get_station(struct wiphy *wiphy, struct net_device *dev,
 
 	memset(sinfo, 0, sizeof(*sinfo));
 
-	if ((wlandev == NULL) || (wlandev->msdstate != WLAN_MSD_RUNNING))
+	if (!wlandev || (wlandev->msdstate != WLAN_MSD_RUNNING))
 		return -EOPNOTSUPP;
 
 	/* build request message */
@@ -312,7 +312,7 @@ static int prism2_get_station(struct wiphy *wiphy, struct net_device *dev,
 	quality.dbm.status = P80211ENUM_msgitem_status_data_ok;
 
 	/* send message to nsd */
-	if (wlandev->mlmerequest == NULL)
+	if (!wlandev->mlmerequest)
 		return -EOPNOTSUPP;
 
 	result = wlandev->mlmerequest(wlandev, (struct p80211msg *) &quality);
-- 
1.8.3.4

Re: [Outreachy kernel] [PATCH v3] Staging: wlan-ng: Convert explicit comparison to NULL to !x.

[Julia Lawall]

On Sat, 20 Feb 2016, Sandhya Bankar wrote:

> Convert explicit comparison to NULL to !x.
>
> Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>

Everything looks fine now, but the change was already made in the
following commit:

d23054350d0fafdc4a6f8d68b18cd70ec581c95d

Maybe you need to update your kernel.

julia

> ---
> Changes in v3:
> *In v2,missed to add comment below --- so adding comment
> *Adding Full name in signed-off-by line.
>
>  drivers/staging/wlan-ng/p80211conv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/wlan-ng/p80211conv.c b/drivers/staging/wlan-ng/p80211conv.c
> index 1b02cdf..86fd23f 100644
> --- a/drivers/staging/wlan-ng/p80211conv.c
> +++ b/drivers/staging/wlan-ng/p80211conv.c
> @@ -613,7 +613,7 @@ int p80211skb_rxmeta_attach(struct wlandevice *wlandev, struct sk_buff *skb)
>  	/* Allocate the rxmeta */
>  	rxmeta = kzalloc(sizeof(struct p80211_rxmeta), GFP_ATOMIC);
>
> -	if (rxmeta == NULL) {
> +	if (!rxmeta) {
>  		netdev_err(wlandev->netdev,
>  			   "%s: Failed to allocate rxmeta.\n", wlandev->name);
>  		result = 1;
> --
> 1.8.3.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20160220115438.GA3260%40sandhya.
> For more options, visit https://groups.google.com/d/optout.
>

Re: [Outreachy kernel] [PATCH v3] Staging: wlan-ng: Convert explicit comparison to NULL to !x.

[Greg KH]

On Sat, Feb 20, 2016 at 05:24:38PM +0530, Sandhya Bankar wrote:
> Convert explicit comparison to NULL to !x.
> 
> Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
> ---
> Changes in v3:
> *In v2,missed to add comment below --- so adding comment  
> *Adding Full name in signed-off-by line.
> 

You sent 2 patches with the identical subject: line, yet they did
different things.  I can't accept that, please make them unique.

thanks,

greg k-h