* [PATCH v3] Staging: wlan-ng: Convert explicit comparison to NULL to !x.
@ 2016-02-20 11:54 Sandhya Bankar
2016-02-20 20:00 ` [Outreachy kernel] " Julia Lawall
2016-02-20 22:52 ` Greg KH
0 siblings, 2 replies; 3+ messages in thread
From: Sandhya Bankar @ 2016-02-20 11:54 UTC (permalink / raw)
To: outreachy-kernel
Convert explicit comparison to NULL to !x.
Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
---
Changes in v3:
*In v2,missed to add comment below --- so adding comment
*Adding Full name in signed-off-by line.
drivers/staging/wlan-ng/p80211conv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wlan-ng/p80211conv.c b/drivers/staging/wlan-ng/p80211conv.c
index 1b02cdf..86fd23f 100644
--- a/drivers/staging/wlan-ng/p80211conv.c
+++ b/drivers/staging/wlan-ng/p80211conv.c
@@ -613,7 +613,7 @@ int p80211skb_rxmeta_attach(struct wlandevice *wlandev, struct sk_buff *skb)
/* Allocate the rxmeta */
rxmeta = kzalloc(sizeof(struct p80211_rxmeta), GFP_ATOMIC);
- if (rxmeta == NULL) {
+ if (!rxmeta) {
netdev_err(wlandev->netdev,
"%s: Failed to allocate rxmeta.\n", wlandev->name);
result = 1;
--
1.8.3.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Outreachy kernel] [PATCH v3] Staging: wlan-ng: Convert explicit comparison to NULL to !x.
2016-02-20 11:54 [PATCH v3] Staging: wlan-ng: Convert explicit comparison to NULL to !x Sandhya Bankar
@ 2016-02-20 20:00 ` Julia Lawall
2016-02-20 22:52 ` Greg KH
1 sibling, 0 replies; 3+ messages in thread
From: Julia Lawall @ 2016-02-20 20:00 UTC (permalink / raw)
To: Sandhya Bankar; +Cc: outreachy-kernel
On Sat, 20 Feb 2016, Sandhya Bankar wrote:
> Convert explicit comparison to NULL to !x.
>
> Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
Everything looks fine now, but the change was already made in the
following commit:
d23054350d0fafdc4a6f8d68b18cd70ec581c95d
Maybe you need to update your kernel.
julia
> ---
> Changes in v3:
> *In v2,missed to add comment below --- so adding comment
> *Adding Full name in signed-off-by line.
>
> drivers/staging/wlan-ng/p80211conv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/wlan-ng/p80211conv.c b/drivers/staging/wlan-ng/p80211conv.c
> index 1b02cdf..86fd23f 100644
> --- a/drivers/staging/wlan-ng/p80211conv.c
> +++ b/drivers/staging/wlan-ng/p80211conv.c
> @@ -613,7 +613,7 @@ int p80211skb_rxmeta_attach(struct wlandevice *wlandev, struct sk_buff *skb)
> /* Allocate the rxmeta */
> rxmeta = kzalloc(sizeof(struct p80211_rxmeta), GFP_ATOMIC);
>
> - if (rxmeta == NULL) {
> + if (!rxmeta) {
> netdev_err(wlandev->netdev,
> "%s: Failed to allocate rxmeta.\n", wlandev->name);
> result = 1;
> --
> 1.8.3.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20160220115438.GA3260%40sandhya.
> For more options, visit https://groups.google.com/d/optout.
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Outreachy kernel] [PATCH v3] Staging: wlan-ng: Convert explicit comparison to NULL to !x.
2016-02-20 11:54 [PATCH v3] Staging: wlan-ng: Convert explicit comparison to NULL to !x Sandhya Bankar
2016-02-20 20:00 ` [Outreachy kernel] " Julia Lawall
@ 2016-02-20 22:52 ` Greg KH
1 sibling, 0 replies; 3+ messages in thread
From: Greg KH @ 2016-02-20 22:52 UTC (permalink / raw)
To: Sandhya Bankar; +Cc: outreachy-kernel
On Sat, Feb 20, 2016 at 05:24:38PM +0530, Sandhya Bankar wrote:
> Convert explicit comparison to NULL to !x.
>
> Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
> ---
> Changes in v3:
> *In v2,missed to add comment below --- so adding comment
> *Adding Full name in signed-off-by line.
>
You sent 2 patches with the identical subject: line, yet they did
different things. I can't accept that, please make them unique.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-02-20 22:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-20 11:54 [PATCH v3] Staging: wlan-ng: Convert explicit comparison to NULL to !x Sandhya Bankar
2016-02-20 20:00 ` [Outreachy kernel] " Julia Lawall
2016-02-20 22:52 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.