From: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
To: Jeff Moyer <jmoyer-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>,
viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn@public.gmane.org,
axboe-b10kYP2dOMg@public.gmane.org,
milosz-B5zB6C1i6pkAvxtiuMwx3w@public.gmane.org,
linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 6/7] blk-mq: enable polling support by default
Date: Sat, 27 Feb 2016 09:56:48 +0100 [thread overview]
Message-ID: <20160227085648.GA4255@lst.de> (raw)
In-Reply-To: <x49fuwfmcb5.fsf-RRHT56Q3PSP4kTEheFKJxxDDeQx5vsVwAInAS/Ez/D0@public.gmane.org>
On Fri, Feb 26, 2016 at 03:44:30PM -0500, Jeff Moyer wrote:
> Hi, Christoph,
>
> Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org> writes:
>
> > Now that applications need to explicitly ask for polling we can enable it
> > by default in blk-mq drivers.
>
> I don't think this is a good idea. I'd just enable it in nvme and the
> micron driver for now.
I think my wording was a bit unclear - the flag to enable polling is
enabled everywhere. You still need to implement the poll blk_mq operation,
which currently only NVMe implements.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Jeff Moyer <jmoyer@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>,
viro@zeniv.linux.org.uk, axboe@fb.com, milosz@adfin.com,
linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org,
linux-api@vger.kernel.org
Subject: Re: [PATCH 6/7] blk-mq: enable polling support by default
Date: Sat, 27 Feb 2016 09:56:48 +0100 [thread overview]
Message-ID: <20160227085648.GA4255@lst.de> (raw)
In-Reply-To: <x49fuwfmcb5.fsf@segfault.boston.devel.redhat.com>
On Fri, Feb 26, 2016 at 03:44:30PM -0500, Jeff Moyer wrote:
> Hi, Christoph,
>
> Christoph Hellwig <hch@lst.de> writes:
>
> > Now that applications need to explicitly ask for polling we can enable it
> > by default in blk-mq drivers.
>
> I don't think this is a good idea. I'd just enable it in nvme and the
> micron driver for now.
I think my wording was a bit unclear - the flag to enable polling is
enabled everywhere. You still need to implement the poll blk_mq operation,
which currently only NVMe implements.
next prev parent reply other threads:[~2016-02-27 8:56 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-22 17:07 selective block polling and preadv2/pwritev2 revisited V2 Christoph Hellwig
2016-02-22 17:07 ` [PATCH 1/7] vfs: pass a flags argument to vfs_readv/vfs_writev Christoph Hellwig
[not found] ` <1456160876-14560-2-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
2016-02-26 21:52 ` Jeff Moyer
2016-02-26 21:52 ` Jeff Moyer
[not found] ` <1456160876-14560-1-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
2016-02-22 17:07 ` [PATCH 2/7] vfs: vfs: Define new syscalls preadv2,pwritev2 Christoph Hellwig
2016-02-22 17:07 ` Christoph Hellwig
[not found] ` <1456160876-14560-3-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
2016-02-26 21:51 ` Jeff Moyer
2016-02-26 21:51 ` Jeff Moyer
2016-02-27 8:58 ` Christoph Hellwig
2016-02-22 17:07 ` [PATCH 3/7] x86: wire up preadv2 and pwritev2 Christoph Hellwig
2016-02-22 17:07 ` Christoph Hellwig
2016-02-22 17:07 ` [PATCH 4/7] vfs: add the RWF_HIPRI flag for preadv2/pwritev2 Christoph Hellwig
2016-02-22 17:07 ` Christoph Hellwig
[not found] ` <1456160876-14560-5-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
2016-02-26 21:56 ` Jeff Moyer
2016-02-26 21:56 ` Jeff Moyer
2016-02-27 8:58 ` Christoph Hellwig
2016-02-22 17:07 ` [PATCH 6/7] blk-mq: enable polling support by default Christoph Hellwig
2016-02-22 17:07 ` Christoph Hellwig
[not found] ` <1456160876-14560-7-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
2016-02-26 20:44 ` Jeff Moyer
2016-02-26 20:44 ` Jeff Moyer
[not found] ` <x49fuwfmcb5.fsf-RRHT56Q3PSP4kTEheFKJxxDDeQx5vsVwAInAS/Ez/D0@public.gmane.org>
2016-02-27 8:56 ` Christoph Hellwig [this message]
2016-02-27 8:56 ` Christoph Hellwig
2016-02-29 14:27 ` Jeff Moyer
2016-02-22 17:07 ` [PATCH 7/7] block, directio: set a REQ_POLL flag when submitting polled bios Christoph Hellwig
2016-02-22 17:07 ` Christoph Hellwig
[not found] ` <1456160876-14560-8-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
2016-02-26 21:10 ` Jeff Moyer
2016-02-26 21:10 ` Jeff Moyer
2016-02-27 8:57 ` Christoph Hellwig
2016-02-29 14:28 ` Jeff Moyer
2016-02-26 21:18 ` selective block polling and preadv2/pwritev2 revisited V2 Jeff Moyer
2016-02-26 21:18 ` Jeff Moyer
2016-02-27 8:57 ` Christoph Hellwig
[not found] ` <20160227085744.GC4255-jcswGhMUV9g@public.gmane.org>
2016-02-29 1:30 ` Damien Le Moal
2016-02-29 1:30 ` Damien Le Moal
2016-02-29 14:59 ` Jeff Moyer
2016-02-22 17:07 ` [PATCH 5/7] direct-io: only use block polling if explicitly requested Christoph Hellwig
[not found] ` <1456160876-14560-6-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
2016-02-26 21:58 ` Jeff Moyer
2016-02-26 21:58 ` Jeff Moyer
2016-02-26 15:06 ` selective block polling and preadv2/pwritev2 revisited V2 Stephen Bates
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160227085648.GA4255@lst.de \
--to=hch-jcswghmuv9g@public.gmane.org \
--cc=axboe-b10kYP2dOMg@public.gmane.org \
--cc=jmoyer-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=milosz-B5zB6C1i6pkAvxtiuMwx3w@public.gmane.org \
--cc=viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.