Re: [rtc-linux] rv3029 EEPROM handling

[Alexandre Belloni <alexandre.belloni@free-electrons.com>]

On 28/02/2016 at 12:58:52 +0100, Michael B=C3=BCsch wrote :
> On Sun, 28 Feb 2016 11:41:10 +0100
> Alexandre Belloni <alexandre.belloni@free-electrons.com> wrote:
>=20
> > ds1339, ds1390 and bq32k are using trickle-resistor-ohms and
> > trickle-diode-disable.
>=20
>=20
> The rv3029 datasheet doesn't say anything about a diode (I think it
> still has one though). It merely talks about resistors connected
> between vdd and the battery pin.
> So I'm not sure whether we should use the 'trickle-diode-disable'
> property here. One other possibility would be to use
> trickle-resistor-ohms=3D-1 or such to disable the charger.
>=20

More simply, don't enable the trickle charger if the
trickle-resistor-ohms property is missing.

Leave out the trickle-diode-disable property

>=20
> > > The rv3029 does the compensation internally. It just needs to be
> > > enabled via a bit in its EEPROM. We could probably always set that bi=
t
> > > though. I'm not sure whether there is a case where one would not want
> > > that.
> > >  =20
> >=20
> > If you want to enable it without changing the values, just enable it
> > unconditionally.
>=20
>=20
> I think the internal temperature compensation should be enabled by
> default and be disabled via DT property ('temp-compensation-disable'
> or such).
>=20

That part is not HW related, it should not be in the device tree. I'd
really just enable the temperature compensation else, this has to be
done in sysfs



--=20
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

--=20
--=20
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---=20
You received this message because you are subscribed to the Google Groups "=
rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an e=
mail to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.