From: "Michael Büsch" <m@bues.ch>
To: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Cc: Gregory Hermant <gregory.hermant@calao-systems.com>,
rtc-linux@googlegroups.com
Subject: Re: [rtc-linux] rv3029 EEPROM handling
Date: Mon, 29 Feb 2016 18:07:49 +0100 [thread overview]
Message-ID: <20160229180749.42f75ec8@wiggum> (raw)
In-Reply-To: <20160228213920.GA2260@piout.net>
[-- Attachment #1: Type: text/plain, Size: 1654 bytes --]
On Sun, 28 Feb 2016 22:39:20 +0100
Alexandre Belloni <alexandre.belloni@free-electrons.com> wrote:
> > The rv3029 has a clkout pin that can be configured to various
> > frequencies. So I added a 'clkout-hz' property for this.
> >
>
> No, you have to use the CCF for that.
Oh, yes. That makes sense.
> I had a really quick look, I'll review when you post patches. Please
> separate each functionality when submitting and use checkpatch.pl --strict
Yes, of course. Thanks for the hint. I'm not submitting stuff for the
first time, though. :)
> Also, to export the temperature, use hwmon, see:
> http://git.kernel.org/cgit/linux/kernel/git/abelloni/linux.git/commit/?h=rtc-next&id=445c02076f1e60d2ee51503bf1288ef9f3bc8809
That is a rather weird API.
Is there a special naming scheme required for the attribute?
What does the 'input' mean in 'temp1_input'? And why is it temp1
instead of temp0?
> You may want to use regmap instead of defining your own update_bits
> (rv3029c2_i2c_maskset_reg) but that is a more invasie change that you
> may leave out for now.
Ok, I will do this last.
Don't hold your breath. :)
--
Michael
--
--
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-02-29 17:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-27 14:39 [rtc-linux] rv3029 EEPROM handling Michael Büsch
2016-02-28 0:31 ` Alexandre Belloni
2016-02-28 8:44 ` Michael Büsch
2016-02-28 10:41 ` Alexandre Belloni
2016-02-28 11:58 ` Michael Büsch
2016-02-28 12:36 ` Alexandre Belloni
2016-02-28 17:14 ` Michael Büsch
2016-02-28 21:39 ` Alexandre Belloni
2016-02-29 17:07 ` Michael Büsch [this message]
2016-02-29 19:52 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160229180749.42f75ec8@wiggum \
--to=m@bues.ch \
--cc=alexandre.belloni@free-electrons.com \
--cc=gregory.hermant@calao-systems.com \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.