From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: "Michael Büsch" <m@bues.ch>
Cc: Gregory Hermant <gregory.hermant@calao-systems.com>,
rtc-linux@googlegroups.com
Subject: Re: [rtc-linux] rv3029 EEPROM handling
Date: Sun, 28 Feb 2016 22:39:20 +0100 [thread overview]
Message-ID: <20160228213920.GA2260@piout.net> (raw)
In-Reply-To: <20160228181450.3ba14f7f@wiggum>
On 28/02/2016 at 18:14:50 +0100, Michael B=C3=BCsch wrote :
> On Sun, 28 Feb 2016 13:36:18 +0100
> Alexandre Belloni <alexandre.belloni@free-electrons.com> wrote:
>=20
> > More simply, don't enable the trickle charger if the
> > trickle-resistor-ohms property is missing.
> >=20
> > Leave out the trickle-diode-disable property
>=20
> D'oh indeed. :)
>=20
> The rv3029 has a clkout pin that can be configured to various
> frequencies. So I added a 'clkout-hz' property for this.
>=20
No, you have to use the CCF for that. For a recent example, see:
http://git.kernel.org/cgit/linux/kernel/git/abelloni/linux.git/commit/?h=3D=
rtc-next&id=3D578bb1d82bdd7fb86d5988fb775c871521a2761f
> > That part is not HW related, it should not be in the device tree. I'd
> > really just enable the temperature compensation else, this has to be
> > done in sysfs
>=20
> Ok.
>=20
> Just for the record:
> I started an initial implementation of this here in the rv3029 branch:
> git://git.bues.ch/linux.git
> http://bues.ch/gitweb?p=3Dlinux.git;a=3Dshortlog;h=3Drefs/heads/rv3029
I had a really quick look, I'll review when you post patches. Please
separate each functionality when submitting and use checkpatch.pl --strict
Also, to export the temperature, use hwmon, see:
http://git.kernel.org/cgit/linux/kernel/git/abelloni/linux.git/commit/?h=3D=
rtc-next&id=3D445c02076f1e60d2ee51503bf1288ef9f3bc8809
You may want to use regmap instead of defining your own update_bits
(rv3029c2_i2c_maskset_reg) but that is a more invasie change that you
may leave out for now.
--=20
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--=20
--=20
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---=20
You received this message because you are subscribed to the Google Groups "=
rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an e=
mail to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
next prev parent reply other threads:[~2016-02-28 21:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-27 14:39 [rtc-linux] rv3029 EEPROM handling Michael Büsch
2016-02-28 0:31 ` Alexandre Belloni
2016-02-28 8:44 ` Michael Büsch
2016-02-28 10:41 ` Alexandre Belloni
2016-02-28 11:58 ` Michael Büsch
2016-02-28 12:36 ` Alexandre Belloni
2016-02-28 17:14 ` Michael Büsch
2016-02-28 21:39 ` Alexandre Belloni [this message]
2016-02-29 17:07 ` Michael Büsch
2016-02-29 19:52 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160228213920.GA2260@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=gregory.hermant@calao-systems.com \
--cc=m@bues.ch \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.