* [patch] dma/mic_x100_dma: IS_ERR() vs PTR_ERR() typo
@ 2016-02-29 9:51 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2016-02-29 9:51 UTC (permalink / raw)
To: Sudeep Dutt
Cc: Ashutosh Dixit, Vinod Koul, Dan Williams, dmaengine, linux-kernel,
kernel-janitors
This is harmless because the caller only cares about zero vs non-zero
but we should be returning PTR_ERR() here.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/dma/mic_x100_dma.c b/drivers/dma/mic_x100_dma.c
index 068e920..1502b24 100644
--- a/drivers/dma/mic_x100_dma.c
+++ b/drivers/dma/mic_x100_dma.c
@@ -483,7 +483,7 @@ static int mic_dma_setup_irq(struct mic_dma_chan *ch)
mic_dma_intr_handler, mic_dma_thread_fn,
"mic dma_channel", ch, ch->ch_num);
if (IS_ERR(ch->cookie))
- return IS_ERR(ch->cookie);
+ return PTR_ERR(ch->cookie);
return 0;
}
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [patch] dma/mic_x100_dma: IS_ERR() vs PTR_ERR() typo
@ 2016-02-29 9:51 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2016-02-29 9:51 UTC (permalink / raw)
To: Sudeep Dutt
Cc: Ashutosh Dixit, Vinod Koul, Dan Williams, dmaengine, linux-kernel,
kernel-janitors
This is harmless because the caller only cares about zero vs non-zero
but we should be returning PTR_ERR() here.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/dma/mic_x100_dma.c b/drivers/dma/mic_x100_dma.c
index 068e920..1502b24 100644
--- a/drivers/dma/mic_x100_dma.c
+++ b/drivers/dma/mic_x100_dma.c
@@ -483,7 +483,7 @@ static int mic_dma_setup_irq(struct mic_dma_chan *ch)
mic_dma_intr_handler, mic_dma_thread_fn,
"mic dma_channel", ch, ch->ch_num);
if (IS_ERR(ch->cookie))
- return IS_ERR(ch->cookie);
+ return PTR_ERR(ch->cookie);
return 0;
}
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [patch] dma/mic_x100_dma: IS_ERR() vs PTR_ERR() typo
2016-02-29 9:51 ` Dan Carpenter
@ 2016-03-03 15:55 ` Vinod Koul
-1 siblings, 0 replies; 4+ messages in thread
From: Vinod Koul @ 2016-03-03 15:43 UTC (permalink / raw)
To: Dan Carpenter
Cc: Sudeep Dutt, Ashutosh Dixit, Dan Williams, dmaengine,
linux-kernel, kernel-janitors
On Mon, Feb 29, 2016 at 12:51:07PM +0300, Dan Carpenter wrote:
> This is harmless because the caller only cares about zero vs non-zero
> but we should be returning PTR_ERR() here.
Applied thanks
--
~Vinod
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-03-03 15:55 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-29 9:51 [patch] dma/mic_x100_dma: IS_ERR() vs PTR_ERR() typo Dan Carpenter
2016-02-29 9:51 ` Dan Carpenter
2016-03-03 15:43 ` Vinod Koul
2016-03-03 15:55 ` Vinod Koul
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.