* [PATCH] xfs/137: require scratch to be CRC enabled XFS
@ 2016-03-03 4:38 ` Eryu Guan
0 siblings, 0 replies; 4+ messages in thread
From: Eryu Guan @ 2016-03-03 4:38 UTC (permalink / raw)
To: fstests; +Cc: xfs, Eryu Guan
This test is only valid for CRC enabled XFS, and test fails with
MKFS_OPTIONS="-m crc=0" being set (no mount failure detected).
Fix it by adding _require_scratch_xfs_crc, which ensures scratch device
has CRC support and enabled.
Signed-off-by: Eryu Guan <eguan@redhat.com>
---
tests/xfs/137 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/xfs/137 b/tests/xfs/137
index f162264..dec9fc9 100755
--- a/tests/xfs/137
+++ b/tests/xfs/137
@@ -52,7 +52,7 @@ rm -f $seqres.full
_supported_fs xfs
_supported_os Linux
_require_scratch
-_require_xfs_crc
+_require_scratch_xfs_crc
_require_xfs_db_command "logformat"
_scratch_mkfs >> $seqres.full 2>&1 || _fail "mkfs failed"
--
2.5.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] xfs/137: require scratch to be CRC enabled XFS
@ 2016-03-03 4:38 ` Eryu Guan
0 siblings, 0 replies; 4+ messages in thread
From: Eryu Guan @ 2016-03-03 4:38 UTC (permalink / raw)
To: fstests; +Cc: Eryu Guan, xfs
This test is only valid for CRC enabled XFS, and test fails with
MKFS_OPTIONS="-m crc=0" being set (no mount failure detected).
Fix it by adding _require_scratch_xfs_crc, which ensures scratch device
has CRC support and enabled.
Signed-off-by: Eryu Guan <eguan@redhat.com>
---
tests/xfs/137 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/xfs/137 b/tests/xfs/137
index f162264..dec9fc9 100755
--- a/tests/xfs/137
+++ b/tests/xfs/137
@@ -52,7 +52,7 @@ rm -f $seqres.full
_supported_fs xfs
_supported_os Linux
_require_scratch
-_require_xfs_crc
+_require_scratch_xfs_crc
_require_xfs_db_command "logformat"
_scratch_mkfs >> $seqres.full 2>&1 || _fail "mkfs failed"
--
2.5.0
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] xfs/137: require scratch to be CRC enabled XFS
2016-03-03 4:38 ` Eryu Guan
@ 2016-03-03 7:37 ` Christoph Hellwig
-1 siblings, 0 replies; 4+ messages in thread
From: Christoph Hellwig @ 2016-03-03 7:37 UTC (permalink / raw)
To: Eryu Guan; +Cc: fstests, xfs
Looks fine,
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-03-03 7:38 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-03 4:38 [PATCH] xfs/137: require scratch to be CRC enabled XFS Eryu Guan
2016-03-03 4:38 ` Eryu Guan
2016-03-03 7:37 ` Christoph Hellwig
2016-03-03 7:37 ` Christoph Hellwig
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.