All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Gustavo Padovan <gustavo@padovan.org>
Cc: devel@driverdev.osuosl.org,
	"Daniel Stone" <daniels@collabora.com>,
	"Daniel Vetter" <daniel.vetter@ffwll.ch>,
	"Riley Andrews" <riandrews@android.com>,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	"Arve Hjønnevåg" <arve@android.com>,
	"Gustavo Padovan" <gustavo.padovan@collabora.co.uk>,
	"John Harrison" <John.C.Harrison@Intel.com>
Subject: Re: [PATCH] staging/android: add flags member to sync ioctl structs
Date: Thu, 3 Mar 2016 08:17:14 -0800	[thread overview]
Message-ID: <20160303161714.GA4133@kroah.com> (raw)
In-Reply-To: <1457015837-7609-1-git-send-email-gustavo@padovan.org>

On Thu, Mar 03, 2016 at 11:37:17AM -0300, Gustavo Padovan wrote:
> From: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
> 
> Play safe and add flags member to all structs. So we don't need to
> break API or create new IOCTL in the future if new features that requires
> flags arises.
> 
> v2: check if flags are valid (zero, in this case)
> 
> v3: return -EINVAL if flags are not zero'ed
> 
> v4: add padding for 64-bit alignment
> 
> v5: rebase to use only stacked sync_file_info

Why are these vX things here in the changelog?

And you just broke all existing userspace users of this code, why are
you allowed to do that?

not ok...

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Gustavo Padovan <gustavo@padovan.org>
Cc: devel@driverdev.osuosl.org, "Rob Clark" <robdclark@gmail.com>,
	"Daniel Stone" <daniels@collabora.com>,
	"Daniel Vetter" <daniel.vetter@ffwll.ch>,
	"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
	"Riley Andrews" <riandrews@android.com>,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	"Arve Hjønnevåg" <arve@android.com>,
	"Greg Hackmann" <ghackmann@google.com>,
	"Gustavo Padovan" <gustavo.padovan@collabora.co.uk>,
	"John Harrison" <John.C.Harrison@Intel.com>
Subject: Re: [PATCH] staging/android: add flags member to sync ioctl structs
Date: Thu, 3 Mar 2016 08:17:14 -0800	[thread overview]
Message-ID: <20160303161714.GA4133@kroah.com> (raw)
In-Reply-To: <1457015837-7609-1-git-send-email-gustavo@padovan.org>

On Thu, Mar 03, 2016 at 11:37:17AM -0300, Gustavo Padovan wrote:
> From: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
> 
> Play safe and add flags member to all structs. So we don't need to
> break API or create new IOCTL in the future if new features that requires
> flags arises.
> 
> v2: check if flags are valid (zero, in this case)
> 
> v3: return -EINVAL if flags are not zero'ed
> 
> v4: add padding for 64-bit alignment
> 
> v5: rebase to use only stacked sync_file_info

Why are these vX things here in the changelog?

And you just broke all existing userspace users of this code, why are
you allowed to do that?

not ok...

  reply	other threads:[~2016-03-03 16:17 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-02 19:52 [PATCH v6 1/6] staging/android: add num_fences field to struct sync_file_info Gustavo Padovan
2016-03-02 19:52 ` Gustavo Padovan
2016-03-02 19:52 ` [PATCH v6 2/6] staging/android: rename SYNC_IOC_FENCE_INFO Gustavo Padovan
2016-03-02 19:52   ` Gustavo Padovan
2016-03-02 19:52 ` [PATCH v6 3/6] staging/android: remove redundant comments on sync_merge_data Gustavo Padovan
2016-03-02 19:52   ` Gustavo Padovan
2016-03-02 19:52 ` [PATCH v6 4/6] staging/android: align struct sync_merge_data to a multiple of 64-bits Gustavo Padovan
2016-03-02 19:52   ` Gustavo Padovan
2016-03-02 21:40   ` Gustavo Padovan
2016-03-02 21:40     ` Gustavo Padovan
2016-03-02 19:52 ` [PATCH v6 5/6] staging/android: refactor SYNC_IOC_FILE_INFO Gustavo Padovan
2016-03-02 19:52   ` Gustavo Padovan
2016-03-03  9:29   ` Maarten Lankhorst
2016-03-03 14:34   ` [PATCH] " Gustavo Padovan
2016-03-03 14:34     ` Gustavo Padovan
2016-03-03 14:59     ` Maarten Lankhorst
2016-03-03 14:59       ` Maarten Lankhorst
2016-03-02 19:52 ` [PATCH v6 6/6] staging/android: add flags member to sync ioctl structs Gustavo Padovan
2016-03-02 21:51   ` [PATCH] " Gustavo Padovan
2016-03-02 21:51     ` Gustavo Padovan
2016-03-03 14:37     ` Gustavo Padovan
2016-03-03 14:37       ` Gustavo Padovan
2016-03-03 16:17       ` Greg Kroah-Hartman [this message]
2016-03-03 16:17         ` Greg Kroah-Hartman
2016-03-03 19:14         ` Gustavo Padovan
2016-03-03 19:42           ` Gustavo Padovan
2016-03-03 19:42             ` Gustavo Padovan
2016-03-03 20:01         ` Ville Syrjälä
2016-03-03 20:01           ` Ville Syrjälä
2016-03-03 20:54         ` Rob Clark
2016-03-03 20:54           ` Rob Clark
2016-03-03 21:47           ` Rob Clark
2016-03-03 21:47             ` Rob Clark
2016-03-04 16:40         ` Daniel Vetter
2016-03-04 16:40           ` Daniel Vetter
2016-03-11 21:59           ` Greg Kroah-Hartman
2016-03-05 12:58         ` Emil Velikov
2016-03-05 12:58           ` Emil Velikov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160303161714.GA4133@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=John.C.Harrison@Intel.com \
    --cc=arve@android.com \
    --cc=daniel.vetter@ffwll.ch \
    --cc=daniels@collabora.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gustavo.padovan@collabora.co.uk \
    --cc=gustavo@padovan.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=riandrews@android.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.