All of lore.kernel.org
 help / color / mirror / Atom feed
* compress offload patch
@ 2016-03-03 16:09 Eric Laurent
  2016-03-04  9:49 ` Takashi Iwai
  0 siblings, 1 reply; 5+ messages in thread
From: Eric Laurent @ 2016-03-03 16:09 UTC (permalink / raw)
  To: Takashi Iwai, Koul, Vinod; +Cc: alsa-devel

[-- Attachment #1: Type: text/plain, Size: 114 bytes --]

Takashi, Vinod,

Can you help with merging the attached patch for compress offload core
upstream?

Thanks.

Eric.

[-- Attachment #2: 0001-ALSA-compress-allow-writes-in-SNDRV_PCM_STATE_PREPAR.patch --]
[-- Type: text/x-patch, Size: 1141 bytes --]

From 1166adf4b63ea3ee1d119c46d97fa65c76a08447 Mon Sep 17 00:00:00 2001
From: Eric Laurent <elaurent@google.com>
Date: Wed, 2 Mar 2016 09:54:57 -0800
Subject: [PATCH] ALSA: compress: allow writes in SNDRV_PCM_STATE_PREPARED
 state

Allow writes in SNDRV_PCM_STATE_PREPARED state so that more
than one buffer fragment can be written from user space
before calling SNDRV_COMPRESS_START.

Signed-off-by: Eric Laurent <elaurent@google.com>
---
 sound/core/compress_offload.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/core/compress_offload.c b/sound/core/compress_offload.c
index 1b77852..7c57f37 100644
--- a/sound/core/compress_offload.c
+++ b/sound/core/compress_offload.c
@@ -281,6 +281,7 @@ static ssize_t snd_compr_write(struct file *f, const char __user *buf,
 	mutex_lock(&stream->device->lock);
 	/* write is allowed when stream is running or has been steup */
 	if (stream->runtime->state != SNDRV_PCM_STATE_SETUP &&
+	    stream->runtime->state != SNDRV_PCM_STATE_PREPARED &&
 			stream->runtime->state != SNDRV_PCM_STATE_RUNNING) {
 		mutex_unlock(&stream->device->lock);
 		return -EBADFD;
-- 
2.7.0.rc3.207.g0ac5344


[-- Attachment #3: Type: text/plain, Size: 0 bytes --]



^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: compress offload patch
  2016-03-03 16:09 compress offload patch Eric Laurent
@ 2016-03-04  9:49 ` Takashi Iwai
  2016-03-04 13:52   ` Vinod Koul
  0 siblings, 1 reply; 5+ messages in thread
From: Takashi Iwai @ 2016-03-04  9:49 UTC (permalink / raw)
  To: Eric Laurent; +Cc: Koul, Vinod, alsa-devel

On Thu, 03 Mar 2016 17:09:52 +0100,
Eric Laurent wrote:
> 
> Takashi, Vinod,
> 
> Can you help with merging the attached patch for compress offload core
> upstream?

Looks good to me, but I'm waiting for ack from Vinod.

BTW, I noticed that SNDRV_PCM_STREAM_PREPARED is missing in the
comment in snd_compr_open().  Should be fixed in another patch.


thanks,

Takashi

> 
> Thanks.
> 
> Eric.
> [1.2  <text/html; UTF-8 (7bit)>]
> 
> From 1166adf4b63ea3ee1d119c46d97fa65c76a08447 Mon Sep 17 00:00:00 2001
> From: Eric Laurent <elaurent@google.com>
> Date: Wed, 2 Mar 2016 09:54:57 -0800
> Subject: [PATCH] ALSA: compress: allow writes in SNDRV_PCM_STATE_PREPARED
>  state
> 
> Allow writes in SNDRV_PCM_STATE_PREPARED state so that more
> than one buffer fragment can be written from user space
> before calling SNDRV_COMPRESS_START.
> 
> Signed-off-by: Eric Laurent <elaurent@google.com>
> ---
>  sound/core/compress_offload.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/sound/core/compress_offload.c b/sound/core/compress_offload.c
> index 1b77852..7c57f37 100644
> --- a/sound/core/compress_offload.c
> +++ b/sound/core/compress_offload.c
> @@ -281,6 +281,7 @@ static ssize_t snd_compr_write(struct file *f, const char __user *buf,
>  	mutex_lock(&stream->device->lock);
>  	/* write is allowed when stream is running or has been steup */
>  	if (stream->runtime->state != SNDRV_PCM_STATE_SETUP &&
> +	    stream->runtime->state != SNDRV_PCM_STATE_PREPARED &&
>  			stream->runtime->state != SNDRV_PCM_STATE_RUNNING) {
>  		mutex_unlock(&stream->device->lock);
>  		return -EBADFD;
> -- 
> 2.7.0.rc3.207.g0ac5344
> 

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: compress offload patch
  2016-03-04 13:52   ` Vinod Koul
@ 2016-03-04 13:51     ` Takashi Iwai
  2016-03-04 16:50       ` Eric Laurent
  0 siblings, 1 reply; 5+ messages in thread
From: Takashi Iwai @ 2016-03-04 13:51 UTC (permalink / raw)
  To: Vinod Koul; +Cc: alsa-devel, Eric Laurent

On Fri, 04 Mar 2016 14:52:00 +0100,
Vinod Koul wrote:
> 
> On Fri, Mar 04, 2016 at 10:49:34AM +0100, Takashi Iwai wrote:
> > On Thu, 03 Mar 2016 17:09:52 +0100,
> > Eric Laurent wrote:
> > > 
> > > Takashi, Vinod,
> > > 
> > > Can you help with merging the attached patch for compress offload core
> > > upstream?
> > 
> > Looks good to me, but I'm waiting for ack from Vinod.
> 
> Sounds good to me so:
> 
> Acked-by: Vinod Koul <vinod.koul@intel.com>

OK, merged now to for-next branch.

> > BTW, I noticed that SNDRV_PCM_STREAM_PREPARED is missing in the
> > comment in snd_compr_open().  Should be fixed in another patch.
> 
> Yes will send that and noticed a typo, will fix both

Great, thanks.


Takashi

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: compress offload patch
  2016-03-04  9:49 ` Takashi Iwai
@ 2016-03-04 13:52   ` Vinod Koul
  2016-03-04 13:51     ` Takashi Iwai
  0 siblings, 1 reply; 5+ messages in thread
From: Vinod Koul @ 2016-03-04 13:52 UTC (permalink / raw)
  To: Takashi Iwai; +Cc: alsa-devel, Eric Laurent

On Fri, Mar 04, 2016 at 10:49:34AM +0100, Takashi Iwai wrote:
> On Thu, 03 Mar 2016 17:09:52 +0100,
> Eric Laurent wrote:
> > 
> > Takashi, Vinod,
> > 
> > Can you help with merging the attached patch for compress offload core
> > upstream?
> 
> Looks good to me, but I'm waiting for ack from Vinod.

Sounds good to me so:

Acked-by: Vinod Koul <vinod.koul@intel.com>

> 
> BTW, I noticed that SNDRV_PCM_STREAM_PREPARED is missing in the
> comment in snd_compr_open().  Should be fixed in another patch.

Yes will send that and noticed a typo, will fix both

Thanks
-- 
~Vinod

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: compress offload patch
  2016-03-04 13:51     ` Takashi Iwai
@ 2016-03-04 16:50       ` Eric Laurent
  0 siblings, 0 replies; 5+ messages in thread
From: Eric Laurent @ 2016-03-04 16:50 UTC (permalink / raw)
  To: Takashi Iwai; +Cc: Vinod Koul, alsa-devel

Thanks

On Fri, Mar 4, 2016 at 5:51 AM, Takashi Iwai <tiwai@suse.de> wrote:

> On Fri, 04 Mar 2016 14:52:00 +0100,
> Vinod Koul wrote:
> >
> > On Fri, Mar 04, 2016 at 10:49:34AM +0100, Takashi Iwai wrote:
> > > On Thu, 03 Mar 2016 17:09:52 +0100,
> > > Eric Laurent wrote:
> > > >
> > > > Takashi, Vinod,
> > > >
> > > > Can you help with merging the attached patch for compress offload
> core
> > > > upstream?
> > >
> > > Looks good to me, but I'm waiting for ack from Vinod.
> >
> > Sounds good to me so:
> >
> > Acked-by: Vinod Koul <vinod.koul@intel.com>
>
> OK, merged now to for-next branch.
>
> > > BTW, I noticed that SNDRV_PCM_STREAM_PREPARED is missing in the
> > > comment in snd_compr_open().  Should be fixed in another patch.
> >
> > Yes will send that and noticed a typo, will fix both
>
> Great, thanks.
>
>
> Takashi
>

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2016-03-04 16:50 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-03 16:09 compress offload patch Eric Laurent
2016-03-04  9:49 ` Takashi Iwai
2016-03-04 13:52   ` Vinod Koul
2016-03-04 13:51     ` Takashi Iwai
2016-03-04 16:50       ` Eric Laurent

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.