From: Bjorn Helgaas <helgaas@kernel.org>
To: "Krzysztof Hałasa" <khalasa@piap.pl>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] Fix NULL ptr dereference in pci_bus_assign_domain_nr() on ARM
Date: Fri, 4 Mar 2016 10:27:37 -0600 [thread overview]
Message-ID: <20160304162737.GA1296@localhost> (raw)
In-Reply-To: <m38u1yojmq.fsf@t19.piap.pl>
On Fri, Mar 04, 2016 at 07:13:49AM +0100, Krzysztof Hałasa wrote:
> Hi Bjorn,
>
> Bjorn Helgaas <helgaas@kernel.org> writes:
>
> > On Tue, Mar 01, 2016 at 07:07:18AM +0100, Krzysztof Hałasa wrote:
> >> Many ARM platforms use a wrapper:
> >> /*
> >> * Compatibility wrapper for older platforms that do not care about
> >> * passing the parent device.
> >> */
> >> static inline void pci_common_init(struct hw_pci *hw)
> >> {
> >> pci_common_init_dev(NULL, hw);
> >> }
> >>
> >> which means that pci_bus_assign_domain_nr() can be called without
> >> a parent. This patch fixes the NULL pointer dereference.
> >
> > What exactly is the impact of this? Does this fix need to be in v4.5?
> > It sounds like it should be, but I need a little more detailed
> > justification, e.g., "platforms X, Y, Z don't boot at all without
> > this change."
>
> At least CNS3xxx doesn't boot. I haven't verified a couple of others,
> but they may be broken as well.
Good, thanks. Also (I should have asked this before), please include a
"Fixes:" line so we know exactly when this broke and what stable kernels
need the fix.
Bjorn
WARNING: multiple messages have this Message-ID (diff)
From: helgaas@kernel.org (Bjorn Helgaas)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] Fix NULL ptr dereference in pci_bus_assign_domain_nr() on ARM
Date: Fri, 4 Mar 2016 10:27:37 -0600 [thread overview]
Message-ID: <20160304162737.GA1296@localhost> (raw)
In-Reply-To: <m38u1yojmq.fsf@t19.piap.pl>
On Fri, Mar 04, 2016 at 07:13:49AM +0100, Krzysztof Ha?asa wrote:
> Hi Bjorn,
>
> Bjorn Helgaas <helgaas@kernel.org> writes:
>
> > On Tue, Mar 01, 2016 at 07:07:18AM +0100, Krzysztof Ha?asa wrote:
> >> Many ARM platforms use a wrapper:
> >> /*
> >> * Compatibility wrapper for older platforms that do not care about
> >> * passing the parent device.
> >> */
> >> static inline void pci_common_init(struct hw_pci *hw)
> >> {
> >> pci_common_init_dev(NULL, hw);
> >> }
> >>
> >> which means that pci_bus_assign_domain_nr() can be called without
> >> a parent. This patch fixes the NULL pointer dereference.
> >
> > What exactly is the impact of this? Does this fix need to be in v4.5?
> > It sounds like it should be, but I need a little more detailed
> > justification, e.g., "platforms X, Y, Z don't boot at all without
> > this change."
>
> At least CNS3xxx doesn't boot. I haven't verified a couple of others,
> but they may be broken as well.
Good, thanks. Also (I should have asked this before), please include a
"Fixes:" line so we know exactly when this broke and what stable kernels
need the fix.
Bjorn
next prev parent reply other threads:[~2016-03-04 16:27 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-01 6:07 [PATCH] Fix NULL ptr dereference in pci_bus_assign_domain_nr() on ARM Krzysztof Hałasa
2016-03-01 6:07 ` Krzysztof Hałasa
2016-03-03 17:35 ` Bjorn Helgaas
2016-03-03 17:35 ` Bjorn Helgaas
2016-03-04 6:13 ` Krzysztof Hałasa
2016-03-04 6:13 ` Krzysztof Hałasa
2016-03-04 16:27 ` Bjorn Helgaas [this message]
2016-03-04 16:27 ` Bjorn Helgaas
2016-03-07 13:54 ` Krzysztof Hałasa
2016-03-07 13:54 ` Krzysztof Hałasa
2016-03-07 22:33 ` Bjorn Helgaas
2016-03-07 22:33 ` Bjorn Helgaas
2016-03-08 3:01 ` Lorenzo Pieralisi
2016-03-08 3:01 ` Lorenzo Pieralisi
2016-03-08 4:24 ` Bjorn Helgaas
2016-03-08 4:24 ` Bjorn Helgaas
2016-03-08 10:49 ` Lorenzo Pieralisi
2016-03-08 10:49 ` Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160304162737.GA1296@localhost \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=khalasa@piap.pl \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.