From: Arnd Bergmann <arnd@arndb.de>
To: Robert Jarzmik <robert.jarzmik@free.fr>
Cc: Brian Norris <computersforpeace@gmail.com>,
David Woodhouse <dwmw2@infradead.org>,
linux-arm-kernel@lists.infradead.org, linux-arch@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org,
Haojian Zhuang <haojian.zhuang@gmail.com>,
Daniel Mack <daniel@zonque.org>
Subject: Re: [PATCH] mtd: only use __xipram annotation when XIP_KERNEL is set
Date: Sun, 6 Mar 2016 20:56:01 +0100 [thread overview]
Message-ID: <201603062056.01683.arnd@arndb.de> (raw)
In-Reply-To: <8737s5wbxa.fsf@belgarion.home>
On Saturday 05 March 2016, Robert Jarzmik wrote:
> Arnd Bergmann <arnd@arndb.de> writes:
>
> > I guess we can bring back the macros for the case that MTD_XIP and XIP_KERNEL
> > are both enabled.
> >
> > Arnd
> I wouldn't have ICMR and ICIP exposed to drivers, Eric's original move looks
> corect to me.
Yes, it's a reasonable cleanup that we have done in many places, except
this one introduced a regression for MTD_XIP.
> On the other hand, I'm wondering if xip_irqpending(), xip_currtime() and
> xip_cpu_idle() should be declared as functions in mtd-xip.h, and be part of
> something like arch/arm/mach-pxa/xip.c ...
They have to at least be marked __xipram and must not reference anything
in .text or .rodata, but there might be additional requirements.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] mtd: only use __xipram annotation when XIP_KERNEL is set
Date: Sun, 6 Mar 2016 20:56:01 +0100 [thread overview]
Message-ID: <201603062056.01683.arnd@arndb.de> (raw)
In-Reply-To: <8737s5wbxa.fsf@belgarion.home>
On Saturday 05 March 2016, Robert Jarzmik wrote:
> Arnd Bergmann <arnd@arndb.de> writes:
>
> > I guess we can bring back the macros for the case that MTD_XIP and XIP_KERNEL
> > are both enabled.
> >
> > Arnd
> I wouldn't have ICMR and ICIP exposed to drivers, Eric's original move looks
> corect to me.
Yes, it's a reasonable cleanup that we have done in many places, except
this one introduced a regression for MTD_XIP.
> On the other hand, I'm wondering if xip_irqpending(), xip_currtime() and
> xip_cpu_idle() should be declared as functions in mtd-xip.h, and be part of
> something like arch/arm/mach-pxa/xip.c ...
They have to at least be marked __xipram and must not reference anything
in .text or .rodata, but there might be additional requirements.
Arnd
next prev parent reply other threads:[~2016-03-06 19:57 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-25 15:41 [PATCH] mtd: only use __xipram annotation when XIP_KERNEL is set Arnd Bergmann
2016-01-25 15:41 ` Arnd Bergmann
2016-03-05 0:02 ` Brian Norris
2016-03-05 0:02 ` Brian Norris
2016-03-05 0:10 ` Brian Norris
2016-03-05 0:10 ` Brian Norris
2016-03-05 0:24 ` Arnd Bergmann
2016-03-05 0:24 ` Arnd Bergmann
2016-03-05 0:24 ` Arnd Bergmann
2016-03-05 8:45 ` Robert Jarzmik
2016-03-05 8:45 ` Robert Jarzmik
2016-03-06 19:56 ` Arnd Bergmann [this message]
2016-03-06 19:56 ` Arnd Bergmann
2016-03-05 0:19 ` Arnd Bergmann
2016-03-05 0:19 ` Arnd Bergmann
2016-03-05 0:22 ` Brian Norris
2016-03-05 0:22 ` Brian Norris
2016-03-05 0:28 ` David Woodhouse
2016-03-05 0:28 ` David Woodhouse
2016-03-05 0:43 ` Brian Norris
2016-03-05 0:43 ` Brian Norris
2016-03-17 15:56 ` Arnd Bergmann
2016-03-17 15:56 ` Arnd Bergmann
2016-03-05 0:33 ` Arnd Bergmann
2016-03-05 0:33 ` Arnd Bergmann
2016-03-05 0:33 ` Arnd Bergmann
2016-03-07 16:43 ` Tony Lindgren
2016-03-07 16:43 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201603062056.01683.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=computersforpeace@gmail.com \
--cc=daniel@zonque.org \
--cc=dwmw2@infradead.org \
--cc=haojian.zhuang@gmail.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=robert.jarzmik@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.