* [PATCH] drm/vmwgfx: Add back ->detect() and ->fill_modes()
@ 2016-03-07 17:06 Thierry Reding
2016-03-07 20:13 ` Daniel Vetter
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Thierry Reding @ 2016-03-07 17:06 UTC (permalink / raw)
To: David Airlie
Cc: Daniel Vetter, Thomas Hellstrom, dri-devel, Sebastian Herbszt
From: Thierry Reding <treding@nvidia.com>
This partially reverts commit d56f57ac969c ("drm/gma500: Move to private
save/restore hooks") which removed these lines by mistake.
Reported-by: Sebastian Herbszt <herbszt@gmx.de>
Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: Thierry Reding <treding@nvidia.com>
---
Hi Dave,
Daniel and I introduced this in v4.5-rc1, so it'd be good to have this
go into v4.5 final once Sebastian and Thomas have confirmed that it is
fixed.
drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c b/drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c
index db082bea8daf..c5a1a08b0449 100644
--- a/drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c
+++ b/drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c
@@ -563,6 +563,8 @@ static void vmw_sou_connector_destroy(struct drm_connector *connector)
static const struct drm_connector_funcs vmw_sou_connector_funcs = {
.dpms = vmw_du_connector_dpms,
+ .detect = vmw_du_connector_detect,
+ .fill_modes = vmw_du_connector_fill_modes,
.set_property = vmw_du_connector_set_property,
.destroy = vmw_sou_connector_destroy,
};
--
2.7.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/vmwgfx: Add back ->detect() and ->fill_modes()
2016-03-07 17:06 [PATCH] drm/vmwgfx: Add back ->detect() and ->fill_modes() Thierry Reding
@ 2016-03-07 20:13 ` Daniel Vetter
2016-03-07 21:18 ` Thomas Hellstrom
2016-03-07 23:15 ` Sebastian Herbszt
2 siblings, 0 replies; 5+ messages in thread
From: Daniel Vetter @ 2016-03-07 20:13 UTC (permalink / raw)
To: Thierry Reding; +Cc: Thomas Hellstrom, dri-devel, Sebastian Herbszt
On Mon, Mar 7, 2016 at 6:06 PM, Thierry Reding <thierry.reding@gmail.com> wrote:
> From: Thierry Reding <treding@nvidia.com>
>
> This partially reverts commit d56f57ac969c ("drm/gma500: Move to private
> save/restore hooks") which removed these lines by mistake.
>
> Reported-by: Sebastian Herbszt <herbszt@gmx.de>
> Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
> Hi Dave,
>
> Daniel and I introduced this in v4.5-rc1, so it'd be good to have this
> go into v4.5 final once Sebastian and Thomas have confirmed that it is
> fixed.
Yeah, sorry for the silly mistake - no idea any more how that crept
in, there's no pending patch series at all even touching these hooks.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/vmwgfx: Add back ->detect() and ->fill_modes()
2016-03-07 17:06 [PATCH] drm/vmwgfx: Add back ->detect() and ->fill_modes() Thierry Reding
2016-03-07 20:13 ` Daniel Vetter
@ 2016-03-07 21:18 ` Thomas Hellstrom
2016-03-07 23:15 ` Sebastian Herbszt
2 siblings, 0 replies; 5+ messages in thread
From: Thomas Hellstrom @ 2016-03-07 21:18 UTC (permalink / raw)
To: Thierry Reding, David Airlie; +Cc: Daniel Vetter, dri-devel, Sebastian Herbszt
Tested-by: Thomas Hellstrom <thellstrom@vmware.com>
On 03/07/2016 06:06 PM, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
>
> This partially reverts commit d56f57ac969c ("drm/gma500: Move to private
> save/restore hooks") which removed these lines by mistake.
>
> Reported-by: Sebastian Herbszt <herbszt@gmx.de>
> Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
> Hi Dave,
>
> Daniel and I introduced this in v4.5-rc1, so it'd be good to have this
> go into v4.5 final once Sebastian and Thomas have confirmed that it is
> fixed.
>
> drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c b/drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c
> index db082bea8daf..c5a1a08b0449 100644
> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c
> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c
> @@ -563,6 +563,8 @@ static void vmw_sou_connector_destroy(struct drm_connector *connector)
>
> static const struct drm_connector_funcs vmw_sou_connector_funcs = {
> .dpms = vmw_du_connector_dpms,
> + .detect = vmw_du_connector_detect,
> + .fill_modes = vmw_du_connector_fill_modes,
> .set_property = vmw_du_connector_set_property,
> .destroy = vmw_sou_connector_destroy,
> };
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/vmwgfx: Add back ->detect() and ->fill_modes()
2016-03-07 17:06 [PATCH] drm/vmwgfx: Add back ->detect() and ->fill_modes() Thierry Reding
2016-03-07 20:13 ` Daniel Vetter
2016-03-07 21:18 ` Thomas Hellstrom
@ 2016-03-07 23:15 ` Sebastian Herbszt
2016-03-08 1:16 ` Dave Airlie
2 siblings, 1 reply; 5+ messages in thread
From: Sebastian Herbszt @ 2016-03-07 23:15 UTC (permalink / raw)
To: Thierry Reding
Cc: Thomas Hellstrom, Daniel Vetter, dri-devel, Jongman Heo,
Sebastian Herbszt
Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
>
> This partially reverts commit d56f57ac969c ("drm/gma500: Move to private
> save/restore hooks") which removed these lines by mistake.
>
> Reported-by: Sebastian Herbszt <herbszt@gmx.de>
> Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
> Hi Dave,
>
> Daniel and I introduced this in v4.5-rc1, so it'd be good to have this
> go into v4.5 final once Sebastian and Thomas have confirmed that it is
> fixed.
>
> drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c b/drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c
> index db082bea8daf..c5a1a08b0449 100644
> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c
> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c
> @@ -563,6 +563,8 @@ static void vmw_sou_connector_destroy(struct drm_connector *connector)
>
> static const struct drm_connector_funcs vmw_sou_connector_funcs = {
> .dpms = vmw_du_connector_dpms,
> + .detect = vmw_du_connector_detect,
> + .fill_modes = vmw_du_connector_fill_modes,
> .set_property = vmw_du_connector_set_property,
> .destroy = vmw_sou_connector_destroy,
> };
Tested-by: Sebastian Herbszt <herbszt@gmx.de>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/vmwgfx: Add back ->detect() and ->fill_modes()
2016-03-07 23:15 ` Sebastian Herbszt
@ 2016-03-08 1:16 ` Dave Airlie
0 siblings, 0 replies; 5+ messages in thread
From: Dave Airlie @ 2016-03-08 1:16 UTC (permalink / raw)
To: Sebastian Herbszt; +Cc: Jongman Heo, Daniel Vetter, Thomas Hellstrom, dri-devel
On 8 March 2016 at 09:15, Sebastian Herbszt <herbszt@gmx.de> wrote:
> Thierry Reding wrote:
>> From: Thierry Reding <treding@nvidia.com>
>>
>> This partially reverts commit d56f57ac969c ("drm/gma500: Move to private
>> save/restore hooks") which removed these lines by mistake.
>>
Thanks I've pulled this into drm-fixes.
Dave.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-03-08 1:16 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-07 17:06 [PATCH] drm/vmwgfx: Add back ->detect() and ->fill_modes() Thierry Reding
2016-03-07 20:13 ` Daniel Vetter
2016-03-07 21:18 ` Thomas Hellstrom
2016-03-07 23:15 ` Sebastian Herbszt
2016-03-08 1:16 ` Dave Airlie
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.