All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thierry Reding <treding@nvidia.com>
To: Laxman Dewangan <ldewangan@nvidia.com>
Cc: linus.walleij@linaro.org, robh+dt@kernel.org, pawel.moll@arm.com,
	mark.rutland@arm.com, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
	swarren@wwwdotorg.org
Subject: Re: [PATCH 1/5] gpio: of: Scan available child node for gpio-hog
Date: Tue, 8 Mar 2016 15:18:46 +0100	[thread overview]
Message-ID: <20160308141844.GA9864@ulmo.nvidia.com> (raw)
In-Reply-To: <1457438528-29054-2-git-send-email-ldewangan@nvidia.com>

[-- Attachment #1: Type: text/plain, Size: 953 bytes --]

On Tue, Mar 08, 2016 at 05:32:04PM +0530, Laxman Dewangan wrote:
> Look for child node which are available when iterating for
> gpio hog node for request/set GPIO initial configuration
> during OF gpio chip registration.
> 
> Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
> ---
>  drivers/gpio/gpiolib-of.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpio/gpiolib-of.c b/drivers/gpio/gpiolib-of.c
> index 42a4bb7..f2ba1a4 100644
> --- a/drivers/gpio/gpiolib-of.c
> +++ b/drivers/gpio/gpiolib-of.c
> @@ -210,7 +210,7 @@ static void of_gpiochip_scan_gpios(struct gpio_chip *chip)
>  	enum gpio_lookup_flags lflags;
>  	enum gpiod_flags dflags;
>  
> -	for_each_child_of_node(chip->of_node, np) {
> +	for_each_available_child_of_node(chip->of_node, np) {
>  		if (!of_property_read_bool(np, "gpio-hog"))
>  			continue;

Makes sense:

Reviewed-by: Thierry Reding <treding@nvidia.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Thierry Reding <treding@nvidia.com>
To: Laxman Dewangan <ldewangan@nvidia.com>
Cc: <linus.walleij@linaro.org>, <robh+dt@kernel.org>,
	<pawel.moll@arm.com>, <mark.rutland@arm.com>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-gpio@vger.kernel.org>, <swarren@wwwdotorg.org>
Subject: Re: [PATCH 1/5] gpio: of: Scan available child node for gpio-hog
Date: Tue, 8 Mar 2016 15:18:46 +0100	[thread overview]
Message-ID: <20160308141844.GA9864@ulmo.nvidia.com> (raw)
In-Reply-To: <1457438528-29054-2-git-send-email-ldewangan@nvidia.com>

[-- Attachment #1: Type: text/plain, Size: 953 bytes --]

On Tue, Mar 08, 2016 at 05:32:04PM +0530, Laxman Dewangan wrote:
> Look for child node which are available when iterating for
> gpio hog node for request/set GPIO initial configuration
> during OF gpio chip registration.
> 
> Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
> ---
>  drivers/gpio/gpiolib-of.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpio/gpiolib-of.c b/drivers/gpio/gpiolib-of.c
> index 42a4bb7..f2ba1a4 100644
> --- a/drivers/gpio/gpiolib-of.c
> +++ b/drivers/gpio/gpiolib-of.c
> @@ -210,7 +210,7 @@ static void of_gpiochip_scan_gpios(struct gpio_chip *chip)
>  	enum gpio_lookup_flags lflags;
>  	enum gpiod_flags dflags;
>  
> -	for_each_child_of_node(chip->of_node, np) {
> +	for_each_available_child_of_node(chip->of_node, np) {
>  		if (!of_property_read_bool(np, "gpio-hog"))
>  			continue;

Makes sense:

Reviewed-by: Thierry Reding <treding@nvidia.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  reply	other threads:[~2016-03-08 14:19 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-08 12:02 [PATCH 0/5] gpio: of: Add error handling and support for multiple gpio in gpio-hog Laxman Dewangan
2016-03-08 12:02 ` Laxman Dewangan
2016-03-08 12:02 ` [PATCH 1/5] gpio: of: Scan available child node for gpio-hog Laxman Dewangan
2016-03-08 12:02   ` Laxman Dewangan
2016-03-08 14:18   ` Thierry Reding [this message]
2016-03-08 14:18     ` Thierry Reding
2016-03-08 12:02 ` [PATCH 2/5] gpio: gpiolib: Print error number if gpio hog failed Laxman Dewangan
2016-03-08 12:02   ` Laxman Dewangan
2016-03-08 12:27   ` Vladimir Zapolskiy
2016-03-08 12:27     ` Vladimir Zapolskiy
2016-03-08 14:22   ` Thierry Reding
2016-03-08 14:22     ` Thierry Reding
2016-03-08 15:32     ` Laxman Dewangan
2016-03-08 15:32       ` Laxman Dewangan
2016-03-09 17:07       ` Stephen Warren
     [not found]         ` <56E0584B.9050607-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2016-03-10  6:58           ` Laxman Dewangan
2016-03-10  6:58             ` Laxman Dewangan
2016-03-08 12:02 ` [PATCH 3/5] gpio: of: Return error if gpio hog configuration failed Laxman Dewangan
2016-03-08 12:02   ` Laxman Dewangan
2016-03-08 14:23   ` Thierry Reding
2016-03-08 14:23     ` Thierry Reding
2016-03-09 17:11   ` Stephen Warren
2016-03-10  7:02     ` Laxman Dewangan
2016-03-10  7:02       ` Laxman Dewangan
2016-03-08 12:02 ` [PATCH 4/5] gpio: of: Add support to have multiple gpios in gpio-hog Laxman Dewangan
2016-03-08 12:02   ` Laxman Dewangan
2016-03-09  6:28   ` Markus Pargmann
2016-03-09 13:20     ` Laxman Dewangan
2016-03-09 13:20       ` Laxman Dewangan
     [not found]       ` <56E02335.6020901-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-03-09 17:17         ` Stephen Warren
2016-03-09 17:17           ` Stephen Warren
     [not found]           ` <56E05AA9.8000503-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2016-03-10  7:07             ` Laxman Dewangan
2016-03-10  7:07               ` Laxman Dewangan
2016-03-10 11:16               ` Markus Pargmann
2016-03-10 11:53                 ` Laxman Dewangan
2016-03-10 11:53                   ` Laxman Dewangan
2016-03-17 15:46                   ` Rob Herring
2016-03-17 17:44                     ` Laxman Dewangan
2016-03-17 17:44                       ` Laxman Dewangan
2016-03-08 12:02 ` [PATCH 5/5] gpio: DT: Rephrase property "gpios" of hog node to support multiple gpios Laxman Dewangan
2016-03-08 12:02   ` Laxman Dewangan
2016-03-09 17:18   ` Stephen Warren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160308141844.GA9864@ulmo.nvidia.com \
    --to=treding@nvidia.com \
    --cc=devicetree@vger.kernel.org \
    --cc=ldewangan@nvidia.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=pawel.moll@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=swarren@wwwdotorg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.