All of lore.kernel.org
 help / color / mirror / Atom feed
* [patch] scsi_dh_alua: uninitialized variable in alua_check_vpd()
@ 2016-03-11 10:17 ` Dan Carpenter
  0 siblings, 0 replies; 33+ messages in thread
From: Dan Carpenter @ 2016-03-11 10:17 UTC (permalink / raw)
  To: James E.J. Bottomley, Hannes Reinecke
  Cc: Martin K. Petersen, Bart Van Assche, Johannes Thumshirn,
	Ewan Milne, linux-scsi, linux-kernel, kernel-janitors

The pg_updated variable is support to be set to zero at the start but
it is uninitialized.

Fixes: cb0a168cb6b8 ('scsi_dh_alua: update 'access_state' field')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/drivers/scsi/device_handler/scsi_dh_alua.c b/drivers/scsi/device_handler/scsi_dh_alua.c
index 5bcdf8d..e4f6174 100644
--- a/drivers/scsi/device_handler/scsi_dh_alua.c
+++ b/drivers/scsi/device_handler/scsi_dh_alua.c
@@ -332,7 +332,7 @@ static int alua_check_vpd(struct scsi_device *sdev, struct alua_dh_data *h,
 {
 	int rel_port = -1, group_id;
 	struct alua_port_group *pg, *old_pg = NULL;
-	bool pg_updated;
+	bool pg_updated = 0;
 	unsigned long flags;
 
 	group_id = scsi_vpd_tpg_id(sdev, &rel_port);

^ permalink raw reply related	[flat|nested] 33+ messages in thread
* [patch] scsi_dh_alua: uninitialized variable in alua_rtpg()
  2016-03-11 10:17 ` Dan Carpenter
@ 2016-04-14  9:39 ` Dan Carpenter
  -1 siblings, 0 replies; 33+ messages in thread
From: Dan Carpenter @ 2016-04-14  9:39 UTC (permalink / raw)
  To: James E.J. Bottomley
  Cc: Martin K. Petersen, Hannes Reinecke, Bart Van Assche,
	Johannes Thumshirn, Ewan Milne, linux-scsi, linux-kernel,
	kernel-janitors

It's possible to use "err" without initializing it.  If it happens to be
a 2 which is SCSI_DH_RETRY then that could cause a bug.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/drivers/scsi/device_handler/scsi_dh_alua.c b/drivers/scsi/device_handler/scsi_dh_alua.c
index 8eaed05..f3c994f 100644
--- a/drivers/scsi/device_handler/scsi_dh_alua.c
+++ b/drivers/scsi/device_handler/scsi_dh_alua.c
@@ -513,7 +513,8 @@ static int alua_rtpg(struct scsi_device *sdev, struct alua_port_group *pg)
 	struct alua_port_group *tmp_pg;
 	int len, k, off, valid_states = 0, bufflen = ALUA_RTPG_SIZE;
 	unsigned char *desc, *buff;
-	unsigned err, retval;
+	unsigned int err = 0;
+	unsigned int retval;
 	unsigned int tpg_desc_tbl_off;
 	unsigned char orig_transition_tmo;
 	unsigned long flags;

^ permalink raw reply related	[flat|nested] 33+ messages in thread

end of thread, other threads:[~2016-04-15 20:26 UTC | newest]

Thread overview: 33+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-11 10:17 [patch] scsi_dh_alua: uninitialized variable in alua_check_vpd() Dan Carpenter
2016-03-11 10:17 ` Dan Carpenter
2016-03-11 10:50 ` Hannes Reinecke
2016-03-11 10:50   ` Hannes Reinecke
2016-03-11 10:50   ` Hannes Reinecke
2016-03-11 11:19   ` [patch v2] " Dan Carpenter
2016-03-11 11:19     ` Dan Carpenter
2016-03-11 11:48     ` Hannes Reinecke
2016-03-11 11:48       ` Hannes Reinecke
2016-03-11 11:48       ` Hannes Reinecke
2016-03-11 14:40     ` Manoj Kumar
2016-03-11 14:40       ` Manoj Kumar
2016-03-14 20:02     ` Martin K. Petersen
2016-03-14 20:02       ` Martin K. Petersen
2016-03-11 11:19   ` [patch] " Dan Carpenter
2016-03-11 11:19     ` Dan Carpenter
  -- strict thread matches above, loose matches on Subject: below --
2016-04-14  9:39 [patch] scsi_dh_alua: uninitialized variable in alua_rtpg() Dan Carpenter
2016-04-14  9:39 ` Dan Carpenter
2016-04-14 15:45 ` Bart Van Assche
2016-04-14 15:45   ` Bart Van Assche
2016-04-14 15:45   ` Bart Van Assche
2016-04-14 18:20   ` [patch v2] " Dan Carpenter
2016-04-14 18:20     ` Dan Carpenter
2016-04-14 18:55     ` Bart Van Assche
2016-04-14 18:55       ` Bart Van Assche
2016-04-14 18:55       ` Bart Van Assche
2016-04-15  5:59     ` Hannes Reinecke
2016-04-15  5:59       ` Hannes Reinecke
2016-04-15  5:59       ` Hannes Reinecke
2016-04-15 20:26     ` Martin K. Petersen
2016-04-15 20:26       ` Martin K. Petersen
2016-04-14 18:20   ` [patch] " Dan Carpenter
2016-04-14 18:20     ` Dan Carpenter

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.