* [PATCH] staging: rtl8712: xmit_linux: Remove unnecessary else after return
@ 2016-03-10 16:47 Bhaktipriya Shridhar
2016-03-11 18:32 ` [Outreachy kernel] " Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Bhaktipriya Shridhar @ 2016-03-10 16:47 UTC (permalink / raw)
To: outreachy-kernel
This patch fixes the checkpatch warning that else is not generally
useful after a break or return.
This was done using Coccinelle:
@@
expression e2;
statement s1;
@@
if(e2) { ... return ...; }
-else
s1
Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
---
drivers/staging/rtl8712/xmit_linux.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8712/xmit_linux.c b/drivers/staging/rtl8712/xmit_linux.c
index f8866d7..adb51f0 100644
--- a/drivers/staging/rtl8712/xmit_linux.c
+++ b/drivers/staging/rtl8712/xmit_linux.c
@@ -72,8 +72,7 @@ sint r8712_endofpktfile(struct pkt_file *pfile)
{
if (pfile->pkt_len == 0)
return true;
- else
- return false;
+ return false;
}
--
2.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Outreachy kernel] [PATCH] staging: rtl8712: xmit_linux: Remove unnecessary else after return
2016-03-10 16:47 [PATCH] staging: rtl8712: xmit_linux: Remove unnecessary else after return Bhaktipriya Shridhar
@ 2016-03-11 18:32 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2016-03-11 18:32 UTC (permalink / raw)
To: Bhaktipriya Shridhar; +Cc: outreachy-kernel
On Thu, Mar 10, 2016 at 10:17:12PM +0530, Bhaktipriya Shridhar wrote:
> This patch fixes the checkpatch warning that else is not generally
> useful after a break or return.
>
> This was done using Coccinelle:
> @@
> expression e2;
> statement s1;
> @@
> if(e2) { ... return ...; }
> -else
> s1
>
> Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
> ---
> drivers/staging/rtl8712/xmit_linux.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Did not apply to my tree :(
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-03-11 18:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-10 16:47 [PATCH] staging: rtl8712: xmit_linux: Remove unnecessary else after return Bhaktipriya Shridhar
2016-03-11 18:32 ` [Outreachy kernel] " Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.