All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Gustavo Padovan <gustavo@padovan.org>
Cc: devel@driverdev.osuosl.org,
	"Daniel Stone" <daniels@collabora.com>,
	"Daniel Vetter" <daniel.vetter@ffwll.ch>,
	"Riley Andrews" <riandrews@android.com>,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	"Arve Hjønnevåg" <arve@android.com>,
	"Gustavo Padovan" <gustavo.padovan@collabora.co.uk>,
	"John Harrison" <John.C.Harrison@Intel.com>
Subject: Re: [PATCH] staging/android: change IOCTLs opcode after ABI change
Date: Fri, 11 Mar 2016 14:00:09 -0800	[thread overview]
Message-ID: <20160311220009.GC11274@kroah.com> (raw)
In-Reply-To: <1457044963-5785-1-git-send-email-gustavo@padovan.org>

On Thu, Mar 03, 2016 at 07:42:43PM -0300, Gustavo Padovan wrote:
> From: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
> 
> Burn the old opcode to avoid any potential old userspace running the old
> API to get weird errors. Changing the opcodes will make them fail right
> away.
> 
> This is just a precaution, there no upstream users of these interfaces
> yet and the only user is Android, but we don't expect anyone trying to
> run android userspace and all it dependencies on top of upstream kernels.
> 
> Moreover Android should be converted to use upstream sync_files.
> 
> Suggested-by: Rob Clark <robdclark@gmail.com>
> Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
> ---
>  drivers/staging/android/uapi/sync.h | 11 +++++++++--
>  1 file changed, 9 insertions(+), 2 deletions(-)

Where does this belong in this patch series?  Before it?  After it?  In
the middle?

Please resend the whole series, gather up all of the reviewed and
signed-off-by markings from everyone involved, and I'll be glad to apply
them.

thanks,

greg k-h
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Gustavo Padovan <gustavo@padovan.org>
Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org,
	dri-devel@lists.freedesktop.org,
	"Daniel Stone" <daniels@collabora.com>,
	"Arve Hjønnevåg" <arve@android.com>,
	"Riley Andrews" <riandrews@android.com>,
	"Daniel Vetter" <daniel.vetter@ffwll.ch>,
	"Rob Clark" <robdclark@gmail.com>,
	"Greg Hackmann" <ghackmann@google.com>,
	"John Harrison" <John.C.Harrison@Intel.com>,
	"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
	"Gustavo Padovan" <gustavo.padovan@collabora.co.uk>
Subject: Re: [PATCH] staging/android: change IOCTLs opcode after ABI change
Date: Fri, 11 Mar 2016 14:00:09 -0800	[thread overview]
Message-ID: <20160311220009.GC11274@kroah.com> (raw)
In-Reply-To: <1457044963-5785-1-git-send-email-gustavo@padovan.org>

On Thu, Mar 03, 2016 at 07:42:43PM -0300, Gustavo Padovan wrote:
> From: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
> 
> Burn the old opcode to avoid any potential old userspace running the old
> API to get weird errors. Changing the opcodes will make them fail right
> away.
> 
> This is just a precaution, there no upstream users of these interfaces
> yet and the only user is Android, but we don't expect anyone trying to
> run android userspace and all it dependencies on top of upstream kernels.
> 
> Moreover Android should be converted to use upstream sync_files.
> 
> Suggested-by: Rob Clark <robdclark@gmail.com>
> Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
> ---
>  drivers/staging/android/uapi/sync.h | 11 +++++++++--
>  1 file changed, 9 insertions(+), 2 deletions(-)

Where does this belong in this patch series?  Before it?  After it?  In
the middle?

Please resend the whole series, gather up all of the reviewed and
signed-off-by markings from everyone involved, and I'll be glad to apply
them.

thanks,

greg k-h

  parent reply	other threads:[~2016-03-11 22:00 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-03 19:40 [PATCH v7 1/5] staging/android: add num_fences field to struct sync_file_info Gustavo Padovan
2016-03-03 19:40 ` Gustavo Padovan
2016-03-03 19:40 ` [PATCH v7 2/5] staging/android: rename SYNC_IOC_FENCE_INFO Gustavo Padovan
2016-03-03 19:40   ` Gustavo Padovan
2016-03-03 19:40 ` [PATCH v7 3/5] staging/android: remove redundant comments on sync_merge_data Gustavo Padovan
2016-03-03 19:40   ` Gustavo Padovan
2016-03-03 19:40 ` [PATCH v7 4/5] staging/android: refactor SYNC_IOC_FILE_INFO Gustavo Padovan
2016-03-03 19:40   ` Gustavo Padovan
2016-03-03 19:40 ` [PATCH v7 5/5] staging/android: add flags member to sync ioctl structs Gustavo Padovan
2016-03-03 19:40   ` Gustavo Padovan
2016-03-03 22:42   ` [PATCH] staging/android: change IOCTLs opcode after ABI change Gustavo Padovan
2016-03-03 22:42     ` Gustavo Padovan
2016-03-09  2:36     ` Greg Hackmann
2016-03-09  2:36       ` Greg Hackmann
2016-03-11 22:00     ` Greg Kroah-Hartman [this message]
2016-03-11 22:00       ` Greg Kroah-Hartman
2016-03-12 17:34       ` Rob Clark
2016-03-12 17:34         ` Rob Clark
2016-03-09  2:36 ` [PATCH v7 1/5] staging/android: add num_fences field to struct sync_file_info Greg Hackmann
2016-03-09  2:36   ` Greg Hackmann
2016-03-31  1:22 ` Greg Kroah-Hartman
2016-03-31  1:22   ` Greg Kroah-Hartman
2016-03-31  2:53   ` Gustavo Padovan
2016-03-31  2:53     ` Gustavo Padovan
2016-03-31  3:02     ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160311220009.GC11274@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=John.C.Harrison@Intel.com \
    --cc=arve@android.com \
    --cc=daniel.vetter@ffwll.ch \
    --cc=daniels@collabora.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gustavo.padovan@collabora.co.uk \
    --cc=gustavo@padovan.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=riandrews@android.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.