* [PATCH] staging: dgnc: replaced udelay with usleep_range in dgnc_cls.c
@ 2016-03-13 1:13 Juliana Rodrigues
2016-03-13 2:57 ` [Outreachy kernel] " Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: Juliana Rodrigues @ 2016-03-13 1:13 UTC (permalink / raw)
To: outreachy-kernel
This patch replaces udelay with usleep_range fixing a checkpatch.pl issue:
CHECK: usleep_range is preferred over udelay; see Documentation/timers/timers-howto.txt
+ udelay(10);
Signed-off-by: Juliana Rodrigues <juliana.orod@gmail.com>
---
drivers/staging/dgnc/dgnc_cls.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/dgnc/dgnc_cls.c b/drivers/staging/dgnc/dgnc_cls.c
index 72f0aaa..51db98b 100644
--- a/drivers/staging/dgnc/dgnc_cls.c
+++ b/drivers/staging/dgnc/dgnc_cls.c
@@ -956,7 +956,7 @@ static void cls_flush_uart_read(struct channel_t *ch)
* Presumably, this is a bug in this UART.
*/
- udelay(10);
+ usleep_range(10000, 11000);
}
static void cls_copy_data_from_queue_to_uart(struct channel_t *ch)
--
2.7.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Outreachy kernel] [PATCH] staging: dgnc: replaced udelay with usleep_range in dgnc_cls.c
2016-03-13 1:13 [PATCH] staging: dgnc: replaced udelay with usleep_range in dgnc_cls.c Juliana Rodrigues
@ 2016-03-13 2:57 ` Greg KH
2016-03-13 12:17 ` Juliana Rodrigues
0 siblings, 1 reply; 3+ messages in thread
From: Greg KH @ 2016-03-13 2:57 UTC (permalink / raw)
To: Juliana Rodrigues; +Cc: outreachy-kernel
On Sat, Mar 12, 2016 at 10:13:23PM -0300, Juliana Rodrigues wrote:
> This patch replaces udelay with usleep_range fixing a checkpatch.pl issue:
>
> CHECK: usleep_range is preferred over udelay; see Documentation/timers/timers-howto.txt
> + udelay(10);
>
> Signed-off-by: Juliana Rodrigues <juliana.orod@gmail.com>
> ---
> drivers/staging/dgnc/dgnc_cls.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/dgnc/dgnc_cls.c b/drivers/staging/dgnc/dgnc_cls.c
> index 72f0aaa..51db98b 100644
> --- a/drivers/staging/dgnc/dgnc_cls.c
> +++ b/drivers/staging/dgnc/dgnc_cls.c
> @@ -956,7 +956,7 @@ static void cls_flush_uart_read(struct channel_t *ch)
> * Presumably, this is a bug in this UART.
> */
>
> - udelay(10);
> + usleep_range(10000, 11000);
How do you know this range is ok?
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Outreachy kernel] [PATCH] staging: dgnc: replaced udelay with usleep_range in dgnc_cls.c
2016-03-13 2:57 ` [Outreachy kernel] " Greg KH
@ 2016-03-13 12:17 ` Juliana Rodrigues
0 siblings, 0 replies; 3+ messages in thread
From: Juliana Rodrigues @ 2016-03-13 12:17 UTC (permalink / raw)
To: Greg KH; +Cc: outreachy-kernel
Em Sáb, 2016-03-12 às 18:57 -0800, Greg KH escreveu:
> On Sat, Mar 12, 2016 at 10:13:23PM -0300, Juliana Rodrigues wrote:
> >
> > This patch replaces udelay with usleep_range fixing a checkpatch.pl
> > issue:
> >
> > CHECK: usleep_range is preferred over udelay; see
> > Documentation/timers/timers-howto.txt
> > + udelay(10);
> >
> > Signed-off-by: Juliana Rodrigues <juliana.orod@gmail.com>
> > ---
> > drivers/staging/dgnc/dgnc_cls.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/dgnc/dgnc_cls.c
> > b/drivers/staging/dgnc/dgnc_cls.c
> > index 72f0aaa..51db98b 100644
> > --- a/drivers/staging/dgnc/dgnc_cls.c
> > +++ b/drivers/staging/dgnc/dgnc_cls.c
> > @@ -956,7 +956,7 @@ static void cls_flush_uart_read(struct
> > channel_t *ch)
> > * Presumably, this is a bug in this UART.
> > */
> >
> > - udelay(10);
> > + usleep_range(10000, 11000);
> How do you know this range is ok?
Probably it isnt. I thought that usleep_range were
in microseconds while udelay in miliseconds. I'll
make a patch to fix this.
Thanks, Greg. :)
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-03-13 12:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-13 1:13 [PATCH] staging: dgnc: replaced udelay with usleep_range in dgnc_cls.c Juliana Rodrigues
2016-03-13 2:57 ` [Outreachy kernel] " Greg KH
2016-03-13 12:17 ` Juliana Rodrigues
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.