From: Thierry Reding <thierry.reding@gmail.com>
To: Rhyland Klein <rklein@nvidia.com>
Cc: Peter De Schrijver <pdeschrijver@nvidia.com>,
Prashant Gaikwad <pgaikwad@nvidia.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@codeaurora.org>,
Stephen Warren <swarren@wwwdotorg.org>,
Alexandre Courbot <gnurou@gmail.com>,
Jon Hunter <jonathanh@nvidia.com>,
linux-clk@vger.kernel.org, linux-tegra@vger.kernel.org,
Bill Huang <bilhuang@nvidia.com>
Subject: Re: [PATCH] clk: tegra210: Add SLCG override gate clocks
Date: Mon, 14 Mar 2016 17:05:51 +0100 [thread overview]
Message-ID: <20160314160551.GA21898@ulmo.nvidia.com> (raw)
In-Reply-To: <1457638685-31007-1-git-send-email-rklein@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 776 bytes --]
On Thu, Mar 10, 2016 at 02:38:05PM -0500, Rhyland Klein wrote:
> From: Bill Huang <bilhuang@nvidia.com>
>
> Add some SLCG (Second Level Clock Gating) override clocks to control
> gating and un-gating their logics.
>
> Signed-off-by: Bill Huang <bilhuang@nvidia.com>
> Signed-off-by: Rhyland Klein <rklein@nvidia.com>
> ---
> drivers/clk/tegra/clk-id.h | 16 ++++++
> drivers/clk/tegra/clk-tegra210.c | 91 ++++++++++++++++++++++++++++++++
> include/dt-bindings/clock/tegra210-car.h | 32 +++++------
> 3 files changed, 123 insertions(+), 16 deletions(-)
There's no rationale given here about why we need this. What will these
second level clock gates be used for? Why do we need these (seemingly)
duplicate clock entries.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Rhyland Klein <rklein-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Cc: Peter De Schrijver
<pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
Prashant Gaikwad
<pgaikwad-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
Michael Turquette
<mturquette-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>,
Stephen Boyd <sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>,
Alexandre Courbot
<gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Jon Hunter <jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
linux-clk-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Bill Huang <bilhuang-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH] clk: tegra210: Add SLCG override gate clocks
Date: Mon, 14 Mar 2016 17:05:51 +0100 [thread overview]
Message-ID: <20160314160551.GA21898@ulmo.nvidia.com> (raw)
In-Reply-To: <1457638685-31007-1-git-send-email-rklein-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 863 bytes --]
On Thu, Mar 10, 2016 at 02:38:05PM -0500, Rhyland Klein wrote:
> From: Bill Huang <bilhuang-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
>
> Add some SLCG (Second Level Clock Gating) override clocks to control
> gating and un-gating their logics.
>
> Signed-off-by: Bill Huang <bilhuang-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> Signed-off-by: Rhyland Klein <rklein-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> ---
> drivers/clk/tegra/clk-id.h | 16 ++++++
> drivers/clk/tegra/clk-tegra210.c | 91 ++++++++++++++++++++++++++++++++
> include/dt-bindings/clock/tegra210-car.h | 32 +++++------
> 3 files changed, 123 insertions(+), 16 deletions(-)
There's no rationale given here about why we need this. What will these
second level clock gates be used for? Why do we need these (seemingly)
duplicate clock entries.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-03-14 16:05 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-10 19:38 [PATCH] clk: tegra210: Add SLCG override gate clocks Rhyland Klein
2016-03-14 16:05 ` Thierry Reding [this message]
2016-03-14 16:05 ` Thierry Reding
2016-03-14 16:08 ` Rhyland Klein
2016-03-14 16:08 ` Rhyland Klein
2016-03-15 8:40 ` Jon Hunter
2016-03-15 8:40 ` Jon Hunter
2016-03-25 18:21 ` Rhyland Klein
2016-03-25 18:21 ` Rhyland Klein
2016-04-12 15:20 ` Thierry Reding
2016-04-12 17:41 ` Jon Hunter
2016-04-12 17:41 ` Jon Hunter
2016-04-22 11:12 ` Thierry Reding
2016-04-22 11:12 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160314160551.GA21898@ulmo.nvidia.com \
--to=thierry.reding@gmail.com \
--cc=bilhuang@nvidia.com \
--cc=gnurou@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=pdeschrijver@nvidia.com \
--cc=pgaikwad@nvidia.com \
--cc=rklein@nvidia.com \
--cc=sboyd@codeaurora.org \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.