* [patch] ALSA: mixart: silence an uninitialized variable warning
@ 2016-03-16 7:42 ` Dan Carpenter
0 siblings, 0 replies; 7+ messages in thread
From: Dan Carpenter @ 2016-03-16 7:42 UTC (permalink / raw)
To: Jaroslav Kysela
Cc: Takashi Iwai, Quentin Lambert, alsa-devel, linux-kernel,
kernel-janitors
We could print the uninitialized value of "stat" in the error message.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/sound/pci/mixart/mixart.c b/sound/pci/mixart/mixart.c
index bc81b9f..25c0ddd 100644
--- a/sound/pci/mixart/mixart.c
+++ b/sound/pci/mixart/mixart.c
@@ -132,7 +132,7 @@ static int mixart_set_pipe_state(struct mixart_mgr *mgr,
}
if(start) {
- u32 stat;
+ u32 stat = 0;
group_state.pipe_count = 0; /* in case of start same command once again with pipe_count=0 */
^ permalink raw reply related [flat|nested] 7+ messages in thread* [patch] ALSA: mixart: silence an uninitialized variable warning
@ 2016-03-16 7:42 ` Dan Carpenter
0 siblings, 0 replies; 7+ messages in thread
From: Dan Carpenter @ 2016-03-16 7:42 UTC (permalink / raw)
To: Jaroslav Kysela
Cc: Takashi Iwai, Quentin Lambert, alsa-devel, linux-kernel,
kernel-janitors
We could print the uninitialized value of "stat" in the error message.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/sound/pci/mixart/mixart.c b/sound/pci/mixart/mixart.c
index bc81b9f..25c0ddd 100644
--- a/sound/pci/mixart/mixart.c
+++ b/sound/pci/mixart/mixart.c
@@ -132,7 +132,7 @@ static int mixart_set_pipe_state(struct mixart_mgr *mgr,
}
if(start) {
- u32 stat;
+ u32 stat = 0;
group_state.pipe_count = 0; /* in case of start same command once again with pipe_count=0 */
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [patch] ALSA: mixart: silence an uninitialized variable warning
2016-03-16 7:42 ` Dan Carpenter
@ 2016-03-16 8:22 ` walter harms
-1 siblings, 0 replies; 7+ messages in thread
From: walter harms @ 2016-03-16 8:22 UTC (permalink / raw)
To: Dan Carpenter
Cc: Jaroslav Kysela, Takashi Iwai, Quentin Lambert, alsa-devel,
linux-kernel, kernel-janitors
Am 16.03.2016 08:42, schrieb Dan Carpenter:
> We could print the uninitialized value of "stat" in the error message.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/sound/pci/mixart/mixart.c b/sound/pci/mixart/mixart.c
> index bc81b9f..25c0ddd 100644
> --- a/sound/pci/mixart/mixart.c
> +++ b/sound/pci/mixart/mixart.c
> @@ -132,7 +132,7 @@ static int mixart_set_pipe_state(struct mixart_mgr *mgr,
> }
>
> if(start) {
> - u32 stat;
> + u32 stat = 0;
>
> group_state.pipe_count = 0; /* in case of start same command once again with pipe_count=0 */
>
@maintainer:
can someone please fix/remove the comment here ? it read like if (pipe_count==0) pipe_count = 0.
just my 2 cents,
re,
wh
> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [patch] ALSA: mixart: silence an uninitialized variable warning
@ 2016-03-16 8:22 ` walter harms
0 siblings, 0 replies; 7+ messages in thread
From: walter harms @ 2016-03-16 8:22 UTC (permalink / raw)
To: Dan Carpenter
Cc: Jaroslav Kysela, Takashi Iwai, Quentin Lambert, alsa-devel,
linux-kernel, kernel-janitors
Am 16.03.2016 08:42, schrieb Dan Carpenter:
> We could print the uninitialized value of "stat" in the error message.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/sound/pci/mixart/mixart.c b/sound/pci/mixart/mixart.c
> index bc81b9f..25c0ddd 100644
> --- a/sound/pci/mixart/mixart.c
> +++ b/sound/pci/mixart/mixart.c
> @@ -132,7 +132,7 @@ static int mixart_set_pipe_state(struct mixart_mgr *mgr,
> }
>
> if(start) {
> - u32 stat;
> + u32 stat = 0;
>
> group_state.pipe_count = 0; /* in case of start same command once again with pipe_count=0 */
>
@maintainer:
can someone please fix/remove the comment here ? it read like if (pipe_count=0) pipe_count = 0.
just my 2 cents,
re,
wh
> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [patch] ALSA: mixart: silence an uninitialized variable warning
2016-03-16 7:42 ` Dan Carpenter
(?)
@ 2016-03-16 15:35 ` Takashi Iwai
-1 siblings, 0 replies; 7+ messages in thread
From: Takashi Iwai @ 2016-03-16 15:35 UTC (permalink / raw)
To: Dan Carpenter
Cc: alsa-devel, Quentin Lambert, kernel-janitors, linux-kernel,
Takashi Iwai
On Wed, 16 Mar 2016 08:42:13 +0100,
Dan Carpenter wrote:
>
> We could print the uninitialized value of "stat" in the error message.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied, thanks.
Takashi
>
> diff --git a/sound/pci/mixart/mixart.c b/sound/pci/mixart/mixart.c
> index bc81b9f..25c0ddd 100644
> --- a/sound/pci/mixart/mixart.c
> +++ b/sound/pci/mixart/mixart.c
> @@ -132,7 +132,7 @@ static int mixart_set_pipe_state(struct mixart_mgr *mgr,
> }
>
> if(start) {
> - u32 stat;
> + u32 stat = 0;
>
> group_state.pipe_count = 0; /* in case of start same command once again with pipe_count=0 */
>
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [alsa-devel] [patch] ALSA: mixart: silence an uninitialized variable warning
@ 2016-03-16 15:35 ` Takashi Iwai
0 siblings, 0 replies; 7+ messages in thread
From: Takashi Iwai @ 2016-03-16 15:35 UTC (permalink / raw)
To: Dan Carpenter
Cc: Jaroslav Kysela, alsa-devel, Quentin Lambert, kernel-janitors,
Takashi Iwai, linux-kernel
On Wed, 16 Mar 2016 08:42:13 +0100,
Dan Carpenter wrote:
>
> We could print the uninitialized value of "stat" in the error message.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied, thanks.
Takashi
>
> diff --git a/sound/pci/mixart/mixart.c b/sound/pci/mixart/mixart.c
> index bc81b9f..25c0ddd 100644
> --- a/sound/pci/mixart/mixart.c
> +++ b/sound/pci/mixart/mixart.c
> @@ -132,7 +132,7 @@ static int mixart_set_pipe_state(struct mixart_mgr *mgr,
> }
>
> if(start) {
> - u32 stat;
> + u32 stat = 0;
>
> group_state.pipe_count = 0; /* in case of start same command once again with pipe_count=0 */
>
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [alsa-devel] [patch] ALSA: mixart: silence an uninitialized variable warning
@ 2016-03-16 15:35 ` Takashi Iwai
0 siblings, 0 replies; 7+ messages in thread
From: Takashi Iwai @ 2016-03-16 15:35 UTC (permalink / raw)
To: Dan Carpenter
Cc: alsa-devel, Quentin Lambert, kernel-janitors, linux-kernel,
Takashi Iwai
On Wed, 16 Mar 2016 08:42:13 +0100,
Dan Carpenter wrote:
>
> We could print the uninitialized value of "stat" in the error message.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied, thanks.
Takashi
>
> diff --git a/sound/pci/mixart/mixart.c b/sound/pci/mixart/mixart.c
> index bc81b9f..25c0ddd 100644
> --- a/sound/pci/mixart/mixart.c
> +++ b/sound/pci/mixart/mixart.c
> @@ -132,7 +132,7 @@ static int mixart_set_pipe_state(struct mixart_mgr *mgr,
> }
>
> if(start) {
> - u32 stat;
> + u32 stat = 0;
>
> group_state.pipe_count = 0; /* in case of start same command once again with pipe_count=0 */
>
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2016-03-16 15:35 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-16 7:42 [patch] ALSA: mixart: silence an uninitialized variable warning Dan Carpenter
2016-03-16 7:42 ` Dan Carpenter
2016-03-16 8:22 ` walter harms
2016-03-16 8:22 ` walter harms
2016-03-16 15:35 ` Takashi Iwai
2016-03-16 15:35 ` [alsa-devel] " Takashi Iwai
2016-03-16 15:35 ` Takashi Iwai
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.