From: Dan Carpenter <dan.carpenter@oracle.com>
To: Inki Dae <inki.dae@samsung.com>
Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com>,
linux-samsung-soc@vger.kernel.org,
kernel-janitors@vger.kernel.org,
Seung-Woo Kim <sw0312.kim@samsung.com>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Kyungmin Park <kyungmin.park@samsung.com>,
Kukjin Kim <kgene@kernel.org>
Subject: Re: [patch 2/2] drm/exynos: mic: remove some dead code
Date: Fri, 25 Mar 2016 20:09:15 +0000 [thread overview]
Message-ID: <20160325200915.GG30221@mwanda> (raw)
In-Reply-To: <56F4FC08.6090009@samsung.com>
On Fri, Mar 25, 2016 at 05:51:20PM +0900, Inki Dae wrote:
> Hi Dan,
>
> 2016년 03월 17일 19:39에 Dan Carpenter 이(가) 쓴 글:
> > We know "ret" is zero and the test makes static checkers complain so
> > let's delete this printk.
> >
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> >
> > diff --git a/drivers/gpu/drm/exynos/exynos_drm_mic.c b/drivers/gpu/drm/exynos/exynos_drm_mic.c
> > index 890c9b1..12db353 100644
> > --- a/drivers/gpu/drm/exynos/exynos_drm_mic.c
> > +++ b/drivers/gpu/drm/exynos/exynos_drm_mic.c
> > @@ -130,8 +130,6 @@ static void mic_set_path(struct exynos_mic *mic, bool enable)
> > val &= ~(MIC0_RGB_MUX | MIC0_I80_MUX | MIC0_ON_MUX);
> >
> > regmap_write(mic->sysreg, DSD_CFG_MUX, val);
> > - if (ret)
> > - DRM_ERROR("mic: Failed to read system register\n");
>
> I think we missed to keep return value from regmap_write function,
> ret = regmap_write(mic->sysreg, ....);
> if (ret)
> ...
Yeah. You're right.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Inki Dae <inki.dae@samsung.com>
Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com>,
linux-samsung-soc@vger.kernel.org,
kernel-janitors@vger.kernel.org,
Seung-Woo Kim <sw0312.kim@samsung.com>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Kyungmin Park <kyungmin.park@samsung.com>,
Kukjin Kim <kgene@kernel.org>
Subject: Re: [patch 2/2] drm/exynos: mic: remove some dead code
Date: Fri, 25 Mar 2016 23:09:15 +0300 [thread overview]
Message-ID: <20160325200915.GG30221@mwanda> (raw)
In-Reply-To: <56F4FC08.6090009@samsung.com>
On Fri, Mar 25, 2016 at 05:51:20PM +0900, Inki Dae wrote:
> Hi Dan,
>
> 2016년 03월 17일 19:39에 Dan Carpenter 이(가) 쓴 글:
> > We know "ret" is zero and the test makes static checkers complain so
> > let's delete this printk.
> >
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> >
> > diff --git a/drivers/gpu/drm/exynos/exynos_drm_mic.c b/drivers/gpu/drm/exynos/exynos_drm_mic.c
> > index 890c9b1..12db353 100644
> > --- a/drivers/gpu/drm/exynos/exynos_drm_mic.c
> > +++ b/drivers/gpu/drm/exynos/exynos_drm_mic.c
> > @@ -130,8 +130,6 @@ static void mic_set_path(struct exynos_mic *mic, bool enable)
> > val &= ~(MIC0_RGB_MUX | MIC0_I80_MUX | MIC0_ON_MUX);
> >
> > regmap_write(mic->sysreg, DSD_CFG_MUX, val);
> > - if (ret)
> > - DRM_ERROR("mic: Failed to read system register\n");
>
> I think we missed to keep return value from regmap_write function,
> ret = regmap_write(mic->sysreg, ....);
> if (ret)
> ...
Yeah. You're right.
regards,
dan carpenter
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Inki Dae <inki.dae@samsung.com>
Cc: Joonyoung Shim <jy0922.shim@samsung.com>,
Seung-Woo Kim <sw0312.kim@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
David Airlie <airlied@linux.ie>, Kukjin Kim <kgene@kernel.org>,
Krzysztof Kozlowski <k.kozlowski@samsung.com>,
dri-devel@lists.freedesktop.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch 2/2] drm/exynos: mic: remove some dead code
Date: Fri, 25 Mar 2016 23:09:15 +0300 [thread overview]
Message-ID: <20160325200915.GG30221@mwanda> (raw)
In-Reply-To: <56F4FC08.6090009@samsung.com>
On Fri, Mar 25, 2016 at 05:51:20PM +0900, Inki Dae wrote:
> Hi Dan,
>
> 2016년 03월 17일 19:39에 Dan Carpenter 이(가) 쓴 글:
> > We know "ret" is zero and the test makes static checkers complain so
> > let's delete this printk.
> >
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> >
> > diff --git a/drivers/gpu/drm/exynos/exynos_drm_mic.c b/drivers/gpu/drm/exynos/exynos_drm_mic.c
> > index 890c9b1..12db353 100644
> > --- a/drivers/gpu/drm/exynos/exynos_drm_mic.c
> > +++ b/drivers/gpu/drm/exynos/exynos_drm_mic.c
> > @@ -130,8 +130,6 @@ static void mic_set_path(struct exynos_mic *mic, bool enable)
> > val &= ~(MIC0_RGB_MUX | MIC0_I80_MUX | MIC0_ON_MUX);
> >
> > regmap_write(mic->sysreg, DSD_CFG_MUX, val);
> > - if (ret)
> > - DRM_ERROR("mic: Failed to read system register\n");
>
> I think we missed to keep return value from regmap_write function,
> ret = regmap_write(mic->sysreg, ....);
> if (ret)
> ...
Yeah. You're right.
regards,
dan carpenter
next prev parent reply other threads:[~2016-03-25 20:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-17 10:39 [patch 2/2] drm/exynos: mic: remove some dead code Dan Carpenter
2016-03-17 10:39 ` Dan Carpenter
2016-03-17 10:39 ` Dan Carpenter
2016-03-25 8:51 ` Inki Dae
2016-03-25 8:51 ` Inki Dae
2016-03-25 8:51 ` Inki Dae
2016-03-25 20:05 ` [patch 2/2 v2] drm/exynos: fix a warning message Dan Carpenter
2016-03-25 20:05 ` Dan Carpenter
2016-03-25 20:09 ` Dan Carpenter [this message]
2016-03-25 20:09 ` [patch 2/2] drm/exynos: mic: remove some dead code Dan Carpenter
2016-03-25 20:09 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160325200915.GG30221@mwanda \
--to=dan.carpenter@oracle.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=inki.dae@samsung.com \
--cc=k.kozlowski@samsung.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kgene@kernel.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=sw0312.kim@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.