From: Wolfram Sang <wsa@the-dreams.de>
To: "David.Wu" <david.wu@rock-chips.com>
Cc: heiko@sntech.de, dianders@chromium.org,
andy.shevchenko@gmail.com, huangtao@rock-chips.com,
hl@rock-chips.com, xjq@rock-chips.com, zyw@rock-chips.com,
cf@rock-chips.com, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org, David Wu <wdc@rock-chips.com>
Subject: Re: [PATCH v5 2/2] i2c: rk3x: add i2c support for rk3399 soc
Date: Fri, 15 Apr 2016 19:58:46 +0200 [thread overview]
Message-ID: <20160415175846.GA1533@katana> (raw)
In-Reply-To: <5710DA28.6010104@rock-chips.com>
[-- Attachment #1: Type: text/plain, Size: 623 bytes --]
> The default frequency rate of function clock is 50M Hz, it can match
> F/S mode, but HS mode not. If use default rate 50M to get 1.7M
> scl-frequency rate , we could not get accurately 1.7M frequecy rate.
> The input-clk-rate is more higher, we get more accurately
> scl-frequency rate, as 200M is a suitable input-clk-rate.
>
> If 200M was used for F/S mode, it would increase power consumption, so
> add a option that could be configured from DT.
If I understand you correctly, couldn't you use clk_set_rate() depending
on the desired scl frequency which is already described in DT as
clock-frequency?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: wsa@the-dreams.de (Wolfram Sang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 2/2] i2c: rk3x: add i2c support for rk3399 soc
Date: Fri, 15 Apr 2016 19:58:46 +0200 [thread overview]
Message-ID: <20160415175846.GA1533@katana> (raw)
In-Reply-To: <5710DA28.6010104@rock-chips.com>
> The default frequency rate of function clock is 50M Hz, it can match
> F/S mode, but HS mode not. If use default rate 50M to get 1.7M
> scl-frequency rate , we could not get accurately 1.7M frequecy rate.
> The input-clk-rate is more higher, we get more accurately
> scl-frequency rate, as 200M is a suitable input-clk-rate.
>
> If 200M was used for F/S mode, it would increase power consumption, so
> add a option that could be configured from DT.
If I understand you correctly, couldn't you use clk_set_rate() depending
on the desired scl frequency which is already described in DT as
clock-frequency?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160415/4b1078f2/attachment.sig>
next prev parent reply other threads:[~2016-04-15 17:58 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-16 16:57 [PATCH v5 0/2] updates for rk3399 i2c support David Wu
2016-03-16 16:57 ` David Wu
2016-03-16 16:57 ` [PATCH v5 1/2] i2c: rk3x: switch to i2c generic dt parsing David Wu
2016-03-16 16:57 ` David Wu
2016-04-14 18:39 ` Wolfram Sang
2016-04-14 18:39 ` Wolfram Sang
2016-03-16 16:57 ` [PATCH v5 2/2] i2c: rk3x: add i2c support for rk3399 soc David Wu
2016-03-16 16:57 ` David Wu
2016-04-14 18:48 ` Wolfram Sang
2016-04-14 18:48 ` Wolfram Sang
2016-04-15 7:31 ` Heiko Stübner
2016-04-15 7:31 ` Heiko Stübner
2016-04-15 12:12 ` David.Wu
2016-04-15 12:12 ` David.Wu
2016-04-15 12:10 ` David.Wu
2016-04-15 12:10 ` David.Wu
2016-04-15 17:58 ` Wolfram Sang [this message]
2016-04-15 17:58 ` Wolfram Sang
2016-04-18 13:15 ` David.Wu
2016-04-18 13:15 ` David.Wu
2016-04-15 12:17 ` Heiko Stübner
2016-04-15 12:17 ` Heiko Stübner
2016-04-19 13:55 ` [PATCH v6] " David Wu
2016-04-19 13:55 ` David Wu
2016-04-21 22:00 ` Andy Shevchenko
2016-04-21 22:00 ` Andy Shevchenko
2016-04-27 20:56 ` Doug Anderson
2016-04-27 20:56 ` Doug Anderson
2016-04-27 20:56 ` Doug Anderson
[not found] ` <572212AE.5060904@rock-chips.com>
2016-04-28 21:28 ` Doug Anderson
2016-04-28 21:28 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160415175846.GA1533@katana \
--to=wsa@the-dreams.de \
--cc=andy.shevchenko@gmail.com \
--cc=cf@rock-chips.com \
--cc=david.wu@rock-chips.com \
--cc=dianders@chromium.org \
--cc=heiko@sntech.de \
--cc=hl@rock-chips.com \
--cc=huangtao@rock-chips.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=wdc@rock-chips.com \
--cc=xjq@rock-chips.com \
--cc=zyw@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.