From: "Heiko Stübner" <heiko@sntech.de>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: David Wu <david.wu@rock-chips.com>,
dianders@chromium.org, andy.shevchenko@gmail.com,
huangtao@rock-chips.com, hl@rock-chips.com, xjq@rock-chips.com,
zyw@rock-chips.com, cf@rock-chips.com,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org, David Wu <wdc@rock-chips.com>
Subject: Re: [PATCH v5 2/2] i2c: rk3x: add i2c support for rk3399 soc
Date: Fri, 15 Apr 2016 09:31:55 +0200 [thread overview]
Message-ID: <2530516.Iqqf6HUmr5@diego> (raw)
In-Reply-To: <20160414184848.GB2338@katana>
David,
Am Donnerstag, 14. April 2016, 20:48:48 schrieb Wolfram Sang:
> > + - input-clk-rate : frequency rate of function clock used(in Hz). If
> > omitted, + the default clock rate is used. It is just used at rk3399 soc.
>
> Why is this needed? Why don't we simply use the default or calculate the
> best value somehow?
if you need to _get_ the clock-rate, clk_get_rate is the abvious choice and if
you need to _set_ some specific rate, I guess it should be done via the
assigned-clocks mechanism in the devicetree - see veyron dts files that already
do this for some other parts.
WARNING: multiple messages have this Message-ID (diff)
From: heiko@sntech.de (Heiko Stübner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 2/2] i2c: rk3x: add i2c support for rk3399 soc
Date: Fri, 15 Apr 2016 09:31:55 +0200 [thread overview]
Message-ID: <2530516.Iqqf6HUmr5@diego> (raw)
In-Reply-To: <20160414184848.GB2338@katana>
David,
Am Donnerstag, 14. April 2016, 20:48:48 schrieb Wolfram Sang:
> > + - input-clk-rate : frequency rate of function clock used(in Hz). If
> > omitted, + the default clock rate is used. It is just used at rk3399 soc.
>
> Why is this needed? Why don't we simply use the default or calculate the
> best value somehow?
if you need to _get_ the clock-rate, clk_get_rate is the abvious choice and if
you need to _set_ some specific rate, I guess it should be done via the
assigned-clocks mechanism in the devicetree - see veyron dts files that already
do this for some other parts.
next prev parent reply other threads:[~2016-04-15 7:31 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-16 16:57 [PATCH v5 0/2] updates for rk3399 i2c support David Wu
2016-03-16 16:57 ` David Wu
2016-03-16 16:57 ` [PATCH v5 1/2] i2c: rk3x: switch to i2c generic dt parsing David Wu
2016-03-16 16:57 ` David Wu
2016-04-14 18:39 ` Wolfram Sang
2016-04-14 18:39 ` Wolfram Sang
2016-03-16 16:57 ` [PATCH v5 2/2] i2c: rk3x: add i2c support for rk3399 soc David Wu
2016-03-16 16:57 ` David Wu
2016-04-14 18:48 ` Wolfram Sang
2016-04-14 18:48 ` Wolfram Sang
2016-04-15 7:31 ` Heiko Stübner [this message]
2016-04-15 7:31 ` Heiko Stübner
2016-04-15 12:12 ` David.Wu
2016-04-15 12:12 ` David.Wu
2016-04-15 12:10 ` David.Wu
2016-04-15 12:10 ` David.Wu
2016-04-15 17:58 ` Wolfram Sang
2016-04-15 17:58 ` Wolfram Sang
2016-04-18 13:15 ` David.Wu
2016-04-18 13:15 ` David.Wu
2016-04-15 12:17 ` Heiko Stübner
2016-04-15 12:17 ` Heiko Stübner
2016-04-19 13:55 ` [PATCH v6] " David Wu
2016-04-19 13:55 ` David Wu
2016-04-21 22:00 ` Andy Shevchenko
2016-04-21 22:00 ` Andy Shevchenko
2016-04-27 20:56 ` Doug Anderson
2016-04-27 20:56 ` Doug Anderson
2016-04-27 20:56 ` Doug Anderson
[not found] ` <572212AE.5060904@rock-chips.com>
2016-04-28 21:28 ` Doug Anderson
2016-04-28 21:28 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2530516.Iqqf6HUmr5@diego \
--to=heiko@sntech.de \
--cc=andy.shevchenko@gmail.com \
--cc=cf@rock-chips.com \
--cc=david.wu@rock-chips.com \
--cc=dianders@chromium.org \
--cc=hl@rock-chips.com \
--cc=huangtao@rock-chips.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=wdc@rock-chips.com \
--cc=wsa@the-dreams.de \
--cc=xjq@rock-chips.com \
--cc=zyw@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.