[PATCH] mm: thp: correct split_huge_pages file permission

[PATCH] mm: thp: correct split_huge_pages file permission

[Yang Shi]

split_huge_pages doesn't support get method at all, so the read permission
sounds confusing, change the permission to write only.

And, add "\n" to the output of set method to make it more readable.

Signed-off-by: Yang Shi <yang.shi@linaro.org>
---
 mm/huge_memory.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/mm/huge_memory.c b/mm/huge_memory.c
index 86f9f8b..8adf3c2 100644
--- a/mm/huge_memory.c
+++ b/mm/huge_memory.c
@@ -3454,7 +3454,7 @@ next:
 		}
 	}
 
-	pr_info("%lu of %lu THP split", split, total);
+	pr_info("%lu of %lu THP split\n", split, total);
 
 	return 0;
 }
@@ -3465,7 +3465,7 @@ static int __init split_huge_pages_debugfs(void)
 {
 	void *ret;
 
-	ret = debugfs_create_file("split_huge_pages", 0644, NULL, NULL,
+	ret = debugfs_create_file("split_huge_pages", 0200, NULL, NULL,
 			&split_huge_pages_fops);
 	if (!ret)
 		pr_warn("Failed to create split_huge_pages in debugfs");
-- 
2.0.2

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

[PATCH] mm: thp: correct split_huge_pages file permission

[Yang Shi]

split_huge_pages doesn't support get method at all, so the read permission
sounds confusing, change the permission to write only.

And, add "\n" to the output of set method to make it more readable.

Signed-off-by: Yang Shi <yang.shi@linaro.org>
---
 mm/huge_memory.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/mm/huge_memory.c b/mm/huge_memory.c
index 86f9f8b..8adf3c2 100644
--- a/mm/huge_memory.c
+++ b/mm/huge_memory.c
@@ -3454,7 +3454,7 @@ next:
 		}
 	}
 
-	pr_info("%lu of %lu THP split", split, total);
+	pr_info("%lu of %lu THP split\n", split, total);
 
 	return 0;
 }
@@ -3465,7 +3465,7 @@ static int __init split_huge_pages_debugfs(void)
 {
 	void *ret;
 
-	ret = debugfs_create_file("split_huge_pages", 0644, NULL, NULL,
+	ret = debugfs_create_file("split_huge_pages", 0200, NULL, NULL,
 			&split_huge_pages_fops);
 	if (!ret)
 		pr_warn("Failed to create split_huge_pages in debugfs");
-- 
2.0.2

Re: [PATCH] mm: thp: correct split_huge_pages file permission

[Kirill A. Shutemov]

On Fri, Apr 15, 2016 at 11:10:05AM -0700, Yang Shi wrote:
> split_huge_pages doesn't support get method at all, so the read permission
> sounds confusing, change the permission to write only.
> 
> And, add "\n" to the output of set method to make it more readable.
> 
> Signed-off-by: Yang Shi <yang.shi@linaro.org>

Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>

-- 
 Kirill A. Shutemov

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

Re: [PATCH] mm: thp: correct split_huge_pages file permission

[Kirill A. Shutemov]

On Fri, Apr 15, 2016 at 11:10:05AM -0700, Yang Shi wrote:
> split_huge_pages doesn't support get method at all, so the read permission
> sounds confusing, change the permission to write only.
> 
> And, add "\n" to the output of set method to make it more readable.
> 
> Signed-off-by: Yang Shi <yang.shi@linaro.org>

Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>

-- 
 Kirill A. Shutemov