From: Dan Carpenter <dan.carpenter@oracle.com>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: Gregory Fong <gregory.0xf0@gmail.com>,
Linus Walleij <linus.walleij@linaro.org>,
Alexandre Courbot <gnurou@gmail.com>,
Brian Norris <computersforpeace@gmail.com>,
bcm-kernel-feedback-list@broadcom.com,
linux-gpio@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] gpio: brcmstb: missing error code
Date: Fri, 15 Apr 2016 22:25:51 +0000 [thread overview]
Message-ID: <20160415222551.GL4247@mwanda> (raw)
In-Reply-To: <57116564.4000002@gmail.com>
On Fri, Apr 15, 2016 at 03:04:20PM -0700, Florian Fainelli wrote:
> On 15/04/16 07:45, Dan Carpenter wrote:
> > We should set the error code before returning here. Otherwise "err"
> > could be uninitialized or zero.
> >
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> Axel just sent an identical patch which Linus picked already:
>
> http://www.spinics.net/lists/linux-gpio/msg13728.html
Heh. Weird timing. That bug has been there for 11 months...
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: Gregory Fong <gregory.0xf0@gmail.com>,
Linus Walleij <linus.walleij@linaro.org>,
Alexandre Courbot <gnurou@gmail.com>,
Brian Norris <computersforpeace@gmail.com>,
bcm-kernel-feedback-list@broadcom.com,
linux-gpio@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] gpio: brcmstb: missing error code
Date: Sat, 16 Apr 2016 01:25:51 +0300 [thread overview]
Message-ID: <20160415222551.GL4247@mwanda> (raw)
In-Reply-To: <57116564.4000002@gmail.com>
On Fri, Apr 15, 2016 at 03:04:20PM -0700, Florian Fainelli wrote:
> On 15/04/16 07:45, Dan Carpenter wrote:
> > We should set the error code before returning here. Otherwise "err"
> > could be uninitialized or zero.
> >
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> Axel just sent an identical patch which Linus picked already:
>
> http://www.spinics.net/lists/linux-gpio/msg13728.html
Heh. Weird timing. That bug has been there for 11 months...
regards,
dan carpenter
next prev parent reply other threads:[~2016-04-15 22:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-15 14:45 [patch] gpio: brcmstb: missing error code Dan Carpenter
2016-04-15 14:45 ` Dan Carpenter
2016-04-15 22:04 ` Florian Fainelli
2016-04-15 22:04 ` Florian Fainelli
2016-04-15 22:25 ` Dan Carpenter [this message]
2016-04-15 22:25 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160415222551.GL4247@mwanda \
--to=dan.carpenter@oracle.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=computersforpeace@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=gnurou@gmail.com \
--cc=gregory.0xf0@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.