All of lore.kernel.org
 help / color / mirror / Atom feed
From: Florian Fainelli <f.fainelli@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
	Gregory Fong <gregory.0xf0@gmail.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
	Alexandre Courbot <gnurou@gmail.com>,
	Brian Norris <computersforpeace@gmail.com>,
	Florian Fainelli <f.fainelli@gmail.com>,
	bcm-kernel-feedback-list@broadcom.com,
	linux-gpio@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] gpio: brcmstb: missing error code
Date: Fri, 15 Apr 2016 22:04:20 +0000	[thread overview]
Message-ID: <57116564.4000002@gmail.com> (raw)
In-Reply-To: <20160415144528.GC8953@mwanda>

On 15/04/16 07:45, Dan Carpenter wrote:
> We should set the error code before returning here.  Otherwise "err"
> could be uninitialized or zero.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Axel just sent an identical patch which Linus picked already:

http://www.spinics.net/lists/linux-gpio/msg13728.html

Thanks Dan!
-- 
Florian

WARNING: multiple messages have this Message-ID (diff)
From: Florian Fainelli <f.fainelli@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
	Gregory Fong <gregory.0xf0@gmail.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
	Alexandre Courbot <gnurou@gmail.com>,
	Brian Norris <computersforpeace@gmail.com>,
	Florian Fainelli <f.fainelli@gmail.com>,
	bcm-kernel-feedback-list@broadcom.com,
	linux-gpio@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] gpio: brcmstb: missing error code
Date: Fri, 15 Apr 2016 15:04:20 -0700	[thread overview]
Message-ID: <57116564.4000002@gmail.com> (raw)
In-Reply-To: <20160415144528.GC8953@mwanda>

On 15/04/16 07:45, Dan Carpenter wrote:
> We should set the error code before returning here.  Otherwise "err"
> could be uninitialized or zero.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Axel just sent an identical patch which Linus picked already:

http://www.spinics.net/lists/linux-gpio/msg13728.html

Thanks Dan!
-- 
Florian

  reply	other threads:[~2016-04-15 22:04 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-15 14:45 [patch] gpio: brcmstb: missing error code Dan Carpenter
2016-04-15 14:45 ` Dan Carpenter
2016-04-15 22:04 ` Florian Fainelli [this message]
2016-04-15 22:04   ` Florian Fainelli
2016-04-15 22:25   ` Dan Carpenter
2016-04-15 22:25     ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57116564.4000002@gmail.com \
    --to=f.fainelli@gmail.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=computersforpeace@gmail.com \
    --cc=dan.carpenter@oracle.com \
    --cc=gnurou@gmail.com \
    --cc=gregory.0xf0@gmail.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.