From: Stephen Boyd <sboyd@codeaurora.org>
To: Rhyland Klein <rklein@nvidia.com>
Cc: Peter De Schrijver <pdeschrijver@nvidia.com>,
Prashant Gaikwad <pgaikwad@nvidia.com>,
Stephen Warren <swarren@wwwdotorg.org>,
Thierry Reding <thierry.reding@gmail.com>,
Michael Turquette <mturquette@baylibre.com>,
Alexandre Courbot <gnurou@gmail.com>,
linux-clk@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org,
Andrew Bresticker <abrestic@chromium.org>
Subject: Re: [PATCH 2/2] clk: tegra: Initialize UTMIPLL when enabling PLLU
Date: Fri, 15 Apr 2016 16:49:03 -0700 [thread overview]
Message-ID: <20160415234903.GA12052@codeaurora.org> (raw)
In-Reply-To: <1458590333-8898-2-git-send-email-rklein@nvidia.com>
On 03/21, Rhyland Klein wrote:
> +static int clk_pllu_enable(struct clk_hw *hw)
> +{
> + struct tegra_clk_pll *pll = to_clk_pll(hw);
> + struct clk *osc = __clk_lookup("osc");
Is there any way to _not_ use __clk_lookup() here? That function
is on my kill list, mostly because it can't handle probe defer
and is a hacky way to circumvent regular clk_get().
> + unsigned long flags, input_rate;
> + unsigned int i;
> + int ret = 0;
> + u32 val;
> +
> + if (!osc) {
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2016-04-15 23:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-21 19:58 [PATCH 1/2] clk: tegra: Fix pllre Tegra210 and add pll_re_out1 Rhyland Klein
2016-03-21 19:58 ` Rhyland Klein
2016-03-21 19:58 ` [PATCH 2/2] clk: tegra: Initialize UTMIPLL when enabling PLLU Rhyland Klein
2016-04-15 23:49 ` Stephen Boyd [this message]
2016-04-08 15:19 ` [PATCH 1/2] clk: tegra: Fix pllre Tegra210 and add pll_re_out1 Rhyland Klein
2016-04-08 15:19 ` Rhyland Klein
2016-04-12 15:23 ` Thierry Reding
2016-04-12 15:23 ` Thierry Reding
2016-04-15 15:29 ` Rhyland Klein
2016-04-15 15:29 ` Rhyland Klein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160415234903.GA12052@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=abrestic@chromium.org \
--cc=gnurou@gmail.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=pdeschrijver@nvidia.com \
--cc=pgaikwad@nvidia.com \
--cc=rklein@nvidia.com \
--cc=swarren@wwwdotorg.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.