From: Jarkko Nikula <jarkko.nikula@bitmer.com>
To: "J.D. Schroeder" <Linux.HWI@garmin.com>
Cc: alsa-devel@alsa-project.org,
"J.D. Schroeder" <jay.schroeder@garmin.com>,
lgirdwood@gmail.com, linux-kernel@vger.kernel.org,
tiwai@suse.com, peter.ujfalusi@ti.com,
Jim Lodes <jim.lodes@garmin.com>,
broonie@kernel.org, linux-omap@vger.kernel.org
Subject: Re: [PATCH] ASoC: omap-pcm: Initialize DMA configuration
Date: Tue, 26 Apr 2016 16:01:56 +0300 [thread overview]
Message-ID: <20160426130156.GA15388@bitmer.com> (raw)
In-Reply-To: <1461600607-19582-1-git-send-email-Linux.HWI@garmin.com>
On Mon, Apr 25, 2016 at 11:10:07AM -0500, J.D. Schroeder wrote:
> From: Jim Lodes <jim.lodes@garmin.com>
>
> Initialize the dma_slave_config for PCM DMA transfers,
> instead of leaving it uninitialized. Keeps previous data on
> the stack from giving us invalid values in uninitialized
> members of the config structure.
>
> Signed-off-by: Jim Lodes <jim.lodes@garmin.com>
> Signed-off-by: J.D. Schroeder <jay.schroeder@garmin.com>
> ---
> sound/soc/omap/omap-pcm.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/sound/soc/omap/omap-pcm.c b/sound/soc/omap/omap-pcm.c
> index 99381a2..a84f677 100644
> --- a/sound/soc/omap/omap-pcm.c
> +++ b/sound/soc/omap/omap-pcm.c
> @@ -82,6 +82,8 @@ static int omap_pcm_hw_params(struct snd_pcm_substream *substream,
> struct dma_chan *chan;
> int err = 0;
>
> + memset(&config, 0x00, sizeof(config));
Based on a894bd7fb539 ("ASoC: generic-dmaengine-pcm: Clear slave_config
memory")
Acked-by: Jarkko Nikula <jarkko.nikula@bitmer.com>
Reviewed-by: Jarkko Nikula <jarkko.nikula@bitmer.com>
WARNING: multiple messages have this Message-ID (diff)
From: Jarkko Nikula <jarkko.nikula@bitmer.com>
To: "J.D. Schroeder" <Linux.HWI@garmin.com>
Cc: linux-kernel@vger.kernel.org, peter.ujfalusi@ti.com,
lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz,
tiwai@suse.com, alsa-devel@alsa-project.org,
linux-omap@vger.kernel.org, Jim Lodes <jim.lodes@garmin.com>,
"J.D. Schroeder" <jay.schroeder@garmin.com>
Subject: Re: [PATCH] ASoC: omap-pcm: Initialize DMA configuration
Date: Tue, 26 Apr 2016 16:01:56 +0300 [thread overview]
Message-ID: <20160426130156.GA15388@bitmer.com> (raw)
In-Reply-To: <1461600607-19582-1-git-send-email-Linux.HWI@garmin.com>
On Mon, Apr 25, 2016 at 11:10:07AM -0500, J.D. Schroeder wrote:
> From: Jim Lodes <jim.lodes@garmin.com>
>
> Initialize the dma_slave_config for PCM DMA transfers,
> instead of leaving it uninitialized. Keeps previous data on
> the stack from giving us invalid values in uninitialized
> members of the config structure.
>
> Signed-off-by: Jim Lodes <jim.lodes@garmin.com>
> Signed-off-by: J.D. Schroeder <jay.schroeder@garmin.com>
> ---
> sound/soc/omap/omap-pcm.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/sound/soc/omap/omap-pcm.c b/sound/soc/omap/omap-pcm.c
> index 99381a2..a84f677 100644
> --- a/sound/soc/omap/omap-pcm.c
> +++ b/sound/soc/omap/omap-pcm.c
> @@ -82,6 +82,8 @@ static int omap_pcm_hw_params(struct snd_pcm_substream *substream,
> struct dma_chan *chan;
> int err = 0;
>
> + memset(&config, 0x00, sizeof(config));
Based on a894bd7fb539 ("ASoC: generic-dmaengine-pcm: Clear slave_config
memory")
Acked-by: Jarkko Nikula <jarkko.nikula@bitmer.com>
Reviewed-by: Jarkko Nikula <jarkko.nikula@bitmer.com>
next prev parent reply other threads:[~2016-04-26 13:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-25 16:10 [PATCH] ASoC: omap-pcm: Initialize DMA configuration J.D. Schroeder
2016-04-25 16:10 ` J.D. Schroeder
2016-04-26 13:01 ` Jarkko Nikula [this message]
2016-04-26 13:01 ` Jarkko Nikula
2016-04-26 18:24 ` Applied "ASoC: omap-pcm: Initialize DMA configuration" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160426130156.GA15388@bitmer.com \
--to=jarkko.nikula@bitmer.com \
--cc=Linux.HWI@garmin.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=jay.schroeder@garmin.com \
--cc=jim.lodes@garmin.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=peter.ujfalusi@ti.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.