* [PATCH] ASoC: omap-pcm: Initialize DMA configuration
@ 2016-04-25 16:10 ` J.D. Schroeder
0 siblings, 0 replies; 5+ messages in thread
From: J.D. Schroeder @ 2016-04-25 16:10 UTC (permalink / raw)
To: linux-kernel, peter.ujfalusi, lgirdwood, broonie, perex, tiwai,
jarkko.nikula, alsa-devel, linux-omap
Cc: Jim Lodes, J.D. Schroeder
From: Jim Lodes <jim.lodes@garmin.com>
Initialize the dma_slave_config for PCM DMA transfers,
instead of leaving it uninitialized. Keeps previous data on
the stack from giving us invalid values in uninitialized
members of the config structure.
Signed-off-by: Jim Lodes <jim.lodes@garmin.com>
Signed-off-by: J.D. Schroeder <jay.schroeder@garmin.com>
---
sound/soc/omap/omap-pcm.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/sound/soc/omap/omap-pcm.c b/sound/soc/omap/omap-pcm.c
index 99381a2..a84f677 100644
--- a/sound/soc/omap/omap-pcm.c
+++ b/sound/soc/omap/omap-pcm.c
@@ -82,6 +82,8 @@ static int omap_pcm_hw_params(struct snd_pcm_substream *substream,
struct dma_chan *chan;
int err = 0;
+ memset(&config, 0x00, sizeof(config));
+
dma_data = snd_soc_dai_get_dma_data(rtd->cpu_dai, substream);
/* return if this is a bufferless transfer e.g.
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] ASoC: omap-pcm: Initialize DMA configuration
2016-04-25 16:10 ` J.D. Schroeder
@ 2016-04-26 13:01 ` Jarkko Nikula
-1 siblings, 0 replies; 5+ messages in thread
From: Jarkko Nikula @ 2016-04-26 13:01 UTC (permalink / raw)
To: J.D. Schroeder
Cc: alsa-devel, J.D. Schroeder, lgirdwood, linux-kernel, tiwai,
peter.ujfalusi, Jim Lodes, broonie, linux-omap
On Mon, Apr 25, 2016 at 11:10:07AM -0500, J.D. Schroeder wrote:
> From: Jim Lodes <jim.lodes@garmin.com>
>
> Initialize the dma_slave_config for PCM DMA transfers,
> instead of leaving it uninitialized. Keeps previous data on
> the stack from giving us invalid values in uninitialized
> members of the config structure.
>
> Signed-off-by: Jim Lodes <jim.lodes@garmin.com>
> Signed-off-by: J.D. Schroeder <jay.schroeder@garmin.com>
> ---
> sound/soc/omap/omap-pcm.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/sound/soc/omap/omap-pcm.c b/sound/soc/omap/omap-pcm.c
> index 99381a2..a84f677 100644
> --- a/sound/soc/omap/omap-pcm.c
> +++ b/sound/soc/omap/omap-pcm.c
> @@ -82,6 +82,8 @@ static int omap_pcm_hw_params(struct snd_pcm_substream *substream,
> struct dma_chan *chan;
> int err = 0;
>
> + memset(&config, 0x00, sizeof(config));
Based on a894bd7fb539 ("ASoC: generic-dmaengine-pcm: Clear slave_config
memory")
Acked-by: Jarkko Nikula <jarkko.nikula@bitmer.com>
Reviewed-by: Jarkko Nikula <jarkko.nikula@bitmer.com>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] ASoC: omap-pcm: Initialize DMA configuration
@ 2016-04-26 13:01 ` Jarkko Nikula
0 siblings, 0 replies; 5+ messages in thread
From: Jarkko Nikula @ 2016-04-26 13:01 UTC (permalink / raw)
To: J.D. Schroeder
Cc: linux-kernel, peter.ujfalusi, lgirdwood, broonie, perex, tiwai,
alsa-devel, linux-omap, Jim Lodes, J.D. Schroeder
On Mon, Apr 25, 2016 at 11:10:07AM -0500, J.D. Schroeder wrote:
> From: Jim Lodes <jim.lodes@garmin.com>
>
> Initialize the dma_slave_config for PCM DMA transfers,
> instead of leaving it uninitialized. Keeps previous data on
> the stack from giving us invalid values in uninitialized
> members of the config structure.
>
> Signed-off-by: Jim Lodes <jim.lodes@garmin.com>
> Signed-off-by: J.D. Schroeder <jay.schroeder@garmin.com>
> ---
> sound/soc/omap/omap-pcm.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/sound/soc/omap/omap-pcm.c b/sound/soc/omap/omap-pcm.c
> index 99381a2..a84f677 100644
> --- a/sound/soc/omap/omap-pcm.c
> +++ b/sound/soc/omap/omap-pcm.c
> @@ -82,6 +82,8 @@ static int omap_pcm_hw_params(struct snd_pcm_substream *substream,
> struct dma_chan *chan;
> int err = 0;
>
> + memset(&config, 0x00, sizeof(config));
Based on a894bd7fb539 ("ASoC: generic-dmaengine-pcm: Clear slave_config
memory")
Acked-by: Jarkko Nikula <jarkko.nikula@bitmer.com>
Reviewed-by: Jarkko Nikula <jarkko.nikula@bitmer.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Applied "ASoC: omap-pcm: Initialize DMA configuration" to the asoc tree
2016-04-25 16:10 ` J.D. Schroeder
(?)
(?)
@ 2016-04-26 18:24 ` Mark Brown
-1 siblings, 0 replies; 5+ messages in thread
From: Mark Brown @ 2016-04-26 18:24 UTC (permalink / raw)
To: Jim Lodes
Cc: J.D. Schroeder, linux-omap, alsa-devel, tiwai, linux-kernel,
lgirdwood, peter.ujfalusi, broonie, jarkko.nikula
The patch
ASoC: omap-pcm: Initialize DMA configuration
has been applied to the asoc tree at
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
>From 989ff7754a27a1fcc0c3b2794c985b31811871a0 Mon Sep 17 00:00:00 2001
From: Jim Lodes <jim.lodes@garmin.com>
Date: Mon, 25 Apr 2016 11:10:07 -0500
Subject: [PATCH] ASoC: omap-pcm: Initialize DMA configuration
Initialize the dma_slave_config for PCM DMA transfers,
instead of leaving it uninitialized. Keeps previous data on
the stack from giving us invalid values in uninitialized
members of the config structure.
Signed-off-by: Jim Lodes <jim.lodes@garmin.com>
Signed-off-by: J.D. Schroeder <jay.schroeder@garmin.com>
Acked-by: Jarkko Nikula <jarkko.nikula@bitmer.com>
Reviewed-by: Jarkko Nikula <jarkko.nikula@bitmer.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
sound/soc/omap/omap-pcm.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/sound/soc/omap/omap-pcm.c b/sound/soc/omap/omap-pcm.c
index 6bb623a2a4df..eb81b9a2293a 100644
--- a/sound/soc/omap/omap-pcm.c
+++ b/sound/soc/omap/omap-pcm.c
@@ -82,6 +82,8 @@ static int omap_pcm_hw_params(struct snd_pcm_substream *substream,
struct dma_chan *chan;
int err = 0;
+ memset(&config, 0x00, sizeof(config));
+
dma_data = snd_soc_dai_get_dma_data(rtd->cpu_dai, substream);
/* return if this is a bufferless transfer e.g.
--
2.8.0.rc3
^ permalink raw reply related [flat|nested] 5+ messages in thread