* Re: [PATCH 1/3] Drivers: hv: balloon: don't crash when memory is added in non-sorted order [not found] ` <1461955519-32276-1-git-send-email-kys@microsoft.com> @ 2016-04-30 21:02 ` Greg KH 2016-04-30 21:38 ` KY Srinivasan 0 siblings, 1 reply; 2+ messages in thread From: Greg KH @ 2016-04-30 21:02 UTC (permalink / raw) To: K. Y. Srinivasan; +Cc: linux-kernel, devel, olaf, apw, vkuznets, jasowang On Fri, Apr 29, 2016 at 11:45:17AM -0700, K. Y. Srinivasan wrote: > From: Vitaly Kuznetsov <vkuznets@redhat.com> > > When we iterate through all HA regions in handle_pg_range() we have an > assumption that all these regions are sorted in the list and the > 'start_pfn >= has->end_pfn' check is enough to find the proper region. > Unfortunately it's not the case with WS2016 where host can hot-add regions > in a different order. We end up modifying the wrong HA region and crashing > later on pages online. Modify the check to make sure we found the region > we were searching for while iterating. Fix the same check in pfn_covered() > as well. > > Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com> > Signed-off-by: K. Y. Srinivasan <kys@microsoft.com> > --- > drivers/hv/hv_balloon.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) I only received patch 1/3 here, what happened to the other 2? Can you resend the whole series? thanks, greg k-h ^ permalink raw reply [flat|nested] 2+ messages in thread
* RE: [PATCH 1/3] Drivers: hv: balloon: don't crash when memory is added in non-sorted order 2016-04-30 21:02 ` [PATCH 1/3] Drivers: hv: balloon: don't crash when memory is added in non-sorted order Greg KH @ 2016-04-30 21:38 ` KY Srinivasan 0 siblings, 0 replies; 2+ messages in thread From: KY Srinivasan @ 2016-04-30 21:38 UTC (permalink / raw) To: Greg KH Cc: linux-kernel@vger.kernel.org, devel@linuxdriverproject.org, olaf@aepfle.de, apw@canonical.com, vkuznets@redhat.com, jasowang@redhat.com > -----Original Message----- > From: Greg KH [mailto:gregkh@linuxfoundation.org] > Sent: Saturday, April 30, 2016 2:03 PM > To: KY Srinivasan <kys@microsoft.com> > Cc: linux-kernel@vger.kernel.org; devel@linuxdriverproject.org; > olaf@aepfle.de; apw@canonical.com; vkuznets@redhat.com; > jasowang@redhat.com > Subject: Re: [PATCH 1/3] Drivers: hv: balloon: don't crash when memory is > added in non-sorted order > > On Fri, Apr 29, 2016 at 11:45:17AM -0700, K. Y. Srinivasan wrote: > > From: Vitaly Kuznetsov <vkuznets@redhat.com> > > > > When we iterate through all HA regions in handle_pg_range() we have an > > assumption that all these regions are sorted in the list and the > > 'start_pfn >= has->end_pfn' check is enough to find the proper region. > > Unfortunately it's not the case with WS2016 where host can hot-add > regions > > in a different order. We end up modifying the wrong HA region and > crashing > > later on pages online. Modify the check to make sure we found the region > > we were searching for while iterating. Fix the same check in pfn_covered() > > as well. > > > > Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com> > > Signed-off-by: K. Y. Srinivasan <kys@microsoft.com> > > --- > > drivers/hv/hv_balloon.c | 4 ++-- > > 1 files changed, 2 insertions(+), 2 deletions(-) > > I only received patch 1/3 here, what happened to the other 2? > > Can you resend the whole series? Will do. Thanks, K. Y > > thanks, > > greg k-h ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-04-30 21:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1461955494-32235-1-git-send-email-kys@microsoft.com>
[not found] ` <1461955519-32276-1-git-send-email-kys@microsoft.com>
2016-04-30 21:02 ` [PATCH 1/3] Drivers: hv: balloon: don't crash when memory is added in non-sorted order Greg KH
2016-04-30 21:38 ` KY Srinivasan
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.