From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Alessandro Zummo <a.zummo@towertech.it>,
Michael Buesch <m@bues.ch>,
Mylene JOSSERAND <mylene.josserand@free-electrons.com>,
rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org
Subject: [rtc-linux] Re: [PATCH] rtc: rv3029: hide unused i2c device table
Date: Wed, 4 May 2016 12:08:50 +0200 [thread overview]
Message-ID: <20160504100850.GA2430@piout.net> (raw)
In-Reply-To: <1462355432-473635-1-git-send-email-arnd@arndb.de>
On 04/05/2016 at 11:50:02 +0200, Arnd Bergmann wrote :
> The added support for SPI mode made it possible to configure the driver
> when I2C is disabled, leaving an unused device table:
>
> drivers/rtc/rtc-rv3029c2.c:794:29: error: 'rv3029_id' defined but not used [-Werror=unused-variable]
>
> This moves the table inside of the #ifdef section that has the
> only user, to avoid the harmless warning.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: d08f50dd0afc ("rtc: rv3029: Add support of RV3049")
> ---
> drivers/rtc/rtc-rv3029c2.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
Applied, thanks.
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
--
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
WARNING: multiple messages have this Message-ID (diff)
From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Alessandro Zummo <a.zummo@towertech.it>,
Michael Buesch <m@bues.ch>,
Mylene JOSSERAND <mylene.josserand@free-electrons.com>,
rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rtc: rv3029: hide unused i2c device table
Date: Wed, 4 May 2016 12:08:50 +0200 [thread overview]
Message-ID: <20160504100850.GA2430@piout.net> (raw)
In-Reply-To: <1462355432-473635-1-git-send-email-arnd@arndb.de>
On 04/05/2016 at 11:50:02 +0200, Arnd Bergmann wrote :
> The added support for SPI mode made it possible to configure the driver
> when I2C is disabled, leaving an unused device table:
>
> drivers/rtc/rtc-rv3029c2.c:794:29: error: 'rv3029_id' defined but not used [-Werror=unused-variable]
>
> This moves the table inside of the #ifdef section that has the
> only user, to avoid the harmless warning.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: d08f50dd0afc ("rtc: rv3029: Add support of RV3049")
> ---
> drivers/rtc/rtc-rv3029c2.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
Applied, thanks.
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-05-04 10:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-04 9:50 [rtc-linux] [PATCH] rtc: rv3029: hide unused i2c device table Arnd Bergmann
2016-05-04 9:50 ` Arnd Bergmann
2016-05-04 10:08 ` Alexandre Belloni [this message]
2016-05-04 10:08 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160504100850.GA2430@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=a.zummo@towertech.it \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=m@bues.ch \
--cc=mylene.josserand@free-electrons.com \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.