All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Vineet Gupta <Vineet.Gupta1@synopsys.com>,
	Nicolas Pitre <nicolas.pitre@linaro.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	David Hildenbrand <dahi@linux.vnet.ibm.com>,
	Russell King <linux@arm.linux.org.uk>,
	lkml <linux-kernel@vger.kernel.org>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	"linux-arch@vger.kernel.org" <linux-arch@vger.kernel.org>
Subject: Re: kmap_atomic and preemption
Date: Wed, 4 May 2016 15:53:45 +0200	[thread overview]
Message-ID: <20160504155345.5fdd366e@free-electrons.com> (raw)
In-Reply-To: <20160504134729.GP3430@twins.programming.kicks-ass.net>

Hello,

On Wed, 4 May 2016 15:47:29 +0200, Peter Zijlstra wrote:

> static inline void *kmap_atomic(struct page *page)
> {
> 	preempt_disable();
> 	pagefault_disable();
> 	if (!PageHighMem(page))
> 		return page_address(page);
> 
> 	return __kmap_atomic(page);
> }

This is essentially what has been done on ARM in commit
9ff0bb5ba60638a688a46e93df8c5009896672eb, showing a pretty significant
improvement in network workloads.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Vineet Gupta <Vineet.Gupta1@synopsys.com>,
	Nicolas Pitre <nicolas.pitre@linaro.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	David Hildenbrand <dahi@linux.vnet.ibm.com>,
	Russell King <linux@arm.linux.org.uk>,
	lkml <linux-kernel@vger.kernel.org>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	"linux-arch@vger.kernel.org" <linux-arch@vger.kernel.org>
Subject: Re: kmap_atomic and preemption
Date: Wed, 4 May 2016 15:53:45 +0200	[thread overview]
Message-ID: <20160504155345.5fdd366e@free-electrons.com> (raw)
Message-ID: <20160504135345.SpzdxHJ-QzhjJMq29R4mDdgiAO6huTzWtTKhSSzafO8@z> (raw)
In-Reply-To: <20160504134729.GP3430@twins.programming.kicks-ass.net>

Hello,

On Wed, 4 May 2016 15:47:29 +0200, Peter Zijlstra wrote:

> static inline void *kmap_atomic(struct page *page)
> {
> 	preempt_disable();
> 	pagefault_disable();
> 	if (!PageHighMem(page))
> 		return page_address(page);
> 
> 	return __kmap_atomic(page);
> }

This is essentially what has been done on ARM in commit
9ff0bb5ba60638a688a46e93df8c5009896672eb, showing a pretty significant
improvement in network workloads.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2016-05-04 13:53 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-04 10:37 kmap_atomic and preemption Vineet Gupta
2016-05-04 10:37 ` Vineet Gupta
2016-05-04 13:47 ` Peter Zijlstra
2016-05-04 13:47   ` Peter Zijlstra
2016-05-04 13:53   ` Thomas Petazzoni [this message]
2016-05-04 13:53     ` Thomas Petazzoni
2016-05-04 14:01     ` Vineet Gupta
2016-05-04 14:01       ` Vineet Gupta
2016-05-04 14:16   ` Vineet Gupta
2016-05-04 14:16     ` Vineet Gupta
2016-05-04 15:01     ` Peter Zijlstra
2016-05-04 15:01       ` Peter Zijlstra
2016-05-05 12:37       ` Vineet Gupta
2016-05-05 12:37         ` Vineet Gupta
2016-05-04 19:17   ` Russell King - ARM Linux
2016-05-04 19:17     ` Russell King - ARM Linux
2016-05-05  9:37     ` Peter Zijlstra
2016-05-05  9:37       ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160504155345.5fdd366e@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=Vineet.Gupta1@synopsys.com \
    --cc=akpm@linux-foundation.org \
    --cc=dahi@linux.vnet.ibm.com \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux@arm.linux.org.uk \
    --cc=nicolas.pitre@linaro.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.